From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mx.groups.io with SMTP id smtpd.web11.27962.1681248590895232651 for ; Tue, 11 Apr 2023 14:29:51 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=ZU+7gi21; spf=pass (domain: bsdio.com, ip: 66.111.4.28, mailfrom: rebecca@bsdio.com) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 03FC75C0101; Tue, 11 Apr 2023 17:29:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 11 Apr 2023 17:29:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681248587; x=1681334987; bh=/lKNpBEYrS6oSWE2QU5pK3xBL8XvTO6m/0E 6yXpWQf4=; b=ZU+7gi21yjNLqCdYYTJ19UIVIP3n5r7mohADf39llOZnrj2I6DN H4hP3DSI1+IWcLXbIb9vWkLhkfQE0p52hR/7rcT5d3WBCndarsQfeshSck87pTsv 1gGsQR/Jhi+u7wACkW30Yk5mbXffBruIy2XQ+pxnInQm5nK48YprJAoAsknEAqqF N/mOMHAmCNT5LyvNTkd7F9gT2A1uSFINS0c4XIim8tbMFX+6cpMmrHJoQe7VtHB1 D0aKsuxxRBQQYw8ds7T2YVgZvFMC8/rLPAn2Q5mX7XDJUxjly4ADDUiDYzls2eju Uv7oIJqOu70rLUr+oIznzKeQHdRrs24Zicg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1681248587; x= 1681334987; bh=/lKNpBEYrS6oSWE2QU5pK3xBL8XvTO6m/0E6yXpWQf4=; b=h e5hB9xnwxgsucofIqwKPWzY9cIPe+pbZ5kQDBa/4IXvi78T2iS6crG6up9Xwh11B IpWfwGhi+SkPcIRQ1nMWdf4YlwVVRzXknfzNyVePyf3IjrxLYgOQYjDGP+FgvqQ/ CvL+ZgqSceLRHWnKRAhedJjXR0UMo2E9dGoj7C1l3MxWNKrekMsF5BU+zI0CT8/o fWN17n8Cx8gEv0WzBavQPikq7BIuclWsQ2fvq82/bR/VnnTelPrxyA2YtFd+8HLy KJABj97oSQ3Gls+lT+TT+hvvnWj1ybdnwUoc+hgIXVjSnEcQrWlYDBm06hsbwu8H R0+BjU811eupr0Ll/rjCw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekgedgudeivdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeeludevtdeltdevvdeuudegueduieeitdeuuddvffeukeefjeffuddvteej veffvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 Apr 2023 17:29:46 -0400 (EDT) Message-ID: <1e946a9b-004b-3d27-7b37-c37cc3a6c8b1@bsdio.com> Date: Tue, 11 Apr 2023 15:29:45 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Update PatchCheck.py to check for __FUNCTION__ To: devel@edk2.groups.io, michael.d.kinney@intel.com, "Gao, Liming" , "Feng, Bob C" , "Chen, Christine" References: <175382EDB7431FEF.3977@groups.io> <5fefe4eb-3038-7ff8-3361-085437600fff@bsdio.com> From: "Rebecca Cran" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/11/23 2:21 PM, Michael D Kinney wrote: > Should use we os.path services to get the file extension? > > There are may other file types that this check should be excluded > (e.g. .sh, .gitignore, .gitmodules, .uni). Should this check only > apply to .c, .h. What about .C and .H and also the addition of unit > tests that use c++ file extensions? __func__ is valid in C99 and C++11, so it should apply to .c, .h, .C, .H, .cpp, .hpp etc. I was wondering if we might have shell scripts that generate code too, for example OvmfPkg/QemuVideoDxe/VbeShim.sh, in which case we might only want to exclude .py which would catch this change to PatchCheck.py. -- Rebecca Cran