public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, rebecca@bsdio.com,
	Sean Brogan <sean.brogan@microsoft.com>,
	Michael Kubacki <michael.kubacki@outlook.com>,
	Michael Kinney <michael.d.kinney@intel.com>
Cc: Philippe Mathieu-Daude <philmd@redhat.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [edk2-devel] [PATCH v5 1/1] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones
Date: Thu, 30 Apr 2020 15:08:25 +0200	[thread overview]
Message-ID: <1ebde38a-7ae4-1bed-cbe6-b44b0e8dbab5@redhat.com> (raw)
In-Reply-To: <22362370-c7de-3cd8-e4f0-d2d3c383978c@redhat.com>

On 04/30/20 15:04, Laszlo Ersek wrote:
> (+Sean, Mike, Michael)
> 
> On 04/30/20 14:51, Laszlo Ersek wrote:
>> On 04/29/20 23:53, Rebecca Cran wrote:
>>> Generated mechanically with:
>>> find OvmfPkg -type f -exec sed -i -e 's/EFI_D_/DEBUG_/g' {} \;
>>>
>>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>
> 
> Submitted this patch for merging in
> <https://github.com/tianocore/edk2/pull/569>.
> 
> The CI run failed with the following error:
> 
> "Unhandled: Not found SourceFolder:
> /home/vsts/work/1/s/BaseTools/BaseToolsBuild"
> 
> https://github.com/tianocore/edk2/pull/569/checks?check_run_id=633226650
> https://github.com/tianocore/edk2/pull/569/checks?check_run_id=633226688
> https://github.com/tianocore/edk2/pull/569/checks?check_run_id=633226957
> 
> I don't know what to do about that.

Now that I've looked again, the PR has been merged.

I don't understand why those errors were raised -- but now I also don't
understand why the PR was merged in spite of errors (of any kind).

Anyway, I'll run with the result: commit 70d5086c3274.

Thanks
Laszlo


  reply	other threads:[~2020-04-30 13:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 21:53 [PATCH v5 1/1] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones Rebecca Cran
2020-04-30 12:51 ` [edk2-devel] " Laszlo Ersek
2020-04-30 13:04   ` Laszlo Ersek
2020-04-30 13:08     ` Laszlo Ersek [this message]
     [not found] <160A68F7AC397B8F.3323@groups.io>
2020-05-10  0:14 ` Rebecca Cran
2020-05-11 15:43   ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ebde38a-7ae4-1bed-cbe6-b44b0e8dbab5@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox