From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120])
 by mx.groups.io with SMTP id smtpd.web12.6402.1588252114307128155
 for <devel@edk2.groups.io>;
 Thu, 30 Apr 2020 06:08:34 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GpA9D/ro;
 spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1588252113;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=62ghLcPAQFQptWSWxDajBOh+dMoOe5vaSyy3buRHynI=;
	b=GpA9D/royxlETd2skLQSdVSB65577FBO91YBrKST9vVbhjL2JwF1uSqhfAnnkry4x1AATz
	dCO1GtQ6zYn+ijbEvhwH+mSAJ4EjFlh1IFbce8msBJQD12omGnAErQS9BQkP5McO1Vw+T6
	bBm1ta1zYzaDQ/4sk9MVgp5tdbdqhJA=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-197-kYikVexOPxy7ow0ZZMxFKg-1; Thu, 30 Apr 2020 09:08:30 -0400
X-MC-Unique: kYikVexOPxy7ow0ZZMxFKg-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 91601107ACCD;
	Thu, 30 Apr 2020 13:08:28 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-57.ams2.redhat.com [10.36.115.57])
	by smtp.corp.redhat.com (Postfix) with ESMTP id D04941001920;
	Thu, 30 Apr 2020 13:08:26 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v5 1/1] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, rebecca@bsdio.com,
 Sean Brogan <sean.brogan@microsoft.com>,
 Michael Kubacki <michael.kubacki@outlook.com>,
 Michael Kinney <michael.d.kinney@intel.com>
Cc: Philippe Mathieu-Daude <philmd@redhat.com>,
 Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@arm.com>
References: <20200429215327.606467-1-rebecca@bsdio.com>
 <aee69f0a-1094-26fe-a81e-441e1a2c49d9@redhat.com>
 <22362370-c7de-3cd8-e4f0-d2d3c383978c@redhat.com>
Message-ID: <1ebde38a-7ae4-1bed-cbe6-b44b0e8dbab5@redhat.com>
Date: Thu, 30 Apr 2020 15:08:25 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <22362370-c7de-3cd8-e4f0-d2d3c383978c@redhat.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 04/30/20 15:04, Laszlo Ersek wrote:
> (+Sean, Mike, Michael)
> 
> On 04/30/20 14:51, Laszlo Ersek wrote:
>> On 04/29/20 23:53, Rebecca Cran wrote:
>>> Generated mechanically with:
>>> find OvmfPkg -type f -exec sed -i -e 's/EFI_D_/DEBUG_/g' {} \;
>>>
>>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>
> 
> Submitted this patch for merging in
> <https://github.com/tianocore/edk2/pull/569>.
> 
> The CI run failed with the following error:
> 
> "Unhandled: Not found SourceFolder:
> /home/vsts/work/1/s/BaseTools/BaseToolsBuild"
> 
> https://github.com/tianocore/edk2/pull/569/checks?check_run_id=633226650
> https://github.com/tianocore/edk2/pull/569/checks?check_run_id=633226688
> https://github.com/tianocore/edk2/pull/569/checks?check_run_id=633226957
> 
> I don't know what to do about that.

Now that I've looked again, the PR has been merged.

I don't understand why those errors were raised -- but now I also don't
understand why the PR was merged in spite of errors (of any kind).

Anyway, I'll run with the result: commit 70d5086c3274.

Thanks
Laszlo