From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D1C4D21DFA7BE for ; Mon, 3 Apr 2017 09:16:21 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 35928804EB; Mon, 3 Apr 2017 16:16:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 35928804EB Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 35928804EB Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-102.phx2.redhat.com [10.3.117.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1C35F1749D; Mon, 3 Apr 2017 16:16:19 +0000 (UTC) To: "Song, BinX" , "edk2-devel@lists.01.org" References: <559D2DF22BC9A3468B4FA1AA547F0EF102551554@shsmsx102.ccr.corp.intel.com> Cc: "Gao, Liming" , Ard Biesheuvel From: Laszlo Ersek Message-ID: <1eca3726-e92f-7fbb-d61f-f8026c0b4762@redhat.com> Date: Mon, 3 Apr 2017 18:16:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <559D2DF22BC9A3468B4FA1AA547F0EF102551554@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 03 Apr 2017 16:16:21 +0000 (UTC) Subject: Re: [PATCH] MdeModulePkg: Fix GCC48/GCC49 build error X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Apr 2017 16:16:22 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit adding Ard On 04/01/17 10:38, Song, BinX wrote: > - Fix GCC48/GCC49 build error > > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Bell Song > --- > .../Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf > index 578f97f..4c9aff5 100644 > --- a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf > +++ b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf > @@ -54,3 +54,6 @@ > DebugLib > BaseMemoryLib > ExtractGuidedSectionLib > + > +[BuildOptions] > + GCC:*_*_*_CC_FLAGS = -fno-builtin > In "BaseTools/Conf/tools_def.template", we currently have: DEFINE GCC_ARM_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) [...] -fno-builtin [...] DEFINE GCC_AARCH64_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) [...] -fno-builtin [...] DEFINE GCC5_IA32_CC_FLAGS = DEF(GCC49_IA32_CC_FLAGS) -fno-builtin DEFINE GCC5_X64_CC_FLAGS = DEF(GCC49_X64_CC_FLAGS) -fno-builtin Now, GCC5_IA32_CC_FLAGS goes back to GCC44_ALL_CC_FLAGS, via: - GCC49_IA32_CC_FLAGS - GCC48_IA32_CC_FLAGS - GCC47_IA32_CC_FLAGS - GCC46_IA32_CC_FLAGS - GCC45_IA32_CC_FLAGS - GCC44_IA32_CC_FLAGS - GCC44_ALL_CC_FLAGS (similarly for GCC5_X64_CC_FLAGS.) So, instead of this patch for BrotliCustomDecompressLib, how about: - moving "-fno-builtin" from GCC_ARM_CC_FLAGS and GCC_AARCH64_CC_FLAGS to GCC_ALL_CC_FLAGS, and - moving "-fno-builtin" from GCC5_IA32_CC_FLAGS and GCC5_X64_CC_FLAGS to GCC44_ALL_CC_FLAGS? Do we have any reason for permitting builtins at all? Thanks, Laszlo