From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.6038.1623235048713053835 for ; Wed, 09 Jun 2021 03:37:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UysCpHvs; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623235047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tviLW+MtOYaHJq/K0GAXsDgn/MArH3r4Fml/tfcrdNI=; b=UysCpHvsqQ0GYHwgNmMpyR7W1XAYRAdyC3UQQ+qBf90BnRZvpSmoBhWEKpryP7P6n0gEdH ZFZznCO+XKqJ+QR6GKnb8/BMffBxYbz/O7rpAvnG8U5/IfWht5v8qL3tlB88CyRzTs7cxd P0K8zrLxvb9wKNDSe/20JPYH7XkSr60= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-235-A1Ee8Ed-P8axA2XF8snKBw-1; Wed, 09 Jun 2021 06:37:24 -0400 X-MC-Unique: A1Ee8Ed-P8axA2XF8snKBw-1 Received: by mail-wm1-f70.google.com with SMTP id a25-20020a7bc1d90000b029019dd2ac7025so1785928wmj.1 for ; Wed, 09 Jun 2021 03:37:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tviLW+MtOYaHJq/K0GAXsDgn/MArH3r4Fml/tfcrdNI=; b=GwKJiEDwB0f6oHKUX9Rxi5VyCGn83GpjLvDvmPVcQN7YhF9liA1E5n9kPGoaKq69OX LvPDtwZ1dF3ot4b4Yc9nDqtlnBNFBWwNVQYuGk0yc4M28ni/bvDDacoRF1lmJNaiw62c gXaUPbNyj582SxbjXj0OnPXjTRHG+KaGI1JWf1xcnZT+WCayBhIWXo/WqTgn0XJbvcqH IdCEx5T4S5n1hzZWuhTl1umD+iCzxOO1Q1xjpVQ5zXo7QvTnODzmWteEculojiZ8dSz3 6PA/JQCnKyRD513+Diq8EncCoNyIZotxXORo3uISOGiCaTbFwGspthqGi1hC3vSHgFY1 7eFw== X-Gm-Message-State: AOAM531dNxG/UscQvm8iyDt1Ylc+hduwl2Nrvea+VnnxiAgmx+aQx+I5 qQg6hcRygc+9eNoh+wM8g2Ri6sQu399zibnJBASRdr2whu9GHTkXCtvrnaI1xNlqdrokylhPN37 mNFFU0ESdrY8GIg== X-Received: by 2002:a05:600c:b50:: with SMTP id k16mr26701571wmr.137.1623235043417; Wed, 09 Jun 2021 03:37:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAcfEJNbPqt1cergPK4N1zDVs+6sb4r9AuqLMgPNXnXuvd3H+hru6k7+bip9yQZpMM1njiDA== X-Received: by 2002:a05:600c:b50:: with SMTP id k16mr26701548wmr.137.1623235043213; Wed, 09 Jun 2021 03:37:23 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id z10sm21961775wmb.26.2021.06.09.03.37.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 03:37:22 -0700 (PDT) Subject: Re: [PATCH 5/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP To: Laszlo Ersek , edk2-devel-groups-io Cc: Jiaxin Wu , Maciej Rabeda , Siyuan Fu References: <20210608130652.2434-1-lersek@redhat.com> <20210608130652.2434-6-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <1ed3245f-2cfd-dffb-baaf-0a771282e594@redhat.com> Date: Wed, 9 Jun 2021 12:37:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210608130652.2434-6-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 6/8/21 3:06 PM, Laszlo Ersek wrote: > Insert a SHA256 CHAP_HASH structure at the start of "mChapHash". > > Update ISCSI_CHAP_MAX_DIGEST_SIZE to SHA256_DIGEST_SIZE (32). > > This enables the initiator and the target to negotiate SHA256 for CHAP, in > preference to MD5. > > Cc: Jiaxin Wu > Cc: Maciej Rabeda > Cc: Philippe Mathieu-Daudé > Cc: Siyuan Fu > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3355 > Signed-off-by: Laszlo Ersek > --- > NetworkPkg/IScsiDxe/IScsiCHAP.h | 3 ++- > NetworkPkg/IScsiDxe/IScsiCHAP.c | 12 ++++++++++++ > 2 files changed, 14 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daude