Re: [edk2-devel] [PATCH v4 19/37] UefiCpuPkg: Add MMIO method in CpuIo2Dxe

["Chao Li" <lichao@loongson.cn>]

[-- Attachment #1: Type: text/plain, Size: 2139 bytes --]



Thanks,
Chao
On 2023/12/22 17:47, Ard Biesheuvel wrote:
> On Fri, 22 Dec 2023 at 03:37, Ni, Ray<ray.ni@intel.com>  wrote:
>> Good to me.
>>
>>
>>
>> Thanks,
>>
>> Ray
>>
>> From: Chao Li<lichao@loongson.cn>
>> Sent: Friday, December 22, 2023 9:15 AM
>> To:devel@edk2.groups.io;ardb@kernel.org; Ni, Ray<ray.ni@intel.com>
>> Cc: Kumar, Rahul R<rahul.r.kumar@intel.com>; Gerd Hoffmann<kraxel@redhat.com>; Leif Lindholm<quic_llindhol@quicinc.com>; Ard Biesheuvel<ardb+tianocore@kernel.org>; Sami Mujawar<sami.mujawar@arm.com>
>> Subject: Re: [edk2-devel] [PATCH v4 19/37] UefiCpuPkg: Add MMIO method in CpuIo2Dxe
>>
>>
>>
>>
>>
>>
>>
>> Thanks,
>> Chao
>>
>> On 2023/12/21 21:59, Ard Biesheuvel wrote:
>>
>> On Thu, 21 Dec 2023 at 13:41, Chao Li<lichao@loongson.cn>  wrote:
>>
>>
>>
>> ...
>>
>> A given platform will either be able to use port IO, or it will need
>>
>> to use MMIO translation. So a driver that can do both based on a PCD
>>
>> is not very useful, it makes more sense to have two different drivers,
>>
>> and the platform incorporates the one it can use.
>>
>>
>>
>> Ok, I get it, I think you are more inclined to move the ArmCpuIo2Dxe to a new place and rename it, maybe: CpuMmio2Dxe, while some platforms choose the different CpuIo2 drvier by themselves when building FW, right?
>>
>>
>
> OK.
>
> Note that there are 15 references to
>
> ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf
>
> in edk2-platforms, so if you move the existing driver, please
>
> - create the new one by making a copy
> - update all edk2 and edk2-platforms users to refer to the new version
> - delete the old version
Ok, I will do the last two steps as you said after this patch series is 
merged.
>
>
> 
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112844): https://edk2.groups.io/g/devel/message/112844
Mute This Topic: https://groups.io/mt/103261693/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 4302 bytes --]