From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1F960941419 for ; Fri, 22 Dec 2023 09:56:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9QFmsba9Ucc8bwHp07A73BI9U725Uc+M98uOeA3zduo=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1703238976; v=1; b=NxjsERkgEee9sHROsIveBIjMfsmhNNRRtJib/h65KILPxXk56glRgALlgYcKqDn2xanWUGh5 6mNBtHy97LAoVRkfINcyBLMp/jIv8SkeIacZbgt8SVOyJkHP/BUjtlQacv4V1FHbMoKGZhjDQXJ blQsDb5PI8bNr/tcsoofHBqg= X-Received: by 127.0.0.2 with SMTP id GIkaYY7687511xXx9PvRhbHG; Fri, 22 Dec 2023 01:56:16 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.20239.1703238974641326560 for ; Fri, 22 Dec 2023 01:56:15 -0800 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8AxG+k3XYVl+s8DAA--.19347S3; Fri, 22 Dec 2023 17:56:07 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Bx3uQ1XYVlznQFAA--.27369S3; Fri, 22 Dec 2023 17:56:05 +0800 (CST) Message-ID: <1ed819f0-7898-4fc7-a266-4f9711986389@loongson.cn> Date: Fri, 22 Dec 2023 17:56:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v4 19/37] UefiCpuPkg: Add MMIO method in CpuIo2Dxe To: devel@edk2.groups.io, ardb@kernel.org, "Ni, Ray" Cc: "Kumar, Rahul R" , Gerd Hoffmann , Leif Lindholm , Ard Biesheuvel , Sami Mujawar References: <20231212130932.2467028-1-lichao@loongson.cn> <17A017C201FEB90D.32321@groups.io> <9014a7b3-095c-42b1-a9ef-5a388818385d@loongson.cn> <0a00f876-0bc5-4cf7-9252-b21520463034@loongson.cn> <97c6da30-758d-48cd-a3c9-558262144f77@loongson.cn> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8Bx3uQ1XYVlznQFAA--.27369S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQANCGWE8i4HAAADs9 X-Coremail-Antispam: 1Uk129KBj93XoW7ArW5tr1DXF4DGF45AF47GFX_yoW8ZrWfpa 1DJFyYyryvgw10y3yUGr1UZ3WSvwsayFyDJr1DAr10v3Z3WF4vkrW7GryDArW7Gr1Y9a1U Xr4Y9ws5ta4jg3gCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUyCb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv67 AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_Cr1UM2AIxVAIcxkEcVAq 07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1lYx0E2Ix0cI8IcVAFwI0_JrI_Jr ylYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCj r7xvwVCIw2I0I7xG6c02F41l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr 1lx2IqxVAqx4xG67AKxVWUGVWUWwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE 14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7 IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E 87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0x ZFpf9x07UAWrXUUUUU= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YFvEV8qVTmnMVUmPlAWRm7N0x7686176AA= Content-Type: multipart/alternative; boundary="------------CM0FE3ITJof0i1Nxm4CcXTEn" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=NxjsERkg; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------CM0FE3ITJof0i1Nxm4CcXTEn Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Thanks, Chao On 2023/12/22 17:47, Ard Biesheuvel wrote: > On Fri, 22 Dec 2023 at 03:37, Ni, Ray wrote: >> Good to me. >> >> >> >> Thanks, >> >> Ray >> >> From: Chao Li >> Sent: Friday, December 22, 2023 9:15 AM >> To:devel@edk2.groups.io;ardb@kernel.org; Ni, Ray >> Cc: Kumar, Rahul R; Gerd Hoffmann; Leif Lindholm; Ard Biesheuvel; Sami Mujawar >> Subject: Re: [edk2-devel] [PATCH v4 19/37] UefiCpuPkg: Add MMIO method i= n CpuIo2Dxe >> >> >> >> >> >> >> >> Thanks, >> Chao >> >> On 2023/12/21 21:59, Ard Biesheuvel wrote: >> >> On Thu, 21 Dec 2023 at 13:41, Chao Li wrote: >> >> >> >> ... >> >> A given platform will either be able to use port IO, or it will need >> >> to use MMIO translation. So a driver that can do both based on a PCD >> >> is not very useful, it makes more sense to have two different drivers, >> >> and the platform incorporates the one it can use. >> >> >> >> Ok, I get it, I think you are more inclined to move the ArmCpuIo2Dxe to = a new place and rename it, maybe: CpuMmio2Dxe, while some platforms choose = the different CpuIo2 drvier by themselves when building FW, right? >> >> > > OK. > > Note that there are 15 references to > > ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf > > in edk2-platforms, so if you move the existing driver, please > > - create the new one by making a copy > - update all edk2 and edk2-platforms users to refer to the new version > - delete the old version Ok, I will do the last two steps as you said after this patch series is=20 merged. > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112844): https://edk2.groups.io/g/devel/message/112844 Mute This Topic: https://groups.io/mt/103261693/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------CM0FE3ITJof0i1Nxm4CcXTEn Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable



=
Thanks,
Chao
On 2023/12/22 17:47, Ard Biesheuvel wrote:
On Fri, 22 Dec 2023 at 03:37, =
Ni, Ray <ray.ni@intel.com> wrote:

Good to me.



Thanks,

Ray

From: Chao Li <lichao@loongson.cn>
Sent: Friday, December 22, 2023 9:15 AM
To: devel@edk2.groups.io; ardb@kernel.org; Ni, Ray <ray.ni@intel.com>
Cc: Kumar, Rahul R <rahul.r.kumar@intel.com>; Gerd Hoffmann <kraxel@=
redhat.com>; Leif Lindholm <quic_llindhol@quicinc.com>=
; Ard Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar <sam=
i.mujawar@arm.com>
Subject: Re: [edk2-devel] [PATCH v4 19/37] UefiCpuPkg: Add MMIO method in C=
puIo2Dxe







Thanks,
Chao

On 2023/12/21 21:59, Ard Biesheuvel wrote:

On Thu, 21 Dec 2023 at 13:41, Chao Li <lichao@loongson.cn> wrote:



...

A given platform will either be able to use port IO, or it will need

to use MMIO translation. So a driver that can do both based on a PCD

is not very useful, it makes more sense to have two different drivers,

and the platform incorporates the one it can use.



Ok, I get it, I think you are more inclined to move the ArmCpuIo2Dxe to a n=
ew place and rename it, maybe: CpuMmio2Dxe, while some platforms choose the=
 different CpuIo2 drvier by themselves when building FW, right?




OK.

Note that there are 15 references to

ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf

in edk2-platforms, so if you move the existing driver, please

- create the new one by making a copy
- update all edk2 and edk2-platforms users to refer to the new version
- delete the old version
Ok, I will do the last two steps as you said after this patch series is merged.
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#112844) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------CM0FE3ITJof0i1Nxm4CcXTEn--