[edk2-devel] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

[edk2-devel] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

[Rebecca Cran]

With the addition of VS2022 I'd like to propose removing VS2015, and 
discuss whether people think it might be suitable to also remove VS2017 
too, from tools_def.txt.

Back in July, Oliver sent the following message:

"Per Liming's request I am moving this discussion to the mailing list.
Now that VS2022 support has been added to edk2, can we drop VS2015
support (honestly VS2017 could be dropped, too). This is an almost
10 year old toolchain that is unsupported, has many quirks, and will
continue to require odd changes from new code to support it, for no
gain. VS2015 (and 2017) users should move to VS2022."


In addition, since GCC48, GCC49 and GCC5 have been marked deprecated for 
over a year, I'd like to proceed with removing them as well.


Please provide feedback by Thursday October 31st. In the absence of 
feedback I'll plan to proceed with removing VS2015, GCC48, GCC49 and GCC5.


-- 
Rebecca Cran



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120649): https://edk2.groups.io/g/devel/message/120649
Mute This Topic: https://groups.io/mt/109150018/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

[Leif Lindholm via groups.io]

On Tue, 22 Oct 2024 at 12:19, Rebecca Cran <rebecca@bsdio.com> wrote:
> In addition, since GCC48, GCC49 and GCC5 have been marked deprecated for
> over a year, I'd like to proceed with removing them as well.
>
> Please provide feedback by Thursday October 31st. In the absence of
> feedback I'll plan to proceed with removing VS2015, GCC48, GCC49 and GCC5.

No comment on the VS ones, but for the GCC ones, I'm all for it.

We might also want to raise an issue on deleting workarounds put into
place for ancient toolchains.
For gcc48/49 that was redundant initialization due to broken
use-uninitialized detection.
e.g. https://github.com/tianocore/edk2/blob/master/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c#L346

/
    Leif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120672): https://edk2.groups.io/g/devel/message/120672
Mute This Topic: https://groups.io/mt/109150018/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-discuss] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

[Sean]

[-- Attachment #1: Type: text/plain, Size: 2124 bytes --]

I support removal of vs2015 and 2017. Since ci only builds and tests n (vs2022). Supporting n-1 (vs2019) is already just on faith and with the idea that reported failures will be fixed.

I also agree with dropping previously deprecated tags.  Thanks for the effort.

Thanks
Sean
________________________________
From: discuss@edk2.groups.io <discuss@edk2.groups.io> on behalf of Rebecca Cran <rebecca@bsdio.com>
Sent: Tuesday, October 22, 2024 4:18:51 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; discuss@edk2.groups.io <discuss@edk2.groups.io>
Cc: Liming Gao <gaoliming@byosoft.com.cn>; Michael D Kinney <michael.d.kinney@intel.com>; Oliver Smith-Denny <osde@linux.microsoft.com>
Subject: [edk2-discuss] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

With the addition of VS2022 I'd like to propose removing VS2015, and
discuss whether people think it might be suitable to also remove VS2017
too, from tools_def.txt.

Back in July, Oliver sent the following message:

"Per Liming's request I am moving this discussion to the mailing list.
Now that VS2022 support has been added to edk2, can we drop VS2015
support (honestly VS2017 could be dropped, too). This is an almost
10 year old toolchain that is unsupported, has many quirks, and will
continue to require odd changes from new code to support it, for no
gain. VS2015 (and 2017) users should move to VS2022."


In addition, since GCC48, GCC49 and GCC5 have been marked deprecated for
over a year, I'd like to proceed with removing them as well.


Please provide feedback by Thursday October 31st. In the absence of
feedback I'll plan to proceed with removing VS2015, GCC48, GCC49 and GCC5.


--
Rebecca Cran








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120650): https://edk2.groups.io/g/devel/message/120650
Mute This Topic: https://groups.io/mt/109154422/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 3433 bytes --]

Re: [edk2-devel] [edk2-discuss] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

[Michael D Kinney]

Hi Rebecca,

Can you please clarify what you mean by removal?

Compiler tool chains have at least 3 levels of support
* EDK II CI uses the compiler for PRs and most merge checks
* The compiler tool chain tag is present in BaseTools/Conf/tools_def.template *and* is supported if an issue is reported
* The compiler tool chain tag is present in BaseTools/Conf/tools_def.template with last known working state but is not supported if an issue is reported

Thanks,

Mike

----------------

From: Sean Brogan <spbrogan@outlook.com> 
Sent: Tuesday, October 22, 2024 8:54 AM
To: discuss@edk2.groups.io; rebecca@bsdio.com; devel@edk2.groups.io
Cc: Liming Gao <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com>; Oliver Smith-Denny <osde@linux.microsoft.com>
Subject: Re: [edk2-discuss] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

I support removal of vs2015 and 2017. Since ci only builds and tests n (vs2022). Supporting n-1 (vs2019) is already just on faith and with the idea that reported failures will be fixed. 

I also agree with dropping previously deprecated tags.  Thanks for the effort. 

Thanks
Sean
________________________________________
From: mailto:discuss@edk2.groups.io <mailto:discuss@edk2.groups.io> on behalf of Rebecca Cran <mailto:rebecca@bsdio.com>
Sent: Tuesday, October 22, 2024 4:18:51 AM
To: mailto:devel@edk2.groups.io <mailto:devel@edk2.groups.io>; mailto:discuss@edk2.groups.io <mailto:discuss@edk2.groups.io>
Cc: Liming Gao <mailto:gaoliming@byosoft.com.cn>; Michael D Kinney <mailto:michael.d.kinney@intel.com>; Oliver Smith-Denny <mailto:osde@linux.microsoft.com>
Subject: [edk2-discuss] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5) 
 
With the addition of VS2022 I'd like to propose removing VS2015, and 
discuss whether people think it might be suitable to also remove VS2017 
too, from tools_def.txt.

Back in July, Oliver sent the following message:

"Per Liming's request I am moving this discussion to the mailing list.
Now that VS2022 support has been added to edk2, can we drop VS2015
support (honestly VS2017 could be dropped, too). This is an almost
10 year old toolchain that is unsupported, has many quirks, and will
continue to require odd changes from new code to support it, for no
gain. VS2015 (and 2017) users should move to VS2022."


In addition, since GCC48, GCC49 and GCC5 have been marked deprecated for 
over a year, I'd like to proceed with removing them as well.


Please provide feedback by Thursday October 31st. In the absence of 
feedback I'll plan to proceed with removing VS2015, GCC48, GCC49 and GCC5.


-- 
Rebecca Cran







-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120652): https://edk2.groups.io/g/devel/message/120652
Mute This Topic: https://groups.io/mt/109154422/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-discuss] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

[Rebecca Cran]

By "remove" I mean (d)


* The compiler tool chain tag is not present in 
BaseTools/Conf/tools_def.template and cannot be used to build code.


When trying to use VS2017 to run CI I actually ran into a linker crash. 
It said something about re-running the linking process using the 64-bit 
linker, but then the 64-bit linker crashed.


-- 

Rebecca


On 10/22/24 11:38 AM, Michael D Kinney wrote:
> Hi Rebecca,
>
> Can you please clarify what you mean by removal?
>
> Compiler tool chains have at least 3 levels of support
> * EDK II CI uses the compiler for PRs and most merge checks
> * The compiler tool chain tag is present in BaseTools/Conf/tools_def.template *and* is supported if an issue is reported
> * The compiler tool chain tag is present in BaseTools/Conf/tools_def.template with last known working state but is not supported if an issue is reported
>
> Thanks,
>
> Mike
>
> ----------------
>
> From: Sean Brogan <spbrogan@outlook.com>
> Sent: Tuesday, October 22, 2024 8:54 AM
> To: discuss@edk2.groups.io; rebecca@bsdio.com; devel@edk2.groups.io
> Cc: Liming Gao <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com>; Oliver Smith-Denny <osde@linux.microsoft.com>
> Subject: Re: [edk2-discuss] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)
>
> I support removal of vs2015 and 2017. Since ci only builds and tests n (vs2022). Supporting n-1 (vs2019) is already just on faith and with the idea that reported failures will be fixed.
>
> I also agree with dropping previously deprecated tags.  Thanks for the effort.
>
> Thanks
> Sean
> ________________________________________
> From: mailto:discuss@edk2.groups.io <mailto:discuss@edk2.groups.io> on behalf of Rebecca Cran <mailto:rebecca@bsdio.com>
> Sent: Tuesday, October 22, 2024 4:18:51 AM
> To: mailto:devel@edk2.groups.io <mailto:devel@edk2.groups.io>; mailto:discuss@edk2.groups.io <mailto:discuss@edk2.groups.io>
> Cc: Liming Gao <mailto:gaoliming@byosoft.com.cn>; Michael D Kinney <mailto:michael.d.kinney@intel.com>; Oliver Smith-Denny <mailto:osde@linux.microsoft.com>
> Subject: [edk2-discuss] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)
>   
> With the addition of VS2022 I'd like to propose removing VS2015, and
> discuss whether people think it might be suitable to also remove VS2017
> too, from tools_def.txt.
>
> Back in July, Oliver sent the following message:
>
> "Per Liming's request I am moving this discussion to the mailing list.
> Now that VS2022 support has been added to edk2, can we drop VS2015
> support (honestly VS2017 could be dropped, too). This is an almost
> 10 year old toolchain that is unsupported, has many quirks, and will
> continue to require odd changes from new code to support it, for no
> gain. VS2015 (and 2017) users should move to VS2022."
>
>
> In addition, since GCC48, GCC49 and GCC5 have been marked deprecated for
> over a year, I'd like to proceed with removing them as well.
>
>
> Please provide feedback by Thursday October 31st. In the absence of
> feedback I'll plan to proceed with removing VS2015, GCC48, GCC49 and GCC5.
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120656): https://edk2.groups.io/g/devel/message/120656
Mute This Topic: https://groups.io/mt/109154422/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

[Michael D Kinney]

Hi,

I will need more time to review this impacts of this proposal.

Can we extend the timeline for comments to mid November.

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif
> Lindholm via groups.io
> Sent: Tuesday, October 22, 2024 5:15 AM
> To: devel@edk2.groups.io; rebecca@bsdio.com
> Subject: Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and
> deprecated toolchains (GCC48, GCC49, GCC5)
> 
> On Tue, 22 Oct 2024 at 12:19, Rebecca Cran <rebecca@bsdio.com> wrote:
> > In addition, since GCC48, GCC49 and GCC5 have been marked deprecated
> for
> > over a year, I'd like to proceed with removing them as well.
> >
> > Please provide feedback by Thursday October 31st. In the absence of
> > feedback I'll plan to proceed with removing VS2015, GCC48, GCC49 and
> GCC5.
> 
> No comment on the VS ones, but for the GCC ones, I'm all for it.
> 
> We might also want to raise an issue on deleting workarounds put into
> place for ancient toolchains.
> For gcc48/49 that was redundant initialization due to broken
> use-uninitialized detection.
> e.g.
> https://github.com/tianocore/edk2/blob/master/OvmfPkg/Library/X86QemuLoa
> dImageLib/X86QemuLoadImageLib.c#L346
> 
> /
>     Leif
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120677): https://edk2.groups.io/g/devel/message/120677
Mute This Topic: https://groups.io/mt/109150018/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

[Rebecca Cran]

Sure, that’s not a problem.

On Wed, Oct 23, 2024, at 9:23 PM, Kinney, Michael D wrote:
> Hi,
>
> I will need more time to review this impacts of this proposal.
>
> Can we extend the timeline for comments to mid November.
>
> Thanks,
>
> Mike
>
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif
>> Lindholm via groups.io
>> Sent: Tuesday, October 22, 2024 5:15 AM
>> To: devel@edk2.groups.io; rebecca@bsdio.com
>> Subject: Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and
>> deprecated toolchains (GCC48, GCC49, GCC5)
>> 
>> On Tue, 22 Oct 2024 at 12:19, Rebecca Cran <rebecca@bsdio.com> wrote:
>> > In addition, since GCC48, GCC49 and GCC5 have been marked deprecated
>> for
>> > over a year, I'd like to proceed with removing them as well.
>> >
>> > Please provide feedback by Thursday October 31st. In the absence of
>> > feedback I'll plan to proceed with removing VS2015, GCC48, GCC49 and
>> GCC5.
>> 
>> No comment on the VS ones, but for the GCC ones, I'm all for it.
>> 
>> We might also want to raise an issue on deleting workarounds put into
>> place for ancient toolchains.
>> For gcc48/49 that was redundant initialization due to broken
>> use-uninitialized detection.
>> e.g.
>> https://github.com/tianocore/edk2/blob/master/OvmfPkg/Library/X86QemuLoa
>> dImageLib/X86QemuLoadImageLib.c#L346
>> 
>> /
>>     Leif
>> 
>> 
>> 
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120679): https://edk2.groups.io/g/devel/message/120679
Mute This Topic: https://groups.io/mt/109150018/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-