From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CF9D92117B57A for ; Thu, 25 Oct 2018 22:35:42 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2018 22:35:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,426,1534834800"; d="scan'208";a="84604077" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.11]) ([10.239.9.11]) by orsmga008.jf.intel.com with ESMTP; 25 Oct 2018 22:35:40 -0700 To: Star Zeng , edk2-devel@lists.01.org Cc: Hao Wu , Jian J Wang , Jiewen Yao References: <1540465113-103964-1-git-send-email-star.zeng@intel.com> <1540465113-103964-5-git-send-email-star.zeng@intel.com> From: "Ni, Ruiyu" Message-ID: <1f40a7d2-363d-71bc-4914-a929b8c5b3b0@Intel.com> Date: Fri, 26 Oct 2018 13:36:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1540465113-103964-5-git-send-email-star.zeng@intel.com> Subject: Re: [PATCH 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 05:35:43 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/25/2018 6:58 PM, Star Zeng wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 > > In current code, EhcMonitorAsyncRequests (timer handler) will do > unmap and map operations for AsyncIntTransfers to "Flush data from > PCI controller specific address to mapped system memory address". > EhcMonitorAsyncRequests > EhcFlushAsyncIntMap > PciIo->Unmap > IoMmu->SetAttribute > PciIo->Map > IoMmu->SetAttribute > > This may impact the boot performance. > > Since the data buffer for EhcMonitorAsyncRequests is internal > buffer, we can allocate common buffer by PciIo->AllocateBuffer > and map the buffer with EfiPciIoOperationBusMasterCommonBuffer, > then the unmap and map operations can be removed. > > /// > /// Provides both read and write access to system memory by > /// both the processor and a bus master. The buffer is coherent > /// from both the processor's and the bus master's point of view. > /// > EfiPciIoOperationBusMasterCommonBuffer, > > Test done: > USB KB works normally. > USB disk read/write works normally. > > Cc: Ruiyu Ni > Cc: Hao Wu > Cc: Jian J Wang > Cc: Jiewen Yao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c | 3 ++ > MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c | 77 +------------------------------- > MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.c | 38 ++++++++++++++-- > MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.h | 33 +++++++------- > 4 files changed, 57 insertions(+), 94 deletions(-) > > diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c b/MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c > index 5569f4f9618b..764eeda58ba1 100644 > --- a/MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c > +++ b/MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c > @@ -763,6 +763,7 @@ EhcControlTransfer ( > Translator, > EHC_CTRL_TRANSFER, > Request, > + FALSE, > Data, > *DataLength, > NULL, > @@ -906,6 +907,7 @@ EhcBulkTransfer ( > Translator, > EHC_BULK_TRANSFER, > NULL, > + FALSE, > Data[0], > *DataLength, > NULL, > @@ -1163,6 +1165,7 @@ EhcSyncInterruptTransfer ( > Translator, > EHC_INT_TRANSFER_SYNC, > NULL, > + FALSE, > Data, > *DataLength, > NULL, > diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c b/MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c > index d38340e49c8d..f1edcf20e342 100644 > --- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c > +++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c > @@ -778,7 +778,6 @@ EhciDelAsyncIntTransfer ( > EhcUnlinkQhFromPeriod (Ehc, Urb->Qh); > RemoveEntryList (&Urb->UrbList); > > - gBS->FreePool (Urb->Data); > EhcFreeUrb (Ehc, Urb); > return EFI_SUCCESS; > } > @@ -809,7 +808,6 @@ EhciDelAllAsyncIntTransfers ( > EhcUnlinkQhFromPeriod (Ehc, Urb->Qh); > RemoveEntryList (&Urb->UrbList); > > - gBS->FreePool (Urb->Data); > EhcFreeUrb (Ehc, Urb); > } > } > @@ -849,16 +847,8 @@ EhciInsertAsyncIntTransfer ( > IN UINTN Interval > ) > { > - VOID *Data; > URB *Urb; > > - Data = AllocatePool (DataLen); > - > - if (Data == NULL) { > - DEBUG ((DEBUG_ERROR, "%a: failed to allocate buffer\n", __FUNCTION__)); > - return NULL; > - } > - > Urb = EhcCreateUrb ( > Ehc, > DevAddr, > @@ -869,7 +859,8 @@ EhciInsertAsyncIntTransfer ( > Hub, > EHC_INT_TRANSFER_ASYNC, > NULL, > - Data, > + TRUE, > + NULL, > DataLen, > Callback, > Context, > @@ -892,60 +883,6 @@ EhciInsertAsyncIntTransfer ( > } > > /** > - Flush data from PCI controller specific address to mapped system > - memory address. > - > - @param Ehc The EHCI device. > - @param Urb The URB to unmap. > - > - @retval EFI_SUCCESS Success to flush data to mapped system memory. > - @retval EFI_DEVICE_ERROR Fail to flush data to mapped system memory. > - > -**/ > -EFI_STATUS > -EhcFlushAsyncIntMap ( > - IN USB2_HC_DEV *Ehc, > - IN URB *Urb > - ) > -{ > - EFI_STATUS Status; > - EFI_PHYSICAL_ADDRESS PhyAddr; > - EFI_PCI_IO_PROTOCOL_OPERATION MapOp; > - EFI_PCI_IO_PROTOCOL *PciIo; > - UINTN Len; > - VOID *Map; > - > - PciIo = Ehc->PciIo; > - Len = Urb->DataLen; > - > - if (Urb->Ep.Direction == EfiUsbDataIn) { > - MapOp = EfiPciIoOperationBusMasterWrite; > - } else { > - MapOp = EfiPciIoOperationBusMasterRead; > - } > - > - Status = PciIo->Unmap (PciIo, Urb->DataMap); > - if (EFI_ERROR (Status)) { > - goto ON_ERROR; > - } > - > - Urb->DataMap = NULL; > - > - Status = PciIo->Map (PciIo, MapOp, Urb->Data, &Len, &PhyAddr, &Map); > - if (EFI_ERROR (Status) || (Len != Urb->DataLen)) { > - goto ON_ERROR; > - } > - > - Urb->DataPhy = (VOID *) ((UINTN) PhyAddr); > - Urb->DataMap = Map; > - return EFI_SUCCESS; > - > -ON_ERROR: > - return EFI_DEVICE_ERROR; > -} > - > - > -/** > Update the queue head for next round of asynchronous transfer. > > @param Ehc The EHCI device. > @@ -1050,7 +987,6 @@ EhcMonitorAsyncRequests ( > BOOLEAN Finished; > UINT8 *ProcBuf; > URB *Urb; > - EFI_STATUS Status; > > OldTpl = gBS->RaiseTPL (EHC_TPL); > Ehc = (USB2_HC_DEV *) Context; > @@ -1069,15 +1005,6 @@ EhcMonitorAsyncRequests ( > } > > // > - // Flush any PCI posted write transactions from a PCI host > - // bridge to system memory. > - // > - Status = EhcFlushAsyncIntMap (Ehc, Urb); > - if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_ERROR, "EhcMonitorAsyncRequests: Fail to Flush AsyncInt Mapped Memeory\n")); > - } > - > - // > // Allocate a buffer then copy the transferred data for user. > // If failed to allocate the buffer, update the URB for next > // round of transfer. Ignore the data of this round. > diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.c b/MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.c > index 6afb327df165..09c12776ecdb 100644 > --- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.c > +++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.c > @@ -339,6 +339,14 @@ EhcFreeUrb ( > PciIo->Unmap (PciIo, Urb->DataMap); > } > > + if (Urb->AllocateCommonBuffer) { > + PciIo->FreeBuffer ( > + PciIo, > + EFI_SIZE_TO_PAGES (Urb->DataLen), > + Urb->Data > + ); > + } > + > if (Urb->Qh != NULL) { > // > // Ensure that this queue head has been unlinked from the > @@ -529,7 +537,8 @@ ON_ERROR: > @param Hub The transaction translator to use. > @param Type The transaction type. > @param Request The standard USB request for control transfer. > - @param Data The user data to transfer. > + @param AllocateCommonBuffer Indicate whether need to allocate common buffer for data transfer. > + @param Data The user data to transfer, NULL if AllocateCommonBuffer is TRUE. > @param DataLen The length of data buffer. > @param Callback The function to call when data is transferred. > @param Context The context to the callback. > @@ -549,6 +558,7 @@ EhcCreateUrb ( > IN EFI_USB2_HC_TRANSACTION_TRANSLATOR *Hub, > IN UINTN Type, > IN EFI_USB_DEVICE_REQUEST *Request, > + IN BOOLEAN AllocateCommonBuffer, > IN VOID *Data, > IN UINTN DataLen, > IN EFI_ASYNC_USB_TRANSFER_CALLBACK Callback, > @@ -596,8 +606,24 @@ EhcCreateUrb ( > Ep->PollRate = EhcConvertPollRate (Interval); > > Urb->Request = Request; > + if (AllocateCommonBuffer) { > + ASSERT (Data == NULL); > + Status = Ehc->PciIo->AllocateBuffer ( > + Ehc->PciIo, > + AllocateAnyPages, > + EfiBootServicesData, > + EFI_SIZE_TO_PAGES (DataLen), > + &Data, > + 0 > + ); > + if (EFI_ERROR (Status) || (Data == NULL)) { > + FreePool (Urb); > + return NULL; > + } > + } > Urb->Data = Data; > Urb->DataLen = DataLen; > + Urb->AllocateCommonBuffer = AllocateCommonBuffer; > Urb->Callback = Callback; > Urb->Context = Context; > > @@ -627,10 +653,14 @@ EhcCreateUrb ( > if (Data != NULL) { > Len = DataLen; > > - if (Ep->Direction == EfiUsbDataIn) { > - MapOp = EfiPciIoOperationBusMasterWrite; > + if (Urb->AllocateCommonBuffer) { > + MapOp = EfiPciIoOperationBusMasterCommonBuffer; > } else { > - MapOp = EfiPciIoOperationBusMasterRead; > + if (Ep->Direction == EfiUsbDataIn) { > + MapOp = EfiPciIoOperationBusMasterWrite; > + } else { > + MapOp = EfiPciIoOperationBusMasterRead; > + } > } > > Status = PciIo->Map (PciIo, MapOp, Data, &Len, &PhyAddr, &Map); > diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.h b/MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.h > index 02e9af81be39..cb3599f9d361 100644 > --- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.h > +++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.h > @@ -3,7 +3,7 @@ > This file contains URB request, each request is warpped in a > URB (Usb Request Block). > > -Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.
> +Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD License > which accompanies this distribution. The full text of the license may be found at > @@ -216,6 +216,7 @@ struct _URB { > EFI_USB_DEVICE_REQUEST *Request; // Control transfer only > VOID *RequestPhy; // Address of the mapped request > VOID *RequestMap; > + BOOLEAN AllocateCommonBuffer; > VOID *Data; > UINTN DataLen; > VOID *DataPhy; // Address of the mapped user data > @@ -298,20 +299,21 @@ EhcFreeUrb ( > /** > Create a new URB and its associated QTD. > > - @param Ehc The EHCI device. > - @param DevAddr The device address. > - @param EpAddr Endpoint addrress & its direction. > - @param DevSpeed The device speed. > - @param Toggle Initial data toggle to use. > - @param MaxPacket The max packet length of the endpoint. > - @param Hub The transaction translator to use. > - @param Type The transaction type. > - @param Request The standard USB request for control transfer. > - @param Data The user data to transfer. > - @param DataLen The length of data buffer. > - @param Callback The function to call when data is transferred. > - @param Context The context to the callback. > - @param Interval The interval for interrupt transfer. > + @param Ehc The EHCI device. > + @param DevAddr The device address. > + @param EpAddr Endpoint addrress & its direction. > + @param DevSpeed The device speed. > + @param Toggle Initial data toggle to use. > + @param MaxPacket The max packet length of the endpoint. > + @param Hub The transaction translator to use. > + @param Type The transaction type. > + @param Request The standard USB request for control transfer. > + @param AllocateCommonBuffer Indicate whether need to allocate common buffer for data transfer. > + @param Data The user data to transfer, NULL if AllocateCommonBuffer is TRUE. > + @param DataLen The length of data buffer. > + @param Callback The function to call when data is transferred. > + @param Context The context to the callback. > + @param Interval The interval for interrupt transfer. > > @return Created URB or NULL. > > @@ -327,6 +329,7 @@ EhcCreateUrb ( > IN EFI_USB2_HC_TRANSACTION_TRANSLATOR *Hub, > IN UINTN Type, > IN EFI_USB_DEVICE_REQUEST *Request, > + IN BOOLEAN AllocateCommonBuffer, > IN VOID *Data, > IN UINTN DataLen, > IN EFI_ASYNC_USB_TRANSFER_CALLBACK Callback, > Reviewed-by: Ruiyu Ni -- Thanks, Ray