From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, ray.ni@intel.com,
Gerd Hoffmann <kraxel@redhat.com>
Cc: "Kumar, Rahul R" <rahul.r.kumar@intel.com>,
Oliver Steffen <osteffen@redhat.com>
Subject: Re: [edk2-devel] [PATCH v3 5/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData()
Date: Mon, 26 Feb 2024 14:55:27 +0100 [thread overview]
Message-ID: <1f4c414b-68b3-d804-0ecd-58b1e321bdcf@redhat.com> (raw)
In-Reply-To: <MN6PR11MB82446DB231531D9CE2B257DB8C552@MN6PR11MB8244.namprd11.prod.outlook.com>
On 2/23/24 03:16, Ni, Ray wrote:
>
>
> Thanks,
> Ray
>> -----Original Message-----
>> From: Gerd Hoffmann <kraxel@redhat.com>
>> Sent: Friday, February 23, 2024 12:01 AM
>> To: devel@edk2.groups.io
>> Cc: Laszlo Ersek <lersek@redhat.com>; Ni, Ray <ray.ni@intel.com>; Kumar,
>> Rahul R <rahul.r.kumar@intel.com>; Oliver Steffen <osteffen@redhat.com>;
>> Gerd Hoffmann <kraxel@redhat.com>
>> Subject: [PATCH v3 5/6] UefiCpuPkg/MpInitLib: Add support for multiple
>> HOBs to SaveCpuMpData()
>>
>> Add support for splitting Hand-Off data into multiple HOBs.
>> This is required for VMs with thousands of CPUs.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> ---
>> UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 44 +++++++++++++++----------
>> 1 file changed, 27 insertions(+), 17 deletions(-)
>>
>> diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
>> b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
>> index f80e00edcff3..00d48c2ab531 100644
>> --- a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
>> +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
>> @@ -126,35 +126,45 @@ SaveCpuMpData (
>> IN CPU_MP_DATA *CpuMpData
>> )
>> {
>> + UINT32 MaxCpusPerHob, CpusInHob;
>> UINT64 Data64;
>> - UINTN Index;
>> + UINT32 Index, HobBase;
>
> Can you please split the local variable declarations in multiple lines?
> With that, Reviewed-by: Ray Ni <ray.ni@intel.com>
I'll edit the patch just before merging the series.
Laszlo
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115963): https://edk2.groups.io/g/devel/message/115963
Mute This Topic: https://groups.io/mt/104510911/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-02-26 13:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 16:01 [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs Gerd Hoffmann
2024-02-22 16:01 ` [edk2-devel] [PATCH v3 1/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetMpHandOffHob Gerd Hoffmann
2024-02-23 2:35 ` Ni, Ray
2024-02-26 13:42 ` Laszlo Ersek
2024-02-22 16:01 ` [edk2-devel] [PATCH v3 2/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetBspNumber() Gerd Hoffmann
2024-02-22 16:01 ` [edk2-devel] [PATCH v3 3/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SwitchApContext() Gerd Hoffmann
2024-02-22 16:01 ` [edk2-devel] [PATCH v3 4/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to MpInitLibInitialize Gerd Hoffmann
2024-02-26 13:51 ` Laszlo Ersek
2024-02-22 16:01 ` [edk2-devel] [PATCH v3 5/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData() Gerd Hoffmann
2024-02-23 2:16 ` Ni, Ray
2024-02-26 13:55 ` Laszlo Ersek [this message]
2024-02-26 13:55 ` Laszlo Ersek
2024-02-22 16:01 ` [edk2-devel] [PATCH v3 6/6] UefiCpuPkg/MpInitLib: return early in GetBspNumber() Gerd Hoffmann
2024-02-23 2:33 ` Ni, Ray
2024-02-26 13:59 ` Laszlo Ersek
2024-02-26 14:01 ` Laszlo Ersek
2024-02-26 15:08 ` [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs Laszlo Ersek
2024-02-26 15:41 ` Joey Vagedes via groups.io
2024-02-26 16:01 ` Laszlo Ersek
2024-02-26 16:02 ` Laszlo Ersek
2024-02-26 15:19 ` Laszlo Ersek
2024-02-26 22:17 ` Laszlo Ersek
2024-02-27 6:28 ` Ni, Ray
2024-02-27 12:11 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f4c414b-68b3-d804-0ecd-58b1e321bdcf@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox