From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7098FD81112 for ; Mon, 26 Feb 2024 13:55:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2eCzogpSJ3fxX4CCynvQwakOig5KNDj5aO14geyPFII=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708955733; v=1; b=DmculXZ97DBDC9gEjAEtWFxNQupJmZz9x5MpS+C2ceoqttCtx7R2CrPu+ml4BW0DE+PVYa4Y GbyN5YiSndOk1kYmM61jiivTlxIfPTRsEJUqAH2YC23akUT5aRKCEIBugnG1e4QUyuOcxyakMYM xKZIqI9QA5WNPgt4Yzqm4Iig= X-Received: by 127.0.0.2 with SMTP id A384YY7687511xRKPPTF2mPK; Mon, 26 Feb 2024 05:55:33 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.20721.1708955732457750701 for ; Mon, 26 Feb 2024 05:55:32 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-670-SOKIIC2NMH-dmvEoAu92_Q-1; Mon, 26 Feb 2024 08:55:30 -0500 X-MC-Unique: SOKIIC2NMH-dmvEoAu92_Q-1 X-Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0540A811E79; Mon, 26 Feb 2024 13:55:30 +0000 (UTC) X-Received: from [10.39.194.99] (unknown [10.39.194.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 72C40492BC6; Mon, 26 Feb 2024 13:55:28 +0000 (UTC) Message-ID: <1f4c414b-68b3-d804-0ecd-58b1e321bdcf@redhat.com> Date: Mon, 26 Feb 2024 14:55:27 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v3 5/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData() To: devel@edk2.groups.io, ray.ni@intel.com, Gerd Hoffmann Cc: "Kumar, Rahul R" , Oliver Steffen References: <20240222160106.686484-1-kraxel@redhat.com> <20240222160106.686484-6-kraxel@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: HNrccXBKzdhHKuVWJ433xbSLx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=DmculXZ9; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 2/23/24 03:16, Ni, Ray wrote: >=20 >=20 > Thanks, > Ray >> -----Original Message----- >> From: Gerd Hoffmann >> Sent: Friday, February 23, 2024 12:01 AM >> To: devel@edk2.groups.io >> Cc: Laszlo Ersek ; Ni, Ray ; Kumar, >> Rahul R ; Oliver Steffen ; >> Gerd Hoffmann >> Subject: [PATCH v3 5/6] UefiCpuPkg/MpInitLib: Add support for multiple >> HOBs to SaveCpuMpData() >> >> Add support for splitting Hand-Off data into multiple HOBs. >> This is required for VMs with thousands of CPUs. >> >> Signed-off-by: Gerd Hoffmann >> --- >> UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 44 +++++++++++++++---------- >> 1 file changed, 27 insertions(+), 17 deletions(-) >> >> diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c >> b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c >> index f80e00edcff3..00d48c2ab531 100644 >> --- a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c >> +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c >> @@ -126,35 +126,45 @@ SaveCpuMpData ( >> IN CPU_MP_DATA *CpuMpData >> ) >> { >> + UINT32 MaxCpusPerHob, CpusInHob; >> UINT64 Data64; >> - UINTN Index; >> + UINT32 Index, HobBase; >=20 > Can you please split the local variable declarations in multiple lines? > With that, Reviewed-by: Ray Ni I'll edit the patch just before merging the series. Laszlo >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115963): https://edk2.groups.io/g/devel/message/115963 Mute This Topic: https://groups.io/mt/104510911/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-