From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B5F9A7803ED for ; Fri, 29 Sep 2023 15:07:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=xEWwCpjmD6k1JyIEB78RX5JJNBvHW7rppmADg9GoOI4=; c=relaxed/simple; d=groups.io; h=Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696000045; v=1; b=tOJZU+kVYSCiv0r/PaV/uC32bz/MqScNVU9pply5ltfUbB9OHT65xHLnNZptQTcAkCKI2xjb 6G7GkMt56j7yvOC5db/4/n1UqyRnTcwP9Jdl1wXlnO7mbx0uoDYk9MIMX/vUjPDqgBcNdmsNQUE aKoi67cVQMgHOD1b4NzzBFBA= X-Received: by 127.0.0.2 with SMTP id oeKzYY7687511xnZ3hEGZPax; Fri, 29 Sep 2023 08:07:25 -0700 X-Received: from EUR01-HE1-obe.outbound.protection.outlook.com (EUR01-HE1-obe.outbound.protection.outlook.com [40.107.13.73]) by mx.groups.io with SMTP id smtpd.web10.20017.1696000044385829013 for ; Fri, 29 Sep 2023 08:07:24 -0700 X-Received: from DU2PR04CA0258.eurprd04.prod.outlook.com (2603:10a6:10:28e::23) by DBAPR08MB5718.eurprd08.prod.outlook.com (2603:10a6:10:1a9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Fri, 29 Sep 2023 15:07:17 +0000 X-Received: from DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28e:cafe::37) by DU2PR04CA0258.outlook.office365.com (2603:10a6:10:28e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.24 via Frontend Transport; Fri, 29 Sep 2023 15:07:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT008.mail.protection.outlook.com (100.127.142.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.15 via Frontend Transport; Fri, 29 Sep 2023 15:07:17 +0000 X-Received: ("Tessian outbound 6d14f3380669:v211"); Fri, 29 Sep 2023 15:07:17 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3e9893657c2127cf X-CR-MTA-TID: 64aa7808 X-Received: from 33281032da3a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5D8780B6-DAB4-4E40-8878-99E072F7423B.1; Fri, 29 Sep 2023 15:07:10 +0000 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 33281032da3a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 29 Sep 2023 15:07:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T0agZGHcuSkT17t76g9SJoy7a8RoubWQxwtB6OGqXCXwc+Ta+PGN6A+POAPzUCyDu1rrBqYWgpxHHMRN+oeDO7lWCab90U7w/m84cTzf5q4QM89lcDagpQfSmULfdUBDF54rBnkBRtidhbdFeAYQu5AZUFkIDQd1ZNTat9Nq0HJKFpBSNb0FIGGv+XRs6NjZwD7iVm2e6ZdvuIlsiBiISkm1KWWakhv/Jdj6fa+4WhZs9BN4UewZdv2/pzRKUMuP8e481UqF1YJIjTrhNl55y0uv/586MSD87RcvimAAe/k9kW2BRAGxqtpTYJJiaxN8Hgb/6gUXNJG1FwHcXNsq3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DIkQDJYF7aXJqeK9dAyi0fVgKmJY2gB7G1Ux0HHpcWY=; b=kopC2uzXiJCIu140jBr60p1Sj/0b2htvp7Ibf9f+pPO8QrU6jjp3yhU8OMpB7Qdco6S+bRt6Lf9UAHPhqs5ilVEshCnntTYGuywRRrBTqP1fvXUIoZkloESD+y1FNrMV4/EzVSSIlswq57ndJ8APgBsDa2jcLMJ0WPs62FuZ4V8WaBVVJ80OOyq/yDoij6MZUTkT4xEDB1/ktIhZ8AQeHoFu6m/27VrZii4sA7OpwQc6UHnKbyrr2kR3xhTuj9xULG9/HwUgKx6iRxxqHR42GkNiIPCwkqefIfFEIl8u+LOy3K/FmvWWhFDm6IBoggjlGPFU6HMENmw1eg0x6250gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by VI1PR08MB5310.eurprd08.prod.outlook.com (2603:10a6:803:135::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.26; Fri, 29 Sep 2023 15:07:08 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ac37:4594:ab86:59ce]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ac37:4594:ab86:59ce%4]) with mapi id 15.20.6838.024; Fri, 29 Sep 2023 15:07:08 +0000 Message-ID: <1f8b559b-71af-ceaf-f300-6c26d8fbb0d6@arm.com> Date: Fri, 29 Sep 2023 16:07:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH v2 3/5] MdePkg/BaseLib: use normal register init in ARM SetJump implementations To: Leif Lindholm , devel@edk2.groups.io Cc: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Ard Biesheuvel , "nd@arm.com" References: <20230926171523.368706-1-quic_llindhol@quicinc.com> <20230926171523.368706-4-quic_llindhol@quicinc.com> From: "Sami Mujawar" In-Reply-To: <20230926171523.368706-4-quic_llindhol@quicinc.com> X-ClientProxiedBy: LO4P265CA0304.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:391::12) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|VI1PR08MB5310:EE_|DBAEUR03FT008:EE_|DBAPR08MB5718:EE_ X-MS-Office365-Filtering-Correlation-Id: 34df2cd9-7263-4421-1f67-08dbc0fdc574 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cheJGfR0iVOwKYbd3TDKdDGOKPG8cBE5WHqekIKG88N4gdjjucnNfiOzwA/8m/0nn9QiAoCHAUanEwvrhZY97Mcs+zuH9yZD+/XcEf0G7wwPVz7WbiZJ/l5v8sQNFTgKXHBm9z8TCbiJXmTn56MOex/r3Kdz/Uc4invw+v5fbE4Ddf+iHdlGYFmtMIiMoSZVrQfHtJULfazJ3R3HS7gHOoTMtYTT1h3jgZQXFPiaVQ3ayEy9+kPdPGFR5vsrBey+WKoX+iDFINFkwNsTicBzVo4zTN5OYjnvzwHHCaRfkrMl2sEIWcN/0cdwzwLKShO82/3X4n5FJCp5RSP0/cMVeUn4CaaPdp8XDANmNDvj7T/nMtcTxdCwLgvhYQs5CwmSrySGUvQLzTQFi20T807y6d/u0p/WeanqL7FN7ya9jGNgTBIZ1BMjLPA0g+idONn7GSCPHmqlmFt1pv8iNtCfTL/ZadblBuSsnZr/GSEHipKCcMF/mVVIbx9Ce5rRG3fGWlNd/cb5lVbOXoZuVo7Rx4pmin7TAa031R09laTCUmrSJi22fkkE5U4At5U+nEWN8lMB3Pw4Kr/CkUmuq8l4vypGn3TbVEiBWvce9k2usYJnyENIbu6YR0izRvwEaQbm7zsjoXGq5nCQEAB3ZKMSaQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(39850400004)(366004)(376002)(346002)(396003)(230922051799003)(451199024)(186009)(64100799003)(1800799009)(6486002)(31686004)(6506007)(2616005)(53546011)(6512007)(38100700002)(31696002)(86362001)(36756003)(4326008)(2906002)(478600001)(83380400001)(8936002)(8676002)(26005)(41300700001)(54906003)(44832011)(66476007)(316002)(66556008)(5660300002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5310 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a836b6ba-90ce-4d18-7920-08dbc0fdc009 X-Microsoft-Antispam-Message-Info: vws9z40bbc14rVAwfclgWARfTA0BZMkKPhDSK74QZInUdfguhF53yQ4yX+5ixGzbn+xaxGPoDHsQWi0a7ifQ31z27ENtWbWgDauFayimR+5FOeyCY6v4w385XDez5j1JEYlT6x9vP+4w75fe95KiUQvCDmlV/pLas713g7vq65PuKg81SvBhqpRuMAyWSZV03CGyn1f+xgG9QOwoHM+/ckHvQkiDSyLZBxjHrcROg0rAqNgttnciJjxIuU/4L8HpEgh5BySWF2EceLLsgZbYvmsYUECvduTllrTaJT3LUTGHwBfbF/eu4lCA1iTiuqMccCeOaM6YLiQ6dUSHr7/M9ydBkD3qPGB6uwL61Zef8loUY9ifwZf0jOuOFJLqbyC+oQ7Mt3tRldY7NJNxC6ZDnvy4od23p+a5uBzrcjnAQGnex4UQBqL2bR5YFQ5e1oTqzEULGhORN8d9ZSzUu/tnvAlWztkAhMV+oVXwEKkFCrOnbApT4omUbRFFzNev/rKGCPwIcqhv5Rb3i9jmadaWNgexxvW1zgYj2Ij+QCAcqXTh1zb18gkUKbIdjV8l7x7+0r03iC9YDUnzaoVy3LW++E9B80l1I1jg+VOJKn4GGFuFRYYnxJeYAad4HuIU9jfi8Hg4T4f+ly/pX3U/71zLcesJAa4dTfYAeIhIBhpGTiKG0q86gZoi82ocH7eRVWK9KA5jDNAegc9tdJ9BrSVVS1a3P2zhkyzdWlDz48HmZJBotx5Xzz6aOwPK/+4Tp4zC5QaDFnLDXc4gt7QOlzLgmw== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 15:07:17.5037 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 34df2cd9-7263-4421-1f67-08dbc0fdc574 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5718 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: u1nH8SItKxRsXDINrQcUduoPx7686176AA= Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=tOJZU+kV; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Leif, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 26/09/2023 06:15 pm, Leif Lindholm wrote: > There may be architectures on which there are benefits to > eor r0, r0(, r0) > but ARM was never one of them. Change to more readable > mov r0, #0 > instead. > > Signed-off-by: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > --- > MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S | 2 +- > MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S b/MdePkg/Librar= y/BaseLib/Arm/SetJumpLongJump.S > index e4c1946a28ff..e91320252255 100644 > --- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S > +++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S > @@ -33,7 +33,7 @@ GCC_ASM_EXPORT(InternalLongJump) > ASM_PFX(SetJump): > mov r3, r13 > stmia r0, {r3-r12,r14} > - eor r0, r0, r0 > + mov r0, #0 > bx lr > =20 > #/** > diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm b/MdePkg/Libr= ary/BaseLib/Arm/SetJumpLongJump.asm > index e1eff758f7ab..ef02d85e0e66 100644 > --- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm > +++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm > @@ -33,7 +33,7 @@ > SetJump > MOV R3, R13 > STM R0, {R3-R12,R14} > - EOR R0, R0 > + MOV RO, #0 > BX LR > =20 > ;/** -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109202): https://edk2.groups.io/g/devel/message/109202 Mute This Topic: https://groups.io/mt/101600809/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-