From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.70]) by mx.groups.io with SMTP id smtpd.web11.7638.1628600781179364680 for ; Tue, 10 Aug 2021 06:06:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=cGEJjKEY; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.220.70, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VhTqZgdOMihK8lnglRTgUSCnka2hqcj20tKsahgES9e77M3tu6fmVInvaYWdi8RoeKon4EkTVyNKRoEmo379/cnOj8SDU5PCuPzalR06G1jBH3wPff5RowPMfHkbEU9o9xASU6iNr425+7J0P3puUF1/heWHu75AqonCfVBq8xulWmybgXu40mzMRGGt/EicI6WVA6q+czkjOf6Us9h/R6FBo6pv0hNQ179b9c/q2zDN89AGxDE/9XUFR7XrxkqERri0tdZkXY2V5T2UGvflDwrniOp/GuTpLwJtlFiMqe5FdEc+4Jr7V5Hxnje1g8Gn/xMQ+dhg8tJ+vpxyx/vQxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MeCcfrlzV87KKut6ROr7Fq5QeM7I1sezActoqccehOU=; b=I9UwDqxwFG/OIAYX9zLiSm/TnW6wSBNg5PQDjmKyrkOffz+ioa4Ej71faFiuHrYbfKIBmK+Q6z6KK+P9299nPGsF/SPvXYOhlv7Izku7f6vq8C6Jb6hINqOOAtDMSuCnsXxuqOLl7ihhNjw2yRvKD5Ln3qx/Mw3z9h4dNP+7PPdFnQGpoKq3+vcjHivIRAT5Vol7irCDyhrOKqh/4Wr//0WZIpfXn8x4V4oUso+LQXgFTmq7r447IOkvvFo5RW+3pWyR5HaV5xCYZC2onGLPY/6Hn7oJtYL0hkOoxxRUP5Gjik1cwlelOKFBcA/wL6Hm3FkDKcfw2Jd+MhAEDTRT3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MeCcfrlzV87KKut6ROr7Fq5QeM7I1sezActoqccehOU=; b=cGEJjKEYkwBfea5Hg1YaaReqhjCExYSQ575Md8sWFsSRE5v28UaOKXCypuvvhKpTMoVBX6rD8J4dUBkpltXgPh/nBJpkqprWT8CyvWH/KH6WwXBnymnZSLAenj1Yig3TtLNgLuZ/0prVUgHP4pjJo1EKzMmg5+adNYVLToju0sk= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by DM4PR12MB5325.namprd12.prod.outlook.com (2603:10b6:5:39e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14; Tue, 10 Aug 2021 13:06:19 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::73:2581:970b:3208]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::73:2581:970b:3208%3]) with mapi id 15.20.4394.023; Tue, 10 Aug 2021 13:06:19 +0000 Subject: Re: [PATCH v6 6/6] OvmfPkg/AmdSevDxe: Add support for SEV live migration. To: Ashish Kalra Cc: devel@edk2.groups.io, dovmurik@linux.vnet.ibm.com, brijesh.singh@amd.com, tobin@ibm.com, jejb@linux.ibm.com, jordan.l.justen@intel.com, ard.biesheuvel@arm.com, erdemaktas@google.com, jiewen.yao@intel.com, min.m.xu@intel.com References: <4f2224f2-de60-03a6-333e-163f31fe1c1a@amd.com> <20210810111349.GA9132@ashkalra_ubuntu_server> From: "Lendacky, Thomas" Message-ID: <1f8b8f5e-ee66-6f99-5048-0ed763cc36ec@amd.com> Date: Tue, 10 Aug 2021 08:06:17 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210810111349.GA9132@ashkalra_ubuntu_server> X-ClientProxiedBy: SA0PR13CA0021.namprd13.prod.outlook.com (2603:10b6:806:130::26) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.236.30.241] (165.204.77.1) by SA0PR13CA0021.namprd13.prod.outlook.com (2603:10b6:806:130::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.6 via Frontend Transport; Tue, 10 Aug 2021 13:06:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ce6b0e70-c598-4e44-5e20-08d95bffa4f8 X-MS-TrafficTypeDiagnostic: DM4PR12MB5325: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7QFseWwHGOt1b2WSRQZMqzSuuMkqhlJzTrMxUgjAMmF5CrGil67XaZxP+iHZOmkJnPJkQmwnXR1I8jOj6WZukZivMK71FnxOqNL40rMLiFeDvRDQbNEA3JSyKT/8EM+/ldLsIKamH4IEWjlKZL9XYIXt1bKvq9InbQ2vY9VYqkgoNkSOdzQi6cXfmyGSjDdT5gIdOtqRBzQrcVH4P886UVpJDL3AcVZkMUGrBX9ohIG1EJ1EPHAIr2sNEAMazX+/zTnkDyfARXaWQUxBzUh1Qa+SzoCEg85dPB3crzrkDCxfrXvkKPMWzxTxWhOlYzZa4ElaUH64ETdHJKJhlua6gC55DYb0E4SQ9qvyCyizjhePyvSS2dCMqUNgcSWRliTT8GlCklf6x9yyEpJsYPE58GD/fm9p19GIl7Bj6I+/R2uN2/9gcwGyq2eElTAw48A0sRrjt19krEsNDJla3RF/XytDLe+OHEHZuukTkJzb+dz8T7yGeztIetpKcaNVX0hGc/GBVPMJMbCEN3JoFJJazzo5W3L8doW3ntWOsYZlmquQiGkhCE/+dsGEk81YMWhoKUvMw43uS8CR6tic/WURBEhb2m3s8rGqb57DB6BdjbBqpPbGMJED19iNZWDu4OVQLXp6cRHUBlYQCseSuYoCj3D0Oet6+WTDTLV1DbjRmF5MGnoy2AnOiSeF5CyCCReBv3iLDakxBVyrAtgQJWZuVESg7wAONWdSwsXYYoHR3io= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(346002)(39860400002)(376002)(396003)(66946007)(66556008)(66476007)(186003)(31686004)(956004)(26005)(2906002)(83380400001)(31696002)(36756003)(86362001)(38100700002)(2616005)(16576012)(316002)(478600001)(4744005)(5660300002)(6486002)(8676002)(6636002)(8936002)(4326008)(6862004)(37006003)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDAyM1Z3c0tzVUZDeUVpdDllV0VtOEZNSHY5S1lRdW1DTUFkcGpWWGM2UThi?= =?utf-8?B?aXhGaWx6N1hxN0ljL0daU1o2TUZHYWJVWWlrdE1lTWM1dE05YjZWMjhFejBL?= =?utf-8?B?dlVReFZlbGJyUzIrdXo3NU92MVdsOHJzaFhac2hkSzBRWHczTTNHNEZzUHBD?= =?utf-8?B?L3BGcFdzdUtIY1JYUHdwcVpzdVVjZ1dHN1N1ZlgrSEpTR3c5K0JMQlB3NE56?= =?utf-8?B?TkpYNkNiNW5KN0ovK2pCZXZNVGtjRnFnbDNTZjBkUFhsUzMxcWFFamxHb1R6?= =?utf-8?B?RWg3ekF3ZWhSV0Q5OWk3K1RPZ3ZHeUtEa2FTN1ZrY2VkQkZjNDBidGY2TEJs?= =?utf-8?B?WHh5UW14RmplS3VEbHcwOGU0N2E2WmNEUGJPQlFNYnhzVXNKVjhHVldDRSs4?= =?utf-8?B?a0toNkFxbzBuMGdPeEg4aEtpU3dCeXlBeGZxbjFZUk1EUXRxV3lCT0svVk4z?= =?utf-8?B?dk9xd09majJyZEs4YUpObWlsd3hpUGljVjhlQ2NFSmg4ZzA3cUNzYkpMd09D?= =?utf-8?B?YUxScW9lcG54eFgrT0JNZjhBOFUzUjBIdmQzbWR6cHU2c2NGR0VMTGtVMGxY?= =?utf-8?B?eEdaeGRTdnFDS3owbEVnaUt4RUtxR3JVdk5FdjBkLzZKN1RNT1U2Z05pODli?= =?utf-8?B?MGFValQvRWZlTGtCbGZjZGRpNm9vbW1GMXNaM0NrNS9HWHpuemVkOFFKVGpz?= =?utf-8?B?N21pZ2xBQkMzS3g1TGV6STZCUDk5NVFIYm9mTlB3STlhYTBJMU0vMG5rRFl0?= =?utf-8?B?d0tMK2JtcFQ3Nk4zT2VEc3lFVU9RTWxmQUNYMmJuVytUT3JaMjJBd0o5RVlL?= =?utf-8?B?Z3d2Wk4yMDlxekVPcXdpVjBjVng2cUN4TDRXSEtEVHR1dVdXcTArOFhhSCtG?= =?utf-8?B?MVorWHoybjFjQjhXZ2tRbFBldmRwY2VIOVVCMGtkWGkyTGt0Nnp3ZWxFd1la?= =?utf-8?B?NXpsY2FNNVl1cFA3MnlTZ1g1ck9XSnRQak03RHQ5Zkg0dmJPbld4RUJ5bDI4?= =?utf-8?B?Zi9ocE9oUHdpUUJrcEpVL0x2eTNYRldFNTZjQVRzRlpySk9kWFpnbDR5SktK?= =?utf-8?B?VzlXNXhkVnl5Y3d2Z09HOCtqamJGSk9Ka2p1cVZodS8xdGVYOHZ2b0MyRjRl?= =?utf-8?B?ekNhZHN1WDIvM2NJM0psK0dCSWlONVB2TC9CRDlwTzdRMEVzd1JJYzlBZ1Ax?= =?utf-8?B?UU5hajIxdnM1YVVrekxGa3U1S3g2bGkzZktNZktESUFuUlA3TjA1UFBSUzN3?= =?utf-8?B?c3R1SVM5QnRUZjBKalJkek44U1VGcnc2cFRic1hYeVZzWFI4aFpWakEvSXhi?= =?utf-8?B?cDBVNlhIczM2cDdKZHFEaVc2NjdlREtjRFJUVGh3UFBDWEMzeWJ3NVk5MnR6?= =?utf-8?B?Yndvb0ZnTEVhbzV1TjZHYzQ3SU90cmFCdks2MVdSU1Q2YTJ6SXNFK1QrWjB6?= =?utf-8?B?b2VWdHp4SzMzVllKS0VaUlkxK1FQZ1h5L0FBZXJEZG1iUUNPWTgwUllHMVhw?= =?utf-8?B?RmFyQU5hd0xQWlY2VWN2alo2eW5FbWFjdDhRU0RIdCtxc01hMHJoS1l5V0RC?= =?utf-8?B?R1BsdDFnQjZXUC9EY0pTYS8rZVBPQVRXeERwaDRFUFZTTUl2UzU1U1RVVjg1?= =?utf-8?B?RjBvTmNGV2dFN2dadWZScUxVcXhhS3FtVzhMWmZYSGZ1dGswTmJLUDM5Uk9Q?= =?utf-8?B?UU9pMUF2bFF4Qzd6bzlqNjN5WU1QNXBKV3lCdUxIcmhzdmxtNGN3WmN3TUtV?= =?utf-8?Q?jdr6JnSpdEVhC5yD4L+DoSdtxTAKiOVgA2He7/u?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce6b0e70-c598-4e44-5e20-08d95bffa4f8 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2021 13:06:19.3518 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ptuzOSRfmJXnkETPx2ip5KSpy64Yj7/qiLyS7IfG1n23M/Gg2kU16wCGH3PVeaVOQfNoLtTvtg+13OO/OhCagQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5325 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 8/10/21 6:13 AM, Ashish Kalra wrote: > Hello Tom, > > On Mon, Aug 09, 2021 at 09:29:29AM -0500, Tom Lendacky wrote: >> On 8/2/21 7:33 AM, Ashish Kalra wrote: >> >> Should there be an "ASSERT_EFI_ERROR (Status)" after the DEBUG call? >> > > I don't think we should do an assert here and abort booting, failure > here will simply disable live migration support but i don't think that > it is such a fatal error that we should abort booting because of that. > > OTOH, if there is a failure when doing page encryption status hypercalls > then aborting boot makes sense as guest page encryption status tracking > may be critical for multiple guest operations and not only live > migration. Makes sense. Thanks, Tom > > Thanks, > Ashish >