* [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL
@ 2021-06-11 8:35 Sunny Wang
2021-06-11 9:15 ` Heinrich Schuchardt
0 siblings, 1 reply; 6+ messages in thread
From: Sunny Wang @ 2021-06-11 8:35 UTC (permalink / raw)
To: devel
Cc: Sunny Wang, Samer El-Haj-Mahmoud, G Edhaya Chandran, Barton Gao,
Heinrich Schuchardt, Michael D Kinney, Sunny Wang
The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent failures.
Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
exclusive use by the firmware. The creation of events by UEFI
applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
level.
Therefore, revert TPL_HIGH_LEVEL change in commits a9d1fb58 and
ae7e5477b555 to not create event with TPL_HIGH_LEVEL to be compliant
with UEFI Spec and fix the failures.
For more information, https://edk2.groups.io/g/devel/message/76338
Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
Cc: G Edhaya Chandran <edhaya.chandran@arm.com>
Cc: Barton Gao <gaojie@byosoft.com.cn>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Sunny Wang <sunny.wang@arm.com>
---
.../EventTimerTaskPriorityServicesBBTestCreateEvent.c | 5 +----
.../EventTimerTaskPriorityServicesBBTestCreateEventEx.c | 4 +---
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
index a7e7366e..d5c033f7 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
@@ -2,6 +2,7 @@
Copyright 2006 - 2012 Unified EFI, Inc.<BR>
Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2021, ARM Limited. All rights reserved.
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
@@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
- TPL_HIGH_LEVEL,
0
};
EFI_TEST_ASSERTION AssertionType;
@@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
- TPL_HIGH_LEVEL,
0
};
EFI_TEST_ASSERTION AssertionType;
@@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
- TPL_HIGH_LEVEL,
0
};
EFI_TEST_ASSERTION AssertionType;
@@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
- TPL_HIGH_LEVEL,
0
};
EFI_TEST_ASSERTION AssertionType;
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
index eb458de5..03b7ae6e 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
@@ -2,6 +2,7 @@
Copyright 2006 - 2016 Unified EFI, Inc.<BR>
Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2021, ARM Limited. All rights reserved.
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
@@ -228,7 +229,6 @@ BBTestCreateEventEx_Conf_Sub1 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
- TPL_HIGH_LEVEL,
0
};
EFI_GUID *EventGroups[] = {
@@ -318,7 +318,6 @@ BBTestCreateEventEx_Conf_Sub2 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
- TPL_HIGH_LEVEL,
0
};
EFI_GUID *EventGroups[] = {
@@ -413,7 +412,6 @@ BBTestCreateEventEx_Conf_Sub3 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
- TPL_HIGH_LEVEL,
0
};
EFI_GUID *EventGroups[] = {
--
2.31.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL
2021-06-11 8:35 [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL Sunny Wang
@ 2021-06-11 9:15 ` Heinrich Schuchardt
2021-06-14 0:36 ` Samer El-Haj-Mahmoud
0 siblings, 1 reply; 6+ messages in thread
From: Heinrich Schuchardt @ 2021-06-11 9:15 UTC (permalink / raw)
To: Sunny Wang, devel
Cc: Samer El-Haj-Mahmoud, G Edhaya Chandran, Barton Gao,
Michael D Kinney
On 11.06.21 10:35, Sunny Wang wrote:
> The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent failures.
>
> Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
> exclusive use by the firmware. The creation of events by UEFI
> applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
> level.
>
> Therefore, revert TPL_HIGH_LEVEL change in commits a9d1fb58 and
> ae7e5477b555 to not create event with TPL_HIGH_LEVEL to be compliant
> with UEFI Spec and fix the failures.
>
> For more information, https://edk2.groups.io/g/devel/message/76338
>
> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> Cc: G Edhaya Chandran <edhaya.chandran@arm.com>
> Cc: Barton Gao <gaojie@byosoft.com.cn>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Sunny Wang <sunny.wang@arm.com>
Acked-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> .../EventTimerTaskPriorityServicesBBTestCreateEvent.c | 5 +----
> .../EventTimerTaskPriorityServicesBBTestCreateEventEx.c | 4 +---
> 2 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> index a7e7366e..d5c033f7 100644
> --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> @@ -2,6 +2,7 @@
>
> Copyright 2006 - 2012 Unified EFI, Inc.<BR>
> Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2021, ARM Limited. All rights reserved.
>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD License
> @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> - TPL_HIGH_LEVEL,
> 0
> };
> EFI_TEST_ASSERTION AssertionType;
> @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> - TPL_HIGH_LEVEL,
> 0
> };
> EFI_TEST_ASSERTION AssertionType;
> @@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> - TPL_HIGH_LEVEL,
> 0
> };
> EFI_TEST_ASSERTION AssertionType;
> @@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> - TPL_HIGH_LEVEL,
> 0
> };
> EFI_TEST_ASSERTION AssertionType;
> diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> index eb458de5..03b7ae6e 100644
> --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> @@ -2,6 +2,7 @@
>
> Copyright 2006 - 2016 Unified EFI, Inc.<BR>
> Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2021, ARM Limited. All rights reserved.
>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD License
> @@ -228,7 +229,6 @@ BBTestCreateEventEx_Conf_Sub1 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> - TPL_HIGH_LEVEL,
> 0
> };
> EFI_GUID *EventGroups[] = {
> @@ -318,7 +318,6 @@ BBTestCreateEventEx_Conf_Sub2 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> - TPL_HIGH_LEVEL,
> 0
> };
> EFI_GUID *EventGroups[] = {
> @@ -413,7 +412,6 @@ BBTestCreateEventEx_Conf_Sub3 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> - TPL_HIGH_LEVEL,
> 0
> };
> EFI_GUID *EventGroups[] = {
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL
2021-06-11 9:15 ` Heinrich Schuchardt
@ 2021-06-14 0:36 ` Samer El-Haj-Mahmoud
2021-06-14 9:53 ` Sunny Wang
0 siblings, 1 reply; 6+ messages in thread
From: Samer El-Haj-Mahmoud @ 2021-06-14 0:36 UTC (permalink / raw)
To: Heinrich Schuchardt, Sunny Wang, devel@edk2.groups.io
Cc: G Edhaya Chandran, Barton Gao, Michael D Kinney,
Samer El-Haj-Mahmoud
Reviewed-By: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Sent: Friday, June 11, 2021 5:15 AM
> To: Sunny Wang <Sunny.Wang@arm.com>; devel@edk2.groups.io
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; G Edhaya
> Chandran <Edhaya.Chandran@arm.com>; Barton Gao
> <gaojie@byosoft.com.cn>; Michael D Kinney <michael.d.kinney@intel.com>
> Subject: Re: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event
> with TPL_HIGH_LEVEL
>
> On 11.06.21 10:35, Sunny Wang wrote:
> > The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent
> failures.
> >
> > Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
> > exclusive use by the firmware. The creation of events by UEFI
> > applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
> > level.
> >
> > Therefore, revert TPL_HIGH_LEVEL change in commits a9d1fb58 and
> > ae7e5477b555 to not create event with TPL_HIGH_LEVEL to be compliant
> > with UEFI Spec and fix the failures.
> >
> > For more information, https://edk2.groups.io/g/devel/message/76338
> >
> > Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> > Cc: G Edhaya Chandran <edhaya.chandran@arm.com>
> > Cc: Barton Gao <gaojie@byosoft.com.cn>
> > Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Signed-off-by: Sunny Wang <sunny.wang@arm.com>
>
> Acked-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
> > ---
> > .../EventTimerTaskPriorityServicesBBTestCreateEvent.c | 5 +----
> > .../EventTimerTaskPriorityServicesBBTestCreateEventEx.c | 4 +---
> > 2 files changed, 2 insertions(+), 7 deletions(-)
> >
> > diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > index a7e7366e..d5c033f7 100644
> > --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > @@ -2,6 +2,7 @@
> >
> > Copyright 2006 - 2012 Unified EFI, Inc.<BR>
> > Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>
> > + Copyright (c) 2021, ARM Limited. All rights reserved.
> >
> > This program and the accompanying materials
> > are licensed and made available under the terms and conditions of the
> BSD License
> > @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_TEST_ASSERTION AssertionType;
> > @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_TEST_ASSERTION AssertionType;
> > @@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_TEST_ASSERTION AssertionType;
> > @@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_TEST_ASSERTION AssertionType;
> > diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> > index eb458de5..03b7ae6e 100644
> > --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> > +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> > @@ -2,6 +2,7 @@
> >
> > Copyright 2006 - 2016 Unified EFI, Inc.<BR>
> > Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
> > + Copyright (c) 2021, ARM Limited. All rights reserved.
> >
> > This program and the accompanying materials
> > are licensed and made available under the terms and conditions of the
> BSD License
> > @@ -228,7 +229,6 @@ BBTestCreateEventEx_Conf_Sub1 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_GUID *EventGroups[] = {
> > @@ -318,7 +318,6 @@ BBTestCreateEventEx_Conf_Sub2 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_GUID *EventGroups[] = {
> > @@ -413,7 +412,6 @@ BBTestCreateEventEx_Conf_Sub3 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_GUID *EventGroups[] = {
> >
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL
2021-06-14 0:36 ` Samer El-Haj-Mahmoud
@ 2021-06-14 9:53 ` Sunny Wang
2021-06-16 1:15 ` 回复: [edk2-devel] " Gao Jie
0 siblings, 1 reply; 6+ messages in thread
From: Sunny Wang @ 2021-06-14 9:53 UTC (permalink / raw)
To: Samer El-Haj-Mahmoud, Heinrich Schuchardt, devel@edk2.groups.io
Cc: G Edhaya Chandran, Barton Gao, Michael D Kinney, Sunny Wang
Thanks for the review, Samer.
Moreover, I just built it and tested it on my ARM system, and confirmed the issue got fixed by this patch.
Without this fix, the result would be 18 tests, and 4 Errors.
CreateEvent_Func: [FAILED]
Passes........... 14
Warnings......... 0
Errors........... 4
Without this fix, the result would be 13 tests, and 0 Errors.
CreateEvent_Func: [PASSED]
Passes........... 13
Warnings......... 0
Errors........... 0
Best Regards,
Sunny Wang
-----Original Message-----
From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Sent: Monday, June 14, 2021 8:36 AM
To: Heinrich Schuchardt <xypron.glpk@gmx.de>; Sunny Wang <Sunny.Wang@arm.com>; devel@edk2.groups.io
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Michael D Kinney <michael.d.kinney@intel.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: RE: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL
Reviewed-By: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Sent: Friday, June 11, 2021 5:15 AM
> To: Sunny Wang <Sunny.Wang@arm.com>; devel@edk2.groups.io
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; G Edhaya
> Chandran <Edhaya.Chandran@arm.com>; Barton Gao
> <gaojie@byosoft.com.cn>; Michael D Kinney <michael.d.kinney@intel.com>
> Subject: Re: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event
> with TPL_HIGH_LEVEL
>
> On 11.06.21 10:35, Sunny Wang wrote:
> > The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent
> failures.
> >
> > Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
> > exclusive use by the firmware. The creation of events by UEFI
> > applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
> > level.
> >
> > Therefore, revert TPL_HIGH_LEVEL change in commits a9d1fb58 and
> > ae7e5477b555 to not create event with TPL_HIGH_LEVEL to be compliant
> > with UEFI Spec and fix the failures.
> >
> > For more information, https://edk2.groups.io/g/devel/message/76338
> >
> > Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> > Cc: G Edhaya Chandran <edhaya.chandran@arm.com>
> > Cc: Barton Gao <gaojie@byosoft.com.cn>
> > Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Signed-off-by: Sunny Wang <sunny.wang@arm.com>
>
> Acked-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
> > ---
> > .../EventTimerTaskPriorityServicesBBTestCreateEvent.c | 5 +----
> > .../EventTimerTaskPriorityServicesBBTestCreateEventEx.c | 4 +---
> > 2 files changed, 2 insertions(+), 7 deletions(-)
> >
> > diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > index a7e7366e..d5c033f7 100644
> > --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > @@ -2,6 +2,7 @@
> >
> > Copyright 2006 - 2012 Unified EFI, Inc.<BR>
> > Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>
> > + Copyright (c) 2021, ARM Limited. All rights reserved.
> >
> > This program and the accompanying materials
> > are licensed and made available under the terms and conditions of the
> BSD License
> > @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_TEST_ASSERTION AssertionType;
> > @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_TEST_ASSERTION AssertionType;
> > @@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_TEST_ASSERTION AssertionType;
> > @@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_TEST_ASSERTION AssertionType;
> > diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> > index eb458de5..03b7ae6e 100644
> > --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> > +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> > @@ -2,6 +2,7 @@
> >
> > Copyright 2006 - 2016 Unified EFI, Inc.<BR>
> > Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
> > + Copyright (c) 2021, ARM Limited. All rights reserved.
> >
> > This program and the accompanying materials
> > are licensed and made available under the terms and conditions of the
> BSD License
> > @@ -228,7 +229,6 @@ BBTestCreateEventEx_Conf_Sub1 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_GUID *EventGroups[] = {
> > @@ -318,7 +318,6 @@ BBTestCreateEventEx_Conf_Sub2 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_GUID *EventGroups[] = {
> > @@ -413,7 +412,6 @@ BBTestCreateEventEx_Conf_Sub3 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_GUID *EventGroups[] = {
> >
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* 回复: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL
2021-06-14 9:53 ` Sunny Wang
@ 2021-06-16 1:15 ` Gao Jie
2021-06-16 2:25 ` Sunny Wang
0 siblings, 1 reply; 6+ messages in thread
From: Gao Jie @ 2021-06-16 1:15 UTC (permalink / raw)
To: devel, Sunny.Wang, 'Samer El-Haj-Mahmoud',
'Heinrich Schuchardt'
Cc: 'G Edhaya Chandran', 'Michael D Kinney'
Hi Sunny,
I believe the result with 13 passes should be tested *with* this fix, right?
I saw reviewed-by/Acked-by from Samer and Heinrich, will get this patch upstreamed soon.
Thanks
Barton
-----邮件原件-----
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sunny Wang
发送时间: 2021年6月14日 17:53
收件人: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>; devel@edk2.groups.io
抄送: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Michael D Kinney <michael.d.kinney@intel.com>; Sunny Wang <Sunny.Wang@arm.com>
主题: Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL
Thanks for the review, Samer.
Moreover, I just built it and tested it on my ARM system, and confirmed the issue got fixed by this patch.
Without this fix, the result would be 18 tests, and 4 Errors.
CreateEvent_Func: [FAILED]
Passes........... 14
Warnings......... 0
Errors........... 4
Without this fix, the result would be 13 tests, and 0 Errors.
CreateEvent_Func: [PASSED]
Passes........... 13
Warnings......... 0
Errors........... 0
Best Regards,
Sunny Wang
-----Original Message-----
From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Sent: Monday, June 14, 2021 8:36 AM
To: Heinrich Schuchardt <xypron.glpk@gmx.de>; Sunny Wang <Sunny.Wang@arm.com>; devel@edk2.groups.io
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Michael D Kinney <michael.d.kinney@intel.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: RE: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL
Reviewed-By: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Sent: Friday, June 11, 2021 5:15 AM
> To: Sunny Wang <Sunny.Wang@arm.com>; devel@edk2.groups.io
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; G Edhaya
> Chandran <Edhaya.Chandran@arm.com>; Barton Gao
> <gaojie@byosoft.com.cn>; Michael D Kinney <michael.d.kinney@intel.com>
> Subject: Re: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event
> with TPL_HIGH_LEVEL
>
> On 11.06.21 10:35, Sunny Wang wrote:
> > The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent
> failures.
> >
> > Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
> > exclusive use by the firmware. The creation of events by UEFI
> > applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
> > level.
> >
> > Therefore, revert TPL_HIGH_LEVEL change in commits a9d1fb58 and
> > ae7e5477b555 to not create event with TPL_HIGH_LEVEL to be compliant
> > with UEFI Spec and fix the failures.
> >
> > For more information, https://edk2.groups.io/g/devel/message/76338
> >
> > Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> > Cc: G Edhaya Chandran <edhaya.chandran@arm.com>
> > Cc: Barton Gao <gaojie@byosoft.com.cn>
> > Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Signed-off-by: Sunny Wang <sunny.wang@arm.com>
>
> Acked-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
> > ---
> > .../EventTimerTaskPriorityServicesBBTestCreateEvent.c | 5 +----
> > .../EventTimerTaskPriorityServicesBBTestCreateEventEx.c | 4 +---
> > 2 files changed, 2 insertions(+), 7 deletions(-)
> >
> > diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > index a7e7366e..d5c033f7 100644
> > --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > @@ -2,6 +2,7 @@
> >
> > Copyright 2006 - 2012 Unified EFI, Inc.<BR>
> > Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>
> > + Copyright (c) 2021, ARM Limited. All rights reserved.
> >
> > This program and the accompanying materials
> > are licensed and made available under the terms and conditions of the
> BSD License
> > @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_TEST_ASSERTION AssertionType;
> > @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_TEST_ASSERTION AssertionType;
> > @@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_TEST_ASSERTION AssertionType;
> > @@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_TEST_ASSERTION AssertionType;
> > diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> > index eb458de5..03b7ae6e 100644
> > --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> > +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> > @@ -2,6 +2,7 @@
> >
> > Copyright 2006 - 2016 Unified EFI, Inc.<BR>
> > Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
> > + Copyright (c) 2021, ARM Limited. All rights reserved.
> >
> > This program and the accompanying materials
> > are licensed and made available under the terms and conditions of the
> BSD License
> > @@ -228,7 +229,6 @@ BBTestCreateEventEx_Conf_Sub1 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_GUID *EventGroups[] = {
> > @@ -318,7 +318,6 @@ BBTestCreateEventEx_Conf_Sub2 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_GUID *EventGroups[] = {
> > @@ -413,7 +412,6 @@ BBTestCreateEventEx_Conf_Sub3 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_GUID *EventGroups[] = {
> >
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL
2021-06-16 1:15 ` 回复: [edk2-devel] " Gao Jie
@ 2021-06-16 2:25 ` Sunny Wang
0 siblings, 0 replies; 6+ messages in thread
From: Sunny Wang @ 2021-06-16 2:25 UTC (permalink / raw)
To: Gao Jie, devel@edk2.groups.io, Samer El-Haj-Mahmoud,
'Heinrich Schuchardt'
Cc: G Edhaya Chandran, 'Michael D Kinney', Sunny Wang
Yeah, that is a typo. The result with 13 passes was got from testing with this fix. Thanks for catching this, Barton.
Best Regards,
Sunny Wang
-----Original Message-----
From: Gao Jie <gaojie@byosoft.com.cn>
Sent: Wednesday, June 16, 2021 9:15 AM
To: devel@edk2.groups.io; Sunny Wang <Sunny.Wang@arm.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; 'Heinrich Schuchardt' <xypron.glpk@gmx.de>
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; 'Michael D Kinney' <michael.d.kinney@intel.com>
Subject: 回复: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL
Hi Sunny,
I believe the result with 13 passes should be tested *with* this fix, right?
I saw reviewed-by/Acked-by from Samer and Heinrich, will get this patch upstreamed soon.
Thanks
Barton
-----邮件原件-----
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sunny Wang
发送时间: 2021年6月14日 17:53
收件人: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>; devel@edk2.groups.io
抄送: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Michael D Kinney <michael.d.kinney@intel.com>; Sunny Wang <Sunny.Wang@arm.com>
主题: Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL
Thanks for the review, Samer.
Moreover, I just built it and tested it on my ARM system, and confirmed the issue got fixed by this patch.
Without this fix, the result would be 18 tests, and 4 Errors.
CreateEvent_Func: [FAILED]
Passes........... 14
Warnings......... 0
Errors........... 4
Without this fix, the result would be 13 tests, and 0 Errors.
CreateEvent_Func: [PASSED]
Passes........... 13
Warnings......... 0
Errors........... 0
Best Regards,
Sunny Wang
-----Original Message-----
From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Sent: Monday, June 14, 2021 8:36 AM
To: Heinrich Schuchardt <xypron.glpk@gmx.de>; Sunny Wang <Sunny.Wang@arm.com>; devel@edk2.groups.io
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Michael D Kinney <michael.d.kinney@intel.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: RE: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL
Reviewed-By: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Sent: Friday, June 11, 2021 5:15 AM
> To: Sunny Wang <Sunny.Wang@arm.com>; devel@edk2.groups.io
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; G Edhaya
> Chandran <Edhaya.Chandran@arm.com>; Barton Gao
> <gaojie@byosoft.com.cn>; Michael D Kinney <michael.d.kinney@intel.com>
> Subject: Re: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event
> with TPL_HIGH_LEVEL
>
> On 11.06.21 10:35, Sunny Wang wrote:
> > The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent
> failures.
> >
> > Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
> > exclusive use by the firmware. The creation of events by UEFI
> > applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
> > level.
> >
> > Therefore, revert TPL_HIGH_LEVEL change in commits a9d1fb58 and
> > ae7e5477b555 to not create event with TPL_HIGH_LEVEL to be compliant
> > with UEFI Spec and fix the failures.
> >
> > For more information, https://edk2.groups.io/g/devel/message/76338
> >
> > Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> > Cc: G Edhaya Chandran <edhaya.chandran@arm.com>
> > Cc: Barton Gao <gaojie@byosoft.com.cn>
> > Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Signed-off-by: Sunny Wang <sunny.wang@arm.com>
>
> Acked-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
> > ---
> > .../EventTimerTaskPriorityServicesBBTestCreateEvent.c | 5 +----
> > .../EventTimerTaskPriorityServicesBBTestCreateEventEx.c | 4 +---
> > 2 files changed, 2 insertions(+), 7 deletions(-)
> >
> > diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > index a7e7366e..d5c033f7 100644
> > --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> > @@ -2,6 +2,7 @@
> >
> > Copyright 2006 - 2012 Unified EFI, Inc.<BR>
> > Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>
> > + Copyright (c) 2021, ARM Limited. All rights reserved.
> >
> > This program and the accompanying materials
> > are licensed and made available under the terms and conditions of the
> BSD License
> > @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_TEST_ASSERTION AssertionType;
> > @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_TEST_ASSERTION AssertionType;
> > @@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_TEST_ASSERTION AssertionType;
> > @@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_TEST_ASSERTION AssertionType;
> > diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> > index eb458de5..03b7ae6e 100644
> > --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> > +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> > @@ -2,6 +2,7 @@
> >
> > Copyright 2006 - 2016 Unified EFI, Inc.<BR>
> > Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
> > + Copyright (c) 2021, ARM Limited. All rights reserved.
> >
> > This program and the accompanying materials
> > are licensed and made available under the terms and conditions of the
> BSD License
> > @@ -228,7 +229,6 @@ BBTestCreateEventEx_Conf_Sub1 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_GUID *EventGroups[] = {
> > @@ -318,7 +318,6 @@ BBTestCreateEventEx_Conf_Sub2 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_GUID *EventGroups[] = {
> > @@ -413,7 +412,6 @@ BBTestCreateEventEx_Conf_Sub3 (
> > EFI_TPL NotifyTpls[] = {
> > TPL_CALLBACK,
> > TPL_NOTIFY,
> > - TPL_HIGH_LEVEL,
> > 0
> > };
> > EFI_GUID *EventGroups[] = {
> >
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-16 2:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-11 8:35 [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL Sunny Wang
2021-06-11 9:15 ` Heinrich Schuchardt
2021-06-14 0:36 ` Samer El-Haj-Mahmoud
2021-06-14 9:53 ` Sunny Wang
2021-06-16 1:15 ` 回复: [edk2-devel] " Gao Jie
2021-06-16 2:25 ` Sunny Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox