From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by mx.groups.io with SMTP id smtpd.web08.6157.1623402945360652077 for ; Fri, 11 Jun 2021 02:15:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=g/DGghz+; spf=pass (domain: gmx.de, ip: 212.227.17.22, mailfrom: xypron.glpk@gmx.de) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1623402933; bh=ikGlKJifhZ41n1r8SA4Rw2zst3AkNheoLDNt3rQAihU=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=g/DGghz+bK3Ku5nE7OZVP+fBU/b33CTcDSMb+E0o9kK/NqALNknE5haTMUyJhy4ho g7lNV6RsVCXQ1VAj6mj3Yj+GpKTEdlcdjh+ea5UKkI8hS9vLj7KNmvQNcdjwKXua+/ fZUe6+qeTAUIOVJLaJcuUxswHnXE5Z472b0fYJkM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.70] ([62.143.247.63]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MSKu0-1ll3hF2dvE-00SbDW; Fri, 11 Jun 2021 11:15:33 +0200 Subject: Re: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL To: Sunny Wang , devel@edk2.groups.io Cc: Samer El-Haj-Mahmoud , G Edhaya Chandran , Barton Gao , Michael D Kinney References: <20210611083521.1127-1-Sunny.Wang@arm.com> From: "Heinrich Schuchardt" Message-ID: <1f992968-484a-3df0-ebeb-97c11012e87d@gmx.de> Date: Fri, 11 Jun 2021 11:15:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210611083521.1127-1-Sunny.Wang@arm.com> X-Provags-ID: V03:K1:KABDtUXFkK5m287XJop+3FTAmKQEfyR8GImf+8+unJEh67gTIgs jNkOYxJOIaskX123aI/Bvu8Tk7zUNav7n70XI0DQ4OF2+agkBA8COyP6xaVko/i83Ia8+Wy dso4WjBe8MhT986sgneF7fIIkD8IbailHOtXCjOvkSGLM4ClfHmNv9proSb8TcKfClRav0+ WWO1iTbo6rP+tQYKR/uTg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:j9IN5MLFS/Q=:/wLDJ6owuZ8Pe6uPPkOy19 wq3G7UHLyQTso5pEiNRKBDqok6JsR4TkQa2GsIENRoMD5ERN8fmwHcwvJPc7pOT7K76Pj4qe9 F45t+BxRstYkVow/4WgsalrEdOEjDklcS2nSt9yr2ok/UJJel4hL51QU0gNKFMer9AwImQOOO E8beBTWSIKc2Y//JXnV1NAian6FGaxx6g67MUqmxdQskp6Ts8EFM+EVEIoOSCz/ufpoKrnNTz UFWwhtrkNDw/mMB5Dg+NwUsPNCjhpNy9qDScK8Csvbi0VLagxFRTo6WP3TKseWI9HodJSauVB D+iDETrmIuomHPDpe4KNo5PVRA1/24oBZNgOssTu2QkUNTUHjBBI8KpVLZo0QWpSEEUspSD1V J45qL2YAq4eeLMZFmlwVOSYhvT7NUwalPq4ng9uTRuI4CspH3TT11mSDtAppWvUX77klAfD4s K0iY/k60yHxtwzoqk3DmFACsctRrPTTlPEhfc3qfNows9cdzN4VImnfR2qmho000CgASnnK/1 QTGt07q0qFitZvkbBL8qB9wyJB9PuqZ+3qlRXbQSRWxOqI40w7+OZFR0RPyUnfWKeJ8xfzhlL 6AFBH2MzDR9IboDs3kgHnt1h8TxKr+Bj0m+3lb0+cT3IEW5D5Y7eXyreq9vnKR3VSmmI7Y3tw euoOFvB6hQbPvOdzYUCrqGELHsc+LAPhg0z+3EunoFoCw6mbUjPG8aptpaAsXMj4eiuDz90bM fNJhlhCOzACfwUhpE9suHznfFcLo2GIB2KGdEFeMzRCxfTqQQ9EJH5UPE6F3hE+AsGdCti/c6 wBeO6RfrRw0govJlVEY3GpxeFpg2zyw9fgdVS8UiIGGNHNpZ+GCoxo9n78vy5optP4lcsczQ5 UDjZxEAW5ihNYsHHya+uck9enztT7lv4sQk4c3ttfySAOD90Xp0X94/xpdKvoWw5jaGLANevH WeSchXpOTZW8QVCMpbGjZZLyIlHThhkfkK/TcryoN0Fel1nhtmLVggdnwdTTSafxydlA/j9vN NJLqVukJ38Njw5iz5MxBhqVGEoX13RMvvHIRB2kqWNoi3PtbVDvNznIRy7zie/RyFKbRvjYvF oEYvkTarjbLhmEWOxr5I3hcBUZe4wA03nTd Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11.06.21 10:35, Sunny Wang wrote: > The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent failures= . > > Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for > exclusive use by the firmware. The creation of events by UEFI > applications, UEFI drivers, and UEFI OS Loaders should not use this TPL > level. > > Therefore, revert TPL_HIGH_LEVEL change in commits a9d1fb58 and > ae7e5477b555 to not create event with TPL_HIGH_LEVEL to be compliant > with UEFI Spec and fix the failures. > > For more information, https://edk2.groups.io/g/devel/message/76338 > > Cc: Samer El-Haj-Mahmoud > Cc: G Edhaya Chandran > Cc: Barton Gao > Cc: Heinrich Schuchardt > Cc: Michael D Kinney > Signed-off-by: Sunny Wang Acked-by: Heinrich Schuchardt > --- > .../EventTimerTaskPriorityServicesBBTestCreateEvent.c | 5 +---- > .../EventTimerTaskPriorityServicesBBTestCreateEventEx.c | 4 +--- > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTa= skPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreate= Event.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPri= orityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent= .c > index a7e7366e..d5c033f7 100644 > --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPrior= ityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c > +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPrior= ityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c > @@ -2,6 +2,7 @@ > > Copyright 2006 - 2012 Unified EFI, Inc.
> Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved. > + Copyright (c) 2021, ARM Limited. All rights reserved. > > This program and the accompanying materials > are licensed and made available under the terms and conditions of the= BSD License > @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 ( > EFI_TPL NotifyTpls[] =3D { > TPL_CALLBACK, > TPL_NOTIFY, > - TPL_HIGH_LEVEL, > 0 > }; > EFI_TEST_ASSERTION AssertionType; > @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 ( > EFI_TPL NotifyTpls[] =3D { > TPL_CALLBACK, > TPL_NOTIFY, > - TPL_HIGH_LEVEL, > 0 > }; > EFI_TEST_ASSERTION AssertionType; > @@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 ( > EFI_TPL NotifyTpls[] =3D { > TPL_CALLBACK, > TPL_NOTIFY, > - TPL_HIGH_LEVEL, > 0 > }; > EFI_TEST_ASSERTION AssertionType; > @@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 ( > EFI_TPL NotifyTpls[] =3D { > TPL_CALLBACK, > TPL_NOTIFY, > - TPL_HIGH_LEVEL, > 0 > }; > EFI_TEST_ASSERTION AssertionType; > diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTa= skPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreate= EventEx.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskP= riorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEve= ntEx.c > index eb458de5..03b7ae6e 100644 > --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPrior= ityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx= .c > +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPrior= ityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx= .c > @@ -2,6 +2,7 @@ > > Copyright 2006 - 2016 Unified EFI, Inc.
> Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. > + Copyright (c) 2021, ARM Limited. All rights reserved. > > This program and the accompanying materials > are licensed and made available under the terms and conditions of the= BSD License > @@ -228,7 +229,6 @@ BBTestCreateEventEx_Conf_Sub1 ( > EFI_TPL NotifyTpls[] =3D { > TPL_CALLBACK, > TPL_NOTIFY, > - TPL_HIGH_LEVEL, > 0 > }; > EFI_GUID *EventGroups[] =3D { > @@ -318,7 +318,6 @@ BBTestCreateEventEx_Conf_Sub2 ( > EFI_TPL NotifyTpls[] =3D { > TPL_CALLBACK, > TPL_NOTIFY, > - TPL_HIGH_LEVEL, > 0 > }; > EFI_GUID *EventGroups[] =3D { > @@ -413,7 +412,6 @@ BBTestCreateEventEx_Conf_Sub3 ( > EFI_TPL NotifyTpls[] =3D { > TPL_CALLBACK, > TPL_NOTIFY, > - TPL_HIGH_LEVEL, > 0 > }; > EFI_GUID *EventGroups[] =3D { >