From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mx.groups.io with SMTP id smtpd.web11.19591.1687622744397337026 for ; Sat, 24 Jun 2023 09:05:45 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm3 header.b=mgesShta; spf=pass (domain: bsdio.com, ip: 66.111.4.27, mailfrom: rebecca@bsdio.com) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id A14065C0078; Sat, 24 Jun 2023 12:05:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 24 Jun 2023 12:05:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1687622743; x=1687709143; bh=ZonzGjq4dqO1/wIRyjUAAfSuDAsPFIDg3Dt rvqCNdgU=; b=mgesShtafSW1HunE7PHOwetGRl7TwcddYLoSkwHTioi/uIGAF7a yDcpf9N4++rh2da+a7ZKGsL3aDoLm/OJFox/aHpxDpxyKARpeIfkbP2PUkTwvYaH lSg8HqK92pNm1FBR8BV/suRuK+piSHKumE0+ckdKcu/utRIwBoNsnBMMP3EXqoJ1 pXq5CXFWSO0PxZ8itdR3eNoTZ70WQGTWAYlMQ3kxOYmnaAwUc3KsxOSYI//q7w2K wX1QJ7LsgjhrqdBRs6FGMEu8A5UBuD558iT3Rx/j6/tT4pJSuXMIVfOaJBoEb3Eq rgTojVLRne2xyJOWu9+uC0TJZmR063i4B3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687622743; x=1687709143; bh=ZonzGjq4dqO1/wIRyjUAAfSuDAsPFIDg3Dt rvqCNdgU=; b=LgJ1PhjhnrUG2a7rhWgX1YcWNA+v/K5DpJ4pn42Kv566hcUATkO kt6oVVEb4g+/2EMmvp7exeHCjxBWCQo5yHA6rb201gEMr83cFkb47YMaGYhutwFy 1CO5NaHeloqTL5Y8pVYfbIR9fRe3ZPckWRtWy7WBtRGXtfYDni75VHrAUoVvo326 CwlCdBuRViorpgZcmsbOYtfNy4luH/BsX0wkPsgXf+QWGGVmA2blG7fdadnBx2Qa u3Jst8gWom6HMKIchiFnntDZKYOsug50CkcCgHpgHMtgdj72yeYuhFBSWoSYK/+1 kic0oLoZLNQzLHzU1OoykcXl1N89l8S9JJw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeegjedgleeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeeugeffudehtdffieelgeelvdehudehgfekueevvdeuudelffdtheehieeg jeeileenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughiohdrtgho mh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 24 Jun 2023 12:05:41 -0400 (EDT) Message-ID: <1fbcfa66-e249-9637-93cd-246da7be874b@bsdio.com> Date: Sat, 24 Jun 2023 10:05:34 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: Add "-fno-unwind-tables" to GCC5_RISCV64_CC_FLAGS To: devel@edk2.groups.io, sunilvl@ventanamicro.com Cc: Liming Gao , Bob Feng , Yuwei Chen , Andrei Warkentin References: <20230602170254.394449-1-sunilvl@ventanamicro.com> From: "Rebecca Cran" In-Reply-To: <20230602170254.394449-1-sunilvl@ventanamicro.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sorry for the delay! I started a new job earlier this month so have got backlogged on EDK2 work. Reviewed-by: Rebecca Cran On 6/2/23 11:02, Sunil V L wrote: > gcc-13 for RISC-V enables unwind tables by default similar to ARM64. > This generates .eh_frame_hdr section which is not handled well by > GenFw causing failures. > > Disable the unwind tables by adding -fno-unwind-tables flag similar > to [1]. > > [1] - https://github.com/tianocore/edk2/commit/cbf00651eda6 > > Signed-off-by: Sunil V L > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > Cc: Andrei Warkentin > --- > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > index 92421e3d0118..90f4105506e5 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -858,7 +858,7 @@ DEFINE GCC5_RISCV_OPENSBI_TYPES = -DOPENSBI_EXTERNAL_SBI_TYPES > > DEFINE GCC5_RISCV64_ARCH = rv64gc > DEFINE GCC5_RISCV32_RISCV64_ASLDLINK_FLAGS = DEF(GCC5_RISCV_ALL_DLINK_COMMON) -Wl,--entry,ReferenceAcpiTable -u ReferenceAcpiTable > -DEFINE GCC5_RISCV64_CC_FLAGS = DEF(GCC5_RISCV_ALL_CC_FLAGS) DEF(GCC5_RISCV_ALL_CC_FLAGS_WARNING_DISABLE) DEF(GCC5_RISCV_OPENSBI_TYPES) -march=DEF(GCC5_RISCV64_ARCH) -fno-builtin -fno-builtin-memcpy -fno-stack-protector -Wno-address -fno-asynchronous-unwind-tables -Wno-unused-but-set-variable -fpack-struct=8 -mcmodel=medany -mabi=lp64 -mno-relax > +DEFINE GCC5_RISCV64_CC_FLAGS = DEF(GCC5_RISCV_ALL_CC_FLAGS) DEF(GCC5_RISCV_ALL_CC_FLAGS_WARNING_DISABLE) DEF(GCC5_RISCV_OPENSBI_TYPES) -march=DEF(GCC5_RISCV64_ARCH) -fno-builtin -fno-builtin-memcpy -fno-stack-protector -Wno-address -fno-asynchronous-unwind-tables -fno-unwind-tables -Wno-unused-but-set-variable -fpack-struct=8 -mcmodel=medany -mabi=lp64 -mno-relax > DEFINE GCC5_RISCV64_DLINK_FLAGS = DEF(GCC5_RISCV_ALL_DLINK_FLAGS) -Wl,-melf64lriscv,--oformat=elf64-littleriscv,--no-relax > DEFINE GCC5_RISCV64_DLINK2_FLAGS = DEF(GCC5_RISCV_ALL_DLINK2_FLAGS) > DEFINE GCC5_RISCV64_ASM_FLAGS = DEF(GCC5_RISCV_ALL_ASM_FLAGS) -march=DEF(GCC5_RISCV64_ARCH) -mcmodel=medany -mabi=lp64