From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by mx.groups.io with SMTP id smtpd.web12.7634.1582084569958949205 for ; Tue, 18 Feb 2020 19:56:10 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uRT+7DYw; spf=pass (domain: gmail.com, ip: 209.85.210.196, mailfrom: newexplorerj@gmail.com) Received: by mail-pf1-f196.google.com with SMTP id 4so11781857pfz.9 for ; Tue, 18 Feb 2020 19:56:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Jp895mDQx6dfJFn/GlNLCX7ecm0iahpwhE4gn3co6mY=; b=uRT+7DYw83s5iw0fVItgTqfNuyGYRThIEDB6N/+QlTzfTQb4tJaTFKPdj11cNrsL5c Szea23psfpAlgkGAg7UOFTKXWlPj205w+2XcOGnFn+2QVKsAUnBPOE70yYGaqMG/Jgi9 minQhkws2UbBmOyh6eI9w9aoOqcQtL7nBG1VvLgA1sBg4Ve8nsSk/xMkiv+uTlF5Pb5Q /jvffMpDki+uI09KkZKH8wORmpHqQh1MoqO/ff5hMLdBduQrDrz8OcwAeZebmSh+7aku GSaux3/XXUvi/VErIGB4zeydc7pOCOF07iNjHAw9DrxpBveOmSR1uvj2qmaxfauAfbIj iJvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Jp895mDQx6dfJFn/GlNLCX7ecm0iahpwhE4gn3co6mY=; b=FDzS2GFiXAF8QqXtZGlosREA0TkA9kgsD9X2yYslKVWeghXsG1Agjr7w57Ts5pJKfa k/DgBBDs8YGb7HynpQoWK0lKjGUHbTnqkIFMQl3dznOKpbNTjz88jnxZ2s/RabnFh4mg ZGR8PyC990NATVevmZNdU1h/9I4yDMTPDqtrsQQKfZORuqQUtsWSXJQyAg4A0EQBwnAw BM1vl4qq9+UE4Y2tv1pTc8JU25iOfcKTJ6423yVWNKC6kcJSrWTMN5elBM42aOoDScm8 8Qkt7iEAEb8mszrXtnGA33ilnSmIp02UdXavLYzn/Skwn/66zGR4UcuaYjYP/H17alMV Ktcw== X-Gm-Message-State: APjAAAVs3KW4+88KPvFqgl3h7QiVA9dk1sfI73z8BKHM6W3V1UntHPSP o4aR2Bf0sn089b+Nyp319vIIJ7iknrITMQ== X-Google-Smtp-Source: APXvYqyvC400Acrr3Z8oQJmowhTNa+NnmkYGH8qgkQTUYIYPSopv2tNolDcvaoURHZozJrfmTl1DwA== X-Received: by 2002:a65:60da:: with SMTP id r26mr8622982pgv.271.1582084569072; Tue, 18 Feb 2020 19:56:09 -0800 (PST) Return-Path: Received: from localhost.localdomain ([117.136.46.20]) by smtp.gmail.com with ESMTPSA id c15sm511094pfo.137.2020.02.18.19.56.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 19:56:08 -0800 (PST) From: "GuoMinJ" To: devel@edk2.groups.io Cc: GuoMinJ Subject: [PATCH] MdePkg/Test: Pointer BinData need to be checked Date: Wed, 19 Feb 2020 11:52:52 +0800 Message-Id: <1fe1a760a9fab408ff7d96f85e115a20c6ea7c30.1582081265.git.newexplorerj@gmail.com> X-Mailer: git-send-email 2.17.1 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2531 AllocatePool may fail and BinData may be invalid, check it before use. Signed-off-by: GuoMinJ --- MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c index 6f7c31cab4..933d2b40e0 100644 --- a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c +++ b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c @@ -252,6 +252,9 @@ RfcDecodeTest( BinSize = AsciiStrnLenS (binString, MAX_TEST_STRING_SIZE); BinData = AllocatePool (BinSize); + if (BinData == NULL) { + return UNIT_TEST_ERROR_TEST_FAILED; + } Btc->BufferToFree = BinData; ReturnSize = BinSize; -- 2.17.1