From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120])
 by mx.groups.io with SMTP id smtpd.web10.5522.1587734763380967852
 for <devel@edk2.groups.io>;
 Fri, 24 Apr 2020 06:26:03 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HHA8S6iw;
 spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1587734762;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+XoCucwVdfhxW90MhCn5Bof7R2dHC8W3ZmsJ67PRMus=;
	b=HHA8S6iws0mJvjOiIvpRh3HHlSdd4XE2Rz1m5s804UVHlBpRH/otXQgcC6InU0KaVDT3iM
	WPriubj18miKO3xi8+d34VILwhup1vi4VvkYqW6jf/bV0X5+dNm/FB8CNDC7o4WHGEqRsM
	XCpl+On+vqRFImxNyVf2RgEk9ptk7AM=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-409-ZJSKJUtlMI-7fJKkgaVuiQ-1; Fri, 24 Apr 2020 09:25:55 -0400
X-MC-Unique: ZJSKJUtlMI-7fJKkgaVuiQ-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1439C800D24;
	Fri, 24 Apr 2020 13:25:54 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-159.ams2.redhat.com [10.36.113.159])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 4E1E75C1D2;
	Fri, 24 Apr 2020 13:25:52 +0000 (UTC)
Subject: Re: [PATCH V2 0/7] CryptoPkg: Retire the deprecated functions
To: Zhichao Gao <zhichao.gao@intel.com>, devel@edk2.groups.io
Cc: Jian J Wang <jian.j.wang@intel.com>, Xiaoyu Lu <xiaoyux.lu@intel.com>,
 Siyuan Fu <siyuan.fu@intel.com>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Jiewen Yao <jiewen.yao@intel.com>
References: <20200423084627.3384-1-zhichao.gao@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <1ff60547-33de-d0d6-42f1-ae58f2fef845@redhat.com>
Date: Fri, 24 Apr 2020 15:25:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200423084627.3384-1-zhichao.gao@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

Hi Zhichao,

On 04/23/20 10:46, Zhichao Gao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
> 
> Retire below deprecated functions:
> MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1
> 
> Update the Crypto Driver's version to indicate the binary change.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> 
> Zhichao Gao (7):
>   CryptoPkg/BaseCrpytLib: Retire MD4 algorithm
>   CryptoPkg/BaseCryptLib: Retire ARC4 algorithm
>   CryptoPkg/BaseCryptLib: Retire the Tdes algorithm
>   CryptoPkg/BaseCryptLib: Retire Aes Ecb mode algorithm
>   CryptoPkg/BaseCryptLib: Retire HMAC MD5 algorithm
>   CryptoPkg/BaseCryptLib: Retire HMAC SHA1 algorithm
>   CryptoPkg/Crypto.h: Update the version of Crypto Driver

I'm drowning in stuff to take care of; I cannot review this series.
Thanks for your understanding.

Laszlo