From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9CC45211BD612 for ; Wed, 30 Jan 2019 07:44:12 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 07:44:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="120699696" Received: from linux.intel.com ([10.54.29.200]) by fmsmga008.fm.intel.com with ESMTP; 30 Jan 2019 07:44:11 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 3406F580550; Wed, 30 Jan 2019 07:44:10 -0800 (PST) Message-ID: <1ff8f9b4f733fb666d624aba5686ba84d841d633.camel@linux.intel.com> From: Ryszard Knop To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com Date: Wed, 30 Jan 2019 16:44:08 +0100 In-Reply-To: <20181115023353.20159-3-ard.biesheuvel@linaro.org> References: <20181115023353.20159-1-ard.biesheuvel@linaro.org> <20181115023353.20159-3-ard.biesheuvel@linaro.org> Organization: Intel Corporation User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Subject: Re: [PATCH edk2-staging 02/20] IntelUndiPkg/XGigUndiDxe: move MSFT warning overrides to INF file X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:44:12 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Reviewed-by: Ryszard Knop On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote: > GCC chokes on the unknown MSVC specific #pragmas used for suppressing > warnings, so remove them and use the INF BuildOptions section > instead. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 4 ++-- > IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h | 10 ---------- > 2 files changed, 2 insertions(+), 12 deletions(-) > > diff --git a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > index ab9c64dac7e8..7ccc52bc9869 100644 > --- a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > +++ b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > @@ -44,7 +44,7 @@ UNLOAD_IMAGE = UnloadXGigUndiDriver > > [BuildOptions.common] > > -MSFT:*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG /D UNDI_10G > +MSFT:*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG /D UNDI_10G /wd4244 > /wd4206 /wd4189 > GCC:*_*_*_CC_FLAGS = -DUNDI_10G > GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG > > @@ -60,7 +60,7 @@ GCC:*_*_*_CC_FLAGS = -DEFI64 > > [BuildOptions.IA32] > > -MSFT:*_*_*_CC_FLAGS = /D EFI32 > +MSFT:*_*_*_CC_FLAGS = /D EFI32 /wd4305 > GCC:*_*_*_CC_FLAGS = -DEFI32 > > [sources.common] > diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h > b/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h > index 6fa0d1605c7c..368f40811904 100644 > --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h > +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h > @@ -29,16 +29,6 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE > POSSIBILITY OF SUCH DAMAGE. > #ifndef IXGBE_OSDEP_H_ > #define IXGBE_OSDEP_H_ > > -#pragma warning(disable : 4244) > -#pragma warning(disable : 4206) > -#pragma warning(disable : 4189) > - > -#ifdef EFI32 > - > -// Remove truncation warning in type cast when some 64 bit variables > are converted to 32-bit pointers > -#pragma warning(disable : 4305) > -#endif /* EFI32 */ > - > #ifndef EFI_SPECIFICATION_VERSION > #define EFI_SPECIFICATION_VERSION 0x00020000 > #endif /* EFI_SPECIFICATION_VERSION */