public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"Zhang, Shenglei" <shenglei.zhang@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [PATCH] ShellPkg Shell: Remove an unused global variable
Date: Fri, 7 Sep 2018 13:14:17 +0200	[thread overview]
Message-ID: <1ffdb14c-6f3f-178b-f390-f7dad2f65b79@redhat.com> (raw)
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BDFB9F5@SHSMSX104.ccr.corp.intel.com>

On 09/07/18 06:39, Ni, Ruiyu wrote:
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Commit 98257f982072.

Thanks
Laszlo


>> -----Original Message-----
>> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of shenglei
>> Sent: Friday, September 7, 2018 9:52 AM
>> To: edk2-devel@lists.01.org
>> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
>> Subject: [edk2] [PATCH] ShellPkg Shell: Remove an unused global variable
>>
>> The unused global variable InvalidChars is removed.
>> It is only used in the function IsValidCommandName which was removed
>> previously.
>> https://bugzilla.tianocore.org/show_bug.cgi?id=1066
>>
>> Cc: Jaben Carsey <jaben.carsey@intel.com>
>> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: shenglei <shenglei.zhang@intel.com>
>> ---
>>  ShellPkg/Application/Shell/Shell.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/ShellPkg/Application/Shell/Shell.c
>> b/ShellPkg/Application/Shell/Shell.c
>> index 397cfd1994..3f3bcbb4b0 100644
>> --- a/ShellPkg/Application/Shell/Shell.c
>> +++ b/ShellPkg/Application/Shell/Shell.c
>> @@ -2750,9 +2750,6 @@ RunCommand(
>>    return (RunShellCommand(CmdLine, NULL));  }
>>
>> -
>> -STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"',
>> 0x0001, 0x0002};
>> -
>>  /**
>>    Function to process a NSH script file via SHELL_FILE_HANDLE.
>>
>> --
>> 2.18.0.windows.1
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> 



      reply	other threads:[~2018-09-07 11:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07  1:52 [PATCH] ShellPkg Shell: Remove an unused global variable shenglei
2018-09-07  4:39 ` Ni, Ruiyu
2018-09-07 11:14   ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ffdb14c-6f3f-178b-f390-f7dad2f65b79@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox