From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D87FB21125010 for ; Fri, 7 Sep 2018 04:14:19 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D0AA977886; Fri, 7 Sep 2018 11:14:18 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-152.rdu2.redhat.com [10.10.120.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id 197F3112C26E; Fri, 7 Sep 2018 11:14:17 +0000 (UTC) To: "Ni, Ruiyu" , "Zhang, Shenglei" , "edk2-devel@lists.01.org" Cc: "Carsey, Jaben" References: <20180907015221.45024-1-shenglei.zhang@intel.com> <734D49CCEBEEF84792F5B80ED585239D5BDFB9F5@SHSMSX104.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <1ffdb14c-6f3f-178b-f390-f7dad2f65b79@redhat.com> Date: Fri, 7 Sep 2018 13:14:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BDFB9F5@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 07 Sep 2018 11:14:18 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 07 Sep 2018 11:14:18 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH] ShellPkg Shell: Remove an unused global variable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Sep 2018 11:14:20 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/07/18 06:39, Ni, Ruiyu wrote: > Reviewed-by: Ruiyu Ni Commit 98257f982072. Thanks Laszlo >> -----Original Message----- >> From: edk2-devel On Behalf Of shenglei >> Sent: Friday, September 7, 2018 9:52 AM >> To: edk2-devel@lists.01.org >> Cc: Carsey, Jaben ; Ni, Ruiyu >> Subject: [edk2] [PATCH] ShellPkg Shell: Remove an unused global variable >> >> The unused global variable InvalidChars is removed. >> It is only used in the function IsValidCommandName which was removed >> previously. >> https://bugzilla.tianocore.org/show_bug.cgi?id=1066 >> >> Cc: Jaben Carsey >> Cc: Ruiyu Ni >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: shenglei >> --- >> ShellPkg/Application/Shell/Shell.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/ShellPkg/Application/Shell/Shell.c >> b/ShellPkg/Application/Shell/Shell.c >> index 397cfd1994..3f3bcbb4b0 100644 >> --- a/ShellPkg/Application/Shell/Shell.c >> +++ b/ShellPkg/Application/Shell/Shell.c >> @@ -2750,9 +2750,6 @@ RunCommand( >> return (RunShellCommand(CmdLine, NULL)); } >> >> - >> -STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"', >> 0x0001, 0x0002}; >> - >> /** >> Function to process a NSH script file via SHELL_FILE_HANDLE. >> >> -- >> 2.18.0.windows.1 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >