From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1E2DF2097DD1E for ; Tue, 29 May 2018 01:39:41 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CF4948D6D4; Tue, 29 May 2018 08:39:40 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-253.rdu2.redhat.com [10.10.120.253]) by smtp.corp.redhat.com (Postfix) with ESMTP id 505F12026DEF; Tue, 29 May 2018 08:39:40 +0000 (UTC) To: Liming Gao References: <1527570256-16140-1-git-send-email-liming.gao@intel.com> Cc: edk2-devel@lists.01.org From: Laszlo Ersek Message-ID: <1fffb671-4ad2-8e40-872f-fdc8af94c1ad@redhat.com> Date: Tue, 29 May 2018 10:39:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1527570256-16140-1-git-send-email-liming.gao@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 29 May 2018 08:39:40 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 29 May 2018 08:39:40 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [Patch] OvmfPkg BasePciCapLib: Fix VS build failure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 May 2018 08:39:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/29/18 07:04, Liming Gao wrote: > Fix VS warning C4244: 'function': conversion from 'UINT32' to 'UINT16', > possible loss of data. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Laszlo Ersek > --- > OvmfPkg/Library/BasePciCapLib/BasePciCapLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/OvmfPkg/Library/BasePciCapLib/BasePciCapLib.c b/OvmfPkg/Library/BasePciCapLib/BasePciCapLib.c > index c059264..54e7409 100644 > --- a/OvmfPkg/Library/BasePciCapLib/BasePciCapLib.c > +++ b/OvmfPkg/Library/BasePciCapLib/BasePciCapLib.c > @@ -613,8 +613,8 @@ PciCapListInit ( > } > > Status = InsertPciCap (OutCapList, CapHdrOffsets, PciCapExtended, > - ExtendedCapHdr.CapabilityId, ExtendedCapHdrOffset, > - ExtendedCapHdr.CapabilityVersion); > + (UINT16) ExtendedCapHdr.CapabilityId, ExtendedCapHdrOffset, > + (UINT8) ExtendedCapHdr.CapabilityVersion); > if (RETURN_ERROR (Status)) { > goto FreeCapHdrOffsets; > } > Reviewed-by: Laszlo Ersek Before pushing, I removed the whitespace right after the casts -- in the past, we've had problems due to such whitespace; it caused confusion about operator binding strength. Typecast is one of the most strongly binding operators, so I find the space after it counter-intuitive. I also ran some basic regression-tests before pushing the patch. Commit 2d0c6692eee4. Thanks for the patch! Laszlo