From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH edk2-platforms 4/5] Platform/Hisilicon: Add VariableFlashInfoLib to Hisilicon.dsc.inc To: PierreGondois ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Cambridge, England, GB (217.140.106.53) X-Originating-Platform: Windows Firefox 109 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Thu, 26 Jan 2023 03:31:16 -0800 References: <20230125102802.663790-5-Pierre.Gondois@arm.com> In-Reply-To: <20230125102802.663790-5-Pierre.Gondois@arm.com> Message-ID: <20057.1674732676768033185@groups.io> Content-Type: multipart/alternative; boundary="lEgTcsmg4jAJdiGBjyt1" --lEgTcsmg4jAJdiGBjyt1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Pierre, Thank you for this patch. On Wed, Jan 25, 2023 at 02:28 AM, PierreGondois wrote: >=20 > - Platform/Hisilicon/D03/D03.dsc > - Platform/Hisilicon/D06/D06.dsc There is also Platform/Hisilicon/D05/D05.dsc that probably depends on this = fix. However, I find the builds for all the D0x platforms fail. Apparently,= the issue is the file Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf coul= d not be found. Have you seen this issue or there is something wrong in my setup? Other than that I could test this patch indeed fixes the build issue for Hi= Key960 and HiKey platform. Since this fix is required for the D0x platforms as well. Reviewed-by: Sami Mujawar Regards, Sami Mujawar --lEgTcsmg4jAJdiGBjyt1 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Pierre,

Thank you for this patch.

On Wed, Jan 25, = 2023 at 02:28 AM, PierreGondois wrote:
- Platform/Hisilicon/D03/D03.dsc
- Platform/Hisilicon/D06/= D06.dsc
There is also Platform/Hisilicon/D05/D05.dsc that probably depends on this = fix. However, I find the builds for all the D0x platforms fail. Apparently,= the issue is the file Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf coul= d not be found.
Have you seen this issue or there is something wrong i= n my setup?

Other than that I could test this patch indeed fixe= s the build issue for HiKey960 and HiKey platform.
Since this fix is r= equired for the D0x platforms as well.

Reviewed-by: Sami Mujawar= <sami.mujawar@arm.com>

Regards,

Sami Mujawar --lEgTcsmg4jAJdiGBjyt1--