From: rebecca@bluestop.org
To: devel@edk2.groups.io, zhijux.fan@intel.com
Cc: "Gao, Liming" <liming.gao@intel.com>,
"Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged
Date: Sun, 23 Jun 2019 21:25:21 -0600 [thread overview]
Message-ID: <2008e91f-4144-80dd-3632-1298cb054384@bluestop.org> (raw)
In-Reply-To: <FAD0D7E0AE0FA54D987F6E72435CAFD50AF8419A@SHSMSX101.ccr.corp.intel.com>
On 2019-06-20 20:33, Fan, ZhijuX wrote:
> - ret=`echo "$origin_version < $python_version" |bc`
> - if [ "$ret" -eq 1 ]; then
> + if [ "$origin_version" \< "$python_version" ]; then
> origin_version=$python_version
> export PYTHON_COMMAND=$python
> fi
I think using the "-lt" operator might be better (more standard). e.g.:
if [ "$origin_version" -lt "$python_version" ]; then
--
Rebecca Cran
next prev parent reply other threads:[~2019-06-24 3:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 2:33 [PATCH] BaseTools:Linux changes the way the latest version is judged Fan, ZhijuX
2019-06-24 3:17 ` Liming Gao
2019-06-24 3:25 ` rebecca [this message]
2019-06-25 2:18 ` FW: [edk2-devel] " Fan, ZhijuX
2019-06-25 2:33 ` rebecca
2019-06-26 4:46 ` Fan, ZhijuX
2019-06-26 15:47 ` rebecca
-- strict thread matches above, loose matches on Subject: below --
2019-06-28 7:48 Fan, ZhijuX
2019-07-01 3:59 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2008e91f-4144-80dd-3632-1298cb054384@bluestop.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox