From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mx.groups.io with SMTP id smtpd.web11.30950.1683366324964231328 for ; Sat, 06 May 2023 02:45:25 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=ACNE4v9A; spf=pass (domain: bsdio.com, ip: 66.111.4.26, mailfrom: rebecca@bsdio.com) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3893E5C00D5; Sat, 6 May 2023 05:45:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 06 May 2023 05:45:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1683366324; x=1683452724; bh=2UA/sFML2v/JgDBz9XSkf4ldEmBt2+FISgf CsjG6ODI=; b=ACNE4v9A4vhIAqgTs95kHW3/OK06yfnQdCR8MmZhD5oedtx0oJF o0D47AyAH7qL6xnPrCZ7YqOtNRfJYQhAtS7Rx9cgHWbb4KRVy9GdJgtuS6sqX5Lo /tregy75M0+3D0zNdkJlf6f08Q3wMnztMuxrFZb8G5KuJGkvR+zj40w7hr0HiIZ0 HpFQ9ZquZ9L/l7odw5AByB4XKJ0zhnJv43dTeWCddVNnVTOHTMzVTEovVUmc+pPy XGPbL6OJtROjsUsQHupUpNHrc02uFlZo6/AIPesSlJOaQ2muVEHN4DB4DvVxCsgY GlhmE93VSO6Ti5UtEut06Svp80nODe3VX6g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683366324; x=1683452724; bh=2UA/sFML2v/JgDBz9XSkf4ldEmBt2+FISgf CsjG6ODI=; b=S2Sh+LxdXSGYBGE9O0cfdpsaGGNDsD6yMdCFN1RBFnM8eQyziaX xI9ydt44j7HggGeRbsAh2z8L439/LZLfFbsUbK9WafM4DZr9/zl1HiutydIE8vte 8rOTuI6RssmKre/c9t6GcE1PqI2TcmPBzgsuKUHfWhDGNsF5F56GBW7LPxzzN5cm KKTo548MsHXHoVAuOXyY1MTg61oVvtPrJSXJRgJFRIdbDP0N4MeDr4KPD0a32N1/ c1fb3/bC31HnaXOwc++lnyiH2/gXu706AIpS61KPZI6ERz7yrPKEY+YF3Bdxdg9Z ZjUgIyC4iH6eZI0d6ha6WEMWL645Ui/aAgA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeffedgudeglecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomheptfgv sggvtggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrf grthhtvghrnhepveffgfdtffejfedujeelfedujeejteduvdfhgeduhfdutdelfefgudeu jeetveeunecuffhomhgrihhnpehtihgrnhhotghorhgvrdhorhhgnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughi ohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 6 May 2023 05:45:23 -0400 (EDT) Message-ID: <200fa69d-d019-3af4-f11e-6af858d36ee2@bsdio.com> Date: Sat, 6 May 2023 03:45:22 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [Patch 1/1] BaseTools/Conf: Align CLANGDWARF and CLANGPDB warning overrides To: Michael D Kinney , devel@edk2.groups.io Cc: Liming Gao , Bob Feng , Yuwei Chen References: <20230506023742.1213-1-michael.d.kinney@intel.com> From: "Rebecca Cran" In-Reply-To: <20230506023742.1213-1-michael.d.kinney@intel.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Rebecca Cran On 5/5/23 20:37, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4447 > > Fix build error related to use of DEBUG_CODE_BEGIN() and > DEBUG_CODE_END(). CLANGPDB requires extra warning disables > for use of DebugLib.h macros. This change aligns the warning > disables between CLANGDWARF and CLANGPDB. > > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > Signed-off-by: Michael D Kinney > --- > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > index 1b3a9e7a540a..0e49d8c3b999 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -1753,7 +1753,7 @@ DEFINE CLANGPDB_X64_PREFIX = ENV(CLANG_BIN) > DEFINE CLANGPDB_IA32_TARGET = -target i686-unknown-windows-gnu > DEFINE CLANGPDB_X64_TARGET = -target x86_64-unknown-windows-gnu > > -DEFINE CLANGPDB_WARNING_OVERRIDES = -Wno-parentheses-equality -Wno-tautological-compare -Wno-tautological-constant-out-of-range-compare -Wno-empty-body -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-option -Wno-microsoft-enum-forward-reference > +DEFINE CLANGPDB_WARNING_OVERRIDES = -Wno-parentheses-equality -Wno-tautological-compare -Wno-tautological-constant-out-of-range-compare -Wno-empty-body -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-option -Wno-unused-but-set-variable -Wno-unused-const-variable -Wno-unaligned-access -Wno-microsoft-enum-forward-reference > DEFINE CLANGPDB_ALL_CC_FLAGS = DEF(GCC48_ALL_CC_FLAGS) DEF(CLANGPDB_WARNING_OVERRIDES) -fno-stack-protector -funsigned-char -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang -Wno-address -Wno-shift-negative-value -Wno-unknown-pragmas -Wno-incompatible-library-redeclaration -Wno-null-dereference -mno-implicit-float -mms-bitfields -mno-stack-arg-probe -nostdlib -nostdlibinc -fseh-exceptions > > ###########################