* [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal
@ 2022-02-11 8:05 Sean Rhodes
2022-02-18 2:16 ` [edk2-devel] " Wu, Hao A
2022-10-10 8:29 ` Ni, Ray
0 siblings, 2 replies; 10+ messages in thread
From: Sean Rhodes @ 2022-02-11 8:05 UTC (permalink / raw)
To: devel; +Cc: guo.dong, Matt DeVillier, Hao A Wu, Ray Ni, Sean Rhodes
From: Matt DeVillier <matt.devillier@gmail.com>
Recent model Chromebooks only return ACK, but not
BAT_SUCCESS, which causes hanging and failed ps2k init.
To mitigate this, make the absence of BAT_SUCCESS reply
non-fatal, and reduce the no-reply timeout from 4s to 1s.
Tested on google/dracia and purism/librem_14
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
---
MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 6 +-----
MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 2 +-
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
index 77dc226222..6c71355edd 100644
--- a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
+++ b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
@@ -1733,11 +1733,7 @@ InitKeyboard (
//
mWaitForValueTimeOut = KEYBOARD_BAT_TIMEOUT;
- Status = KeyboardWaitForValue (ConsoleIn, KEYBOARD_8048_RETURN_8042_BAT_SUCCESS);
- if (EFI_ERROR (Status)) {
- KeyboardError (ConsoleIn, L"Keyboard self test failed!\n\r");
- goto Done;
- }
+ KeyboardWaitForValue (ConsoleIn, KEYBOARD_8048_RETURN_8042_BAT_SUCCESS);
mWaitForValueTimeOut = KEYBOARD_WAITFORVALUE_TIMEOUT;
diff --git a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
index ca1dd9b2c2..38df3e092d 100644
--- a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
+++ b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
@@ -157,7 +157,7 @@ InstallPs2KeyboardDriver (
#define KEYBOARD_MAX_TRY 256 // 256
#define KEYBOARD_TIMEOUT 65536 // 0.07s
#define KEYBOARD_WAITFORVALUE_TIMEOUT 1000000 // 1s
-#define KEYBOARD_BAT_TIMEOUT 4000000 // 4s
+#define KEYBOARD_BAT_TIMEOUT 1000000 // 1s
#define KEYBOARD_TIMER_INTERVAL 200000 // 0.02s
#define SCANCODE_EXTENDED0 0xE0
#define SCANCODE_EXTENDED1 0xE1
--
2.32.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal
2022-02-11 8:05 [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal Sean Rhodes
@ 2022-02-18 2:16 ` Wu, Hao A
2022-03-16 22:28 ` Sean Rhodes
2022-10-10 8:29 ` Ni, Ray
1 sibling, 1 reply; 10+ messages in thread
From: Wu, Hao A @ 2022-02-18 2:16 UTC (permalink / raw)
To: devel@edk2.groups.io, Rhodes, Sean, Ni, Ray; +Cc: Dong, Guo, Matt DeVillier
Acked-by: Hao A Wu <hao.a.wu@intel.com>
I recommend to get Ray's input for this patch before merging.
Best Regards,
Hao Wu
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean
> Rhodes
> Sent: Friday, February 11, 2022 4:05 PM
> To: devel@edk2.groups.io
> Cc: Dong, Guo <guo.dong@intel.com>; Matt DeVillier
> <matt.devillier@gmail.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Rhodes, Sean <sean@starlabs.systems>
> Subject: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after
> BAT non-fatal
>
> From: Matt DeVillier <matt.devillier@gmail.com>
>
> Recent model Chromebooks only return ACK, but not
> BAT_SUCCESS, which causes hanging and failed ps2k init.
> To mitigate this, make the absence of BAT_SUCCESS reply
> non-fatal, and reduce the no-reply timeout from 4s to 1s.
>
> Tested on google/dracia and purism/librem_14
>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
> Signed-off-by: Sean Rhodes <sean@starlabs.systems>
> ---
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 6 +-----
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 2 +-
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
> b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
> index 77dc226222..6c71355edd 100644
> --- a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
> +++ b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
> @@ -1733,11 +1733,7 @@ InitKeyboard (
> //
>
> mWaitForValueTimeOut = KEYBOARD_BAT_TIMEOUT;
>
>
>
> - Status = KeyboardWaitForValue (ConsoleIn,
> KEYBOARD_8048_RETURN_8042_BAT_SUCCESS);
>
> - if (EFI_ERROR (Status)) {
>
> - KeyboardError (ConsoleIn, L"Keyboard self test failed!\n\r");
>
> - goto Done;
>
> - }
>
> + KeyboardWaitForValue (ConsoleIn,
> KEYBOARD_8048_RETURN_8042_BAT_SUCCESS);
>
>
>
> mWaitForValueTimeOut = KEYBOARD_WAITFORVALUE_TIMEOUT;
>
>
>
> diff --git a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
> b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
> index ca1dd9b2c2..38df3e092d 100644
> --- a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
> +++ b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
> @@ -157,7 +157,7 @@ InstallPs2KeyboardDriver (
> #define KEYBOARD_MAX_TRY 256 // 256
>
> #define KEYBOARD_TIMEOUT 65536 // 0.07s
>
> #define KEYBOARD_WAITFORVALUE_TIMEOUT 1000000 // 1s
>
> -#define KEYBOARD_BAT_TIMEOUT 4000000 // 4s
>
> +#define KEYBOARD_BAT_TIMEOUT 1000000 // 1s
>
> #define KEYBOARD_TIMER_INTERVAL 200000 // 0.02s
>
> #define SCANCODE_EXTENDED0 0xE0
>
> #define SCANCODE_EXTENDED1 0xE1
>
> --
> 2.32.0
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#86611): https://edk2.groups.io/g/devel/message/86611
> Mute This Topic: https://groups.io/mt/89066601/1768737
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [hao.a.wu@intel.com]
> -=-=-=-=-=-=
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal
2022-02-18 2:16 ` [edk2-devel] " Wu, Hao A
@ 2022-03-16 22:28 ` Sean Rhodes
2022-05-17 12:10 ` Sheng Lean Tan
0 siblings, 1 reply; 10+ messages in thread
From: Sean Rhodes @ 2022-03-16 22:28 UTC (permalink / raw)
To: Wu, Hao A; +Cc: devel@edk2.groups.io, Ni, Ray, Dong, Guo, Matt DeVillier
[-- Attachment #1: Type: text/plain, Size: 3548 bytes --]
Hi Ray
Would you be able to review please? :)
Thanks
Sean
On Fri, 18 Feb 2022 at 02:16, Wu, Hao A <hao.a.wu@intel.com> wrote:
> Acked-by: Hao A Wu <hao.a.wu@intel.com>
> I recommend to get Ray's input for this patch before merging.
>
> Best Regards,
> Hao Wu
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean
> > Rhodes
> > Sent: Friday, February 11, 2022 4:05 PM
> > To: devel@edk2.groups.io
> > Cc: Dong, Guo <guo.dong@intel.com>; Matt DeVillier
> > <matt.devillier@gmail.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray
> > <ray.ni@intel.com>; Rhodes, Sean <sean@starlabs.systems>
> > Subject: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after
> > BAT non-fatal
> >
> > From: Matt DeVillier <matt.devillier@gmail.com>
> >
> > Recent model Chromebooks only return ACK, but not
> > BAT_SUCCESS, which causes hanging and failed ps2k init.
> > To mitigate this, make the absence of BAT_SUCCESS reply
> > non-fatal, and reduce the no-reply timeout from 4s to 1s.
> >
> > Tested on google/dracia and purism/librem_14
> >
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
> > Signed-off-by: Sean Rhodes <sean@starlabs.systems>
> > ---
> > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 6 +-----
> > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 2 +-
> > 2 files changed, 2 insertions(+), 6 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
> > b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
> > index 77dc226222..6c71355edd 100644
> > --- a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
> > +++ b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
> > @@ -1733,11 +1733,7 @@ InitKeyboard (
> > //
> >
> > mWaitForValueTimeOut = KEYBOARD_BAT_TIMEOUT;
> >
> >
> >
> > - Status = KeyboardWaitForValue (ConsoleIn,
> > KEYBOARD_8048_RETURN_8042_BAT_SUCCESS);
> >
> > - if (EFI_ERROR (Status)) {
> >
> > - KeyboardError (ConsoleIn, L"Keyboard self test failed!\n\r");
> >
> > - goto Done;
> >
> > - }
> >
> > + KeyboardWaitForValue (ConsoleIn,
> > KEYBOARD_8048_RETURN_8042_BAT_SUCCESS);
> >
> >
> >
> > mWaitForValueTimeOut = KEYBOARD_WAITFORVALUE_TIMEOUT;
> >
> >
> >
> > diff --git a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
> > b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
> > index ca1dd9b2c2..38df3e092d 100644
> > --- a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
> > +++ b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
> > @@ -157,7 +157,7 @@ InstallPs2KeyboardDriver (
> > #define KEYBOARD_MAX_TRY 256 // 256
> >
> > #define KEYBOARD_TIMEOUT 65536 // 0.07s
> >
> > #define KEYBOARD_WAITFORVALUE_TIMEOUT 1000000 // 1s
> >
> > -#define KEYBOARD_BAT_TIMEOUT 4000000 // 4s
> >
> > +#define KEYBOARD_BAT_TIMEOUT 1000000 // 1s
> >
> > #define KEYBOARD_TIMER_INTERVAL 200000 // 0.02s
> >
> > #define SCANCODE_EXTENDED0 0xE0
> >
> > #define SCANCODE_EXTENDED1 0xE1
> >
> > --
> > 2.32.0
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#86611): https://edk2.groups.io/g/devel/message/86611
> > Mute This Topic: https://groups.io/mt/89066601/1768737
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub [hao.a.wu@intel.com]
> > -=-=-=-=-=-=
> >
>
>
[-- Attachment #2: Type: text/html, Size: 6402 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal
2022-03-16 22:28 ` Sean Rhodes
@ 2022-05-17 12:10 ` Sheng Lean Tan
2022-10-10 7:36 ` Sheng Lean Tan
0 siblings, 1 reply; 10+ messages in thread
From: Sheng Lean Tan @ 2022-05-17 12:10 UTC (permalink / raw)
To: Sean Rhodes, devel
[-- Attachment #1: Type: text/plain, Size: 59 bytes --]
Hi Ray,
Could you help to review this?
Thanks,
Sheng
[-- Attachment #2: Type: text/html, Size: 75 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal
2022-05-17 12:10 ` Sheng Lean Tan
@ 2022-10-10 7:36 ` Sheng Lean Tan
0 siblings, 0 replies; 10+ messages in thread
From: Sheng Lean Tan @ 2022-10-10 7:36 UTC (permalink / raw)
To: Sheng Lean Tan, devel
[-- Attachment #1: Type: text/plain, Size: 36 bytes --]
Quick reminder for review, thanks.
[-- Attachment #2: Type: text/html, Size: 36 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal
2022-02-11 8:05 [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal Sean Rhodes
2022-02-18 2:16 ` [edk2-devel] " Wu, Hao A
@ 2022-10-10 8:29 ` Ni, Ray
2022-10-11 8:50 ` Sheng Lean Tan
1 sibling, 1 reply; 10+ messages in thread
From: Ni, Ray @ 2022-10-10 8:29 UTC (permalink / raw)
To: devel@edk2.groups.io, Rhodes, Sean; +Cc: Dong, Guo, Matt DeVillier, Wu, Hao A
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean
> Rhodes
> Sent: Friday, February 11, 2022 4:05 PM
> To: devel@edk2.groups.io
> Cc: Dong, Guo <guo.dong@intel.com>; Matt DeVillier
> <matt.devillier@gmail.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Rhodes, Sean <sean@starlabs.systems>
> Subject: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after
> BAT non-fatal
>
> From: Matt DeVillier <matt.devillier@gmail.com>
>
> Recent model Chromebooks only return ACK, but not
> BAT_SUCCESS, which causes hanging and failed ps2k init.
> To mitigate this, make the absence of BAT_SUCCESS reply
> non-fatal, and reduce the no-reply timeout from 4s to 1s.
>
> Tested on google/dracia and purism/librem_14
>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
> Signed-off-by: Sean Rhodes <sean@starlabs.systems>
> ---
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 6 +-----
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 2 +-
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
> b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
> index 77dc226222..6c71355edd 100644
> --- a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
> +++ b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
> @@ -1733,11 +1733,7 @@ InitKeyboard (
> //
>
> mWaitForValueTimeOut = KEYBOARD_BAT_TIMEOUT;
>
>
>
> - Status = KeyboardWaitForValue (ConsoleIn,
> KEYBOARD_8048_RETURN_8042_BAT_SUCCESS);
>
> - if (EFI_ERROR (Status)) {
>
> - KeyboardError (ConsoleIn, L"Keyboard self test failed!\n\r");
>
> - goto Done;
>
> - }
>
> + KeyboardWaitForValue (ConsoleIn,
> KEYBOARD_8048_RETURN_8042_BAT_SUCCESS);
>
>
>
> mWaitForValueTimeOut = KEYBOARD_WAITFORVALUE_TIMEOUT;
>
>
>
> diff --git a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
> b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
> index ca1dd9b2c2..38df3e092d 100644
> --- a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
> +++ b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
> @@ -157,7 +157,7 @@ InstallPs2KeyboardDriver (
> #define KEYBOARD_MAX_TRY 256 // 256
>
> #define KEYBOARD_TIMEOUT 65536 // 0.07s
>
> #define KEYBOARD_WAITFORVALUE_TIMEOUT 1000000 // 1s
>
> -#define KEYBOARD_BAT_TIMEOUT 4000000 // 4s
>
> +#define KEYBOARD_BAT_TIMEOUT 1000000 // 1s
>
> #define KEYBOARD_TIMER_INTERVAL 200000 // 0.02s
>
> #define SCANCODE_EXTENDED0 0xE0
>
> #define SCANCODE_EXTENDED1 0xE1
>
> --
> 2.32.0
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#86611): https://edk2.groups.io/g/devel/message/86611
> Mute This Topic: https://groups.io/mt/89066601/1712937
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com]
> -=-=-=-=-=-=
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal
2022-10-10 8:29 ` Ni, Ray
@ 2022-10-11 8:50 ` Sheng Lean Tan
2022-10-25 2:48 ` Sheng Lean Tan
0 siblings, 1 reply; 10+ messages in thread
From: Sheng Lean Tan @ 2022-10-11 8:50 UTC (permalink / raw)
To: Ni, Ray, devel
[-- Attachment #1: Type: text/plain, Size: 119 bytes --]
Thanks Ray for the review.
FYI Sean has also push the github PR here:
https://github.com/tianocore/edk2/pull/3389
[-- Attachment #2: Type: text/html, Size: 135 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal
2022-10-11 8:50 ` Sheng Lean Tan
@ 2022-10-25 2:48 ` Sheng Lean Tan
2022-10-25 6:04 ` Ni, Ray
0 siblings, 1 reply; 10+ messages in thread
From: Sheng Lean Tan @ 2022-10-25 2:48 UTC (permalink / raw)
To: devel, sheng.tan
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
Hi Ray please help to merge this if no concerns, thanks.
On Tue 11. Oct 2022 at 01:50, Sheng Lean Tan via groups.io <sheng.tan=
9elements.com@groups.io> wrote:
> Thanks Ray for the review.
> FYI Sean has also push the github PR here:
>
> https://github.com/tianocore/edk2/pull/3389
>
>
> --
Best Regards,
*Lean Sheng Tan*
9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: sheng.tan@9elements.com
Phone: *+49 234 68 94 188 <+492346894188>*
Mobile: *+49 176 76 113842 <+4917676113842>*
Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Eray Bazaar
Data protection information according to Art. 13 GDPR
<https://9elements.com/privacy>
[-- Attachment #2: Type: text/html, Size: 3144 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal
2022-10-25 2:48 ` Sheng Lean Tan
@ 2022-10-25 6:04 ` Ni, Ray
2022-10-25 7:25 ` Sean Rhodes
0 siblings, 1 reply; 10+ messages in thread
From: Ni, Ray @ 2022-10-25 6:04 UTC (permalink / raw)
To: devel@edk2.groups.io, Tan, Lean Sheng
[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]
Can you update the PR to rebase to latest trunk?
Also please modify commit message to capture Reviewed-by tags.
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sheng Lean Tan
Sent: Tuesday, October 25, 2022 10:49 AM
To: devel@edk2.groups.io; Tan, Lean Sheng <sheng.tan@9elements.com>
Subject: Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal
Hi Ray please help to merge this if no concerns, thanks.
On Tue 11. Oct 2022 at 01:50, Sheng Lean Tan via groups.io<http://groups.io> <sheng.tan=9elements.com@groups.io<mailto:9elements.com@groups.io>> wrote:
Thanks Ray for the review.
FYI Sean has also push the github PR here:
https://github.com/tianocore/edk2/pull/3389
--
Best Regards,
Lean Sheng Tan
[http://static.9elements.com/logo-signature.png]
9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: sheng.tan@9elements.com<mailto:sheng.tan@9elements.com>
Phone: +49 234 68 94 188<tel:+492346894188>
Mobile: +49 176 76 113842<tel:+4917676113842>
Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Eray Bazaar
Data protection information according to Art. 13 GDPR<https://9elements.com/privacy>
[-- Attachment #2: Type: text/html, Size: 7465 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal
2022-10-25 6:04 ` Ni, Ray
@ 2022-10-25 7:25 ` Sean Rhodes
0 siblings, 0 replies; 10+ messages in thread
From: Sean Rhodes @ 2022-10-25 7:25 UTC (permalink / raw)
To: devel, ray.ni; +Cc: Tan, Lean Sheng
[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]
Hi Ray
Done
Thank you
On Tue, 25 Oct 2022 at 07:04, Ni, Ray <ray.ni@intel.com> wrote:
> Can you update the PR to rebase to latest trunk?
>
> Also please modify commit message to capture Reviewed-by tags.
>
>
>
> *From:* devel@edk2.groups.io <devel@edk2.groups.io> * On Behalf Of *Sheng
> Lean Tan
> *Sent:* Tuesday, October 25, 2022 10:49 AM
> *To:* devel@edk2.groups.io; Tan, Lean Sheng <sheng.tan@9elements.com>
> *Subject:* Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS
> after BAT non-fatal
>
>
>
> Hi Ray please help to merge this if no concerns, thanks.
>
>
>
> On Tue 11. Oct 2022 at 01:50, Sheng Lean Tan via groups.io <sheng.tan=
> 9elements.com@groups.io> wrote:
>
> Thanks Ray for the review.
> FYI Sean has also push the github PR here:
>
> https://github.com/tianocore/edk2/pull/3389
>
> --
>
> Best Regards,
>
> *Lean Sheng Tan*
>
>
> 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
>
> Email: sheng.tan@9elements.com
>
> Phone: *+49 234 68 94 188 <+492346894188>*
>
> Mobile: *+49 176 76 113842 <+4917676113842>*
>
>
>
> Registered office: Bochum
>
> Commercial register: Amtsgericht Bochum, HRB 17519
>
> Management: Sebastian German, Eray Bazaar
>
>
> Data protection information according to Art. 13 GDPR
> <https://9elements.com/privacy>
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 6819 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-10-25 7:25 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-11 8:05 [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal Sean Rhodes
2022-02-18 2:16 ` [edk2-devel] " Wu, Hao A
2022-03-16 22:28 ` Sean Rhodes
2022-05-17 12:10 ` Sheng Lean Tan
2022-10-10 7:36 ` Sheng Lean Tan
2022-10-10 8:29 ` Ni, Ray
2022-10-11 8:50 ` Sheng Lean Tan
2022-10-25 2:48 ` Sheng Lean Tan
2022-10-25 6:04 ` Ni, Ray
2022-10-25 7:25 ` Sean Rhodes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox