From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [edk2-devel] [RFC PATCH 2/3] MdeModulePkg: Enable forward edge CFI in mem attributes table
To: Ard Biesheuvel <ardb@kernel.org>,devel@edk2.groups.io
From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= <mhaeuser@posteo.de>
X-Originating-Location: Berlin, Land Berlin, DE (104.28.62.40)
X-Originating-Platform: iPhone Safari 16.3
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Fri, 03 Feb 2023 00:25:38 -0800
References: <CAMj1kXGBh6ka9mSYtfkCbz1wScLaZdwP7gDF6Lewk9=4jr=xFQ@mail.gmail.com>
In-Reply-To: <CAMj1kXGBh6ka9mSYtfkCbz1wScLaZdwP7gDF6Lewk9=4jr=xFQ@mail.gmail.com>
Message-ID: <20118.1675412738875218763@groups.io>
Content-Type: multipart/alternative; boundary="vzXe8naKJneh5ikF3dAJ"

--vzXe8naKJneh5ikF3dAJ
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Ard,

Short story: No, TE is not a concern for RT drivers, at least not upstream =
[1].

Long story: Even if a downstream added support for RT relocation=C2=A0itsel=
f, TE images are loaded misaligned by DxeCore, because it lacks a (terrible=
) workaround as done in PeiCore [2]. It doesn=E2=80=99t look like anyone tr=
ied to use them in DXE at all.

Best regards,
Marvin

[1] https://github.com/tianocore/edk2/blob/11f0014c0e3046e3762eac420b760091=
d0cdc063/MdePkg/Library/BasePeCoffLib/BasePeCoff.c#L1759

[2] https://github.com/tianocore/edk2/blob/11f0014c0e3046e3762eac420b760091=
d0cdc063/MdeModulePkg/Core/Pei/Image/Image.c#L412

--vzXe8naKJneh5ikF3dAJ
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

<p>Hi Ard,<br /><br />Short story: No, TE is not a concern for RT drivers, =
at least not upstream [1].<br /><br />Long story: Even if a downstream adde=
d support for RT relocation&nbsp;itself, TE images are loaded misaligned by=
 DxeCore, because it lacks a (terrible) workaround as done in PeiCore [2]. =
It doesn&rsquo;t look like anyone tried to use them in DXE at all.<br /><br=
 />Best regards,<br />Marvin<br /><br />[1]&nbsp;<a style=3D"background-col=
or: #ffffff; -webkit-text-size-adjust: 100%;" href=3D"https://github.com/ti=
anocore/edk2/blob/11f0014c0e3046e3762eac420b760091d0cdc063/MdePkg/Library/B=
asePeCoffLib/BasePeCoff.c#L1759">https://github.com/tianocore/edk2/blob/11f=
0014c0e3046e3762eac420b760091d0cdc063/MdePkg/Library/BasePeCoffLib/BasePeCo=
ff.c#L1759</a><br /><br />[2]&nbsp;<a style=3D"background-color: #ffffff; -=
webkit-text-size-adjust: 100%;" href=3D"https://github.com/tianocore/edk2/b=
lob/11f0014c0e3046e3762eac420b760091d0cdc063/MdeModulePkg/Core/Pei/Image/Im=
age.c#L412">https://github.com/tianocore/edk2/blob/11f0014c0e3046e3762eac42=
0b760091d0cdc063/MdeModulePkg/Core/Pei/Image/Image.c#L412</a></p>

--vzXe8naKJneh5ikF3dAJ--