public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Gary Lin <glin@suse.com>
To: edk2-devel@lists.01.org
Subject: [PATCH v2 00/19] Fix Vlv2TbltDevicePkg gcc build
Date: Fri, 29 Jul 2016 11:25:19 +0800	[thread overview]
Message-ID: <20160729032538.17730-1-glin@suse.com> (raw)

This series amend the build script of Vlv2TbltDevicePkg and fix the
error messages from gcc. I've built the firmware with gcc 6.1.1 on openSUSE
Tumbleweed, and the firmware binary[*] was generated successfully (but not
guaranteed to work).

[*] Vlv2TbltDevicePkg/Stitch/MNW2MAX_X64_D_0093_01_GCC.bin

The patches are also available in my github branch:
https://github.com/lcp/edk2/tree/Vlv2-gcc-fix-v2-platforms

Changes in v2:
1. Instead of removing MDEPKG_NDEBUG completely, amend the CFLAG to define
   MDEPKG_NDEBUG only for the gcc release build.
2. Remove the variable Hob and the related code from IchRcrbInit() in
   Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c.
3. Include UefiBootServicesTableLib.h in PlatformGopPolicy/PlatformGopPolicy.c
   so that we don't have to declare gBS.
4. Rebase the patchset on minnowboard-max-udk2015 of
   https://github.com/tianocore/edk2-platforms.git instead of the master of
   https://github.com/tianocore/edk2.git. Besides the patches of this series,
   minnowboard-max-udk2015 needs a few more commits from edk2.git to make it
   work with gcc6:
   * NetworkPkg: fix ASSERT_EFI_ERROR() typos
   * EdkCompatibilityPkg: fix ASSERT_EFI_ERROR() typos
   * Vlv2TbltDevicePkg: fix ASSERT_EFI_ERROR() typos
   * CryptoPkg/BaseCryptLib: Add missing OpenSSL includes
   * CryptoPkg/OpensslLib: Undefine NO_BUILTIN_VA_FUNCS to fix varargs breakage
   * CryptoPkg: Fix OpenSSL BN wordsize and OPENSSL_SYS_UEFI handling
   For convenience, I merged all the patches before and include openssl 1.0.2h
   update in my branch.

Gary Lin (19):
  Vlv2TbltDevicePkg: Amend the build script
  Vlv2TbltDevicePkg: Only define MDEPKG_NDEBUG for gcc release build
  Vlv2TbltDevicePkg/MultiPlatformLib: Remove the unused variables
  Vlv2TbltDevicePkg/PlatformPei: Remove the unused variable
  Vlv2TbltDevicePkg/PlatformBdsLib: Remove the unused variable
  Vlv2TbltDevicePkg/PlatformInitPei: Remove the unused variables
  Vlv2TbltDevicePkg/PlatformInitPei: Suppress the gcc error message
  Vlv2TbltDevicePkg/AcpiPlatform: Remove unused variables
  Vlv2TbltDevicePkg/AcpiPlatform: Amend the declaration of mGlobalNvsArea
  Vlv2TbltDevicePkg/PlatformGopPolicy: include UefiBootServicesTableLib.h
  Vlv2DeviceRefCodePkg/ValleyView2Soc: Remove the unused code
  Vlv2TbltDevicePkg/FvbRuntimeDxe: Remove unused variables
  Vlv2TbltDevicePkg/PlatformSetupDxe: Remove the unused variables
  Vlv2TbltDevicePkg/VlvPlatformInitDxe: Remove unused variables
  Vlv2TbltDevicePkg/PlatformDxe: Remove the unused variables
  Vlv2TbltDevicePkg/Wpce791: Remove the unused variable
  Vlv2TbltDevicePkg/SmBiosMiscDxe: Remove unused variables
  Vlv2TbltDevicePkg/PpmPolicy: Remove the usage of global variables
  Vlv2TbltDevicePkg/PpmPolicy: Remove the unused variable

 .../SouthCluster/Include/PchAccess.h               |  49 -----
 Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c      |   9 +-
 Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.h      |   2 +-
 Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatformHooks.c |   4 +-
 Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbService.c       |  11 --
 .../MultiPlatformLib/BoardClkGens/BoardClkGens.c   |   5 +-
 .../Library/MultiPlatformLib/MultiPlatformLib.c    |  53 ++---
 .../Library/PlatformBdsLib/BdsPlatform.c           |   3 +-
 Vlv2TbltDevicePkg/PlatformDxe/IchRegTable.c        |   2 -
 Vlv2TbltDevicePkg/PlatformDxe/PciDevice.c          | 214 ++++++++++-----------
 Vlv2TbltDevicePkg/PlatformDxe/Platform.c           |  40 ++--
 .../PlatformGopPolicy/PlatformGopPolicy.c          |   4 +-
 Vlv2TbltDevicePkg/PlatformInitPei/MemoryCallback.c |   2 -
 Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c    |  12 --
 .../PlatformInitPei/PlatformEarlyInit.c            |   1 +
 Vlv2TbltDevicePkg/PlatformPei/MemoryCallback.c     |   9 +-
 Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc            |   2 +-
 .../PlatformSetupDxe/SetupInfoRecords.c            |  41 ++--
 Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.c            |  13 +-
 Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.h            |   6 +-
 .../SmBiosMiscDxe/MiscOemType0x90Function.c        |   5 -
 .../SmBiosMiscDxe/MiscProcessorCacheFunction.c     |   2 -
 .../MiscProcessorInformationFunction.c             |   2 -
 Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c |   4 -
 Vlv2TbltDevicePkg/Wpce791/LpcDriver.c              |   4 -
 Vlv2TbltDevicePkg/bld_vlv.sh                       |  24 ++-
 26 files changed, 203 insertions(+), 320 deletions(-)

-- 
2.9.2



             reply	other threads:[~2016-07-29  3:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-29  3:25 Gary Lin [this message]
2016-07-29  3:25 ` [PATCH v2 01/19] Vlv2TbltDevicePkg: Amend the build script Gary Lin
2016-07-29  3:25 ` [PATCH v2 02/19] Vlv2TbltDevicePkg: Only define MDEPKG_NDEBUG for gcc release build Gary Lin
2016-07-29  7:42   ` Laszlo Ersek
2016-07-29  3:25 ` [PATCH v2 03/19] Vlv2TbltDevicePkg/MultiPlatformLib: Remove the unused variables Gary Lin
2016-07-29  3:25 ` [PATCH v2 04/19] Vlv2TbltDevicePkg/PlatformPei: Remove the unused variable Gary Lin
2016-07-29  3:25 ` [PATCH v2 05/19] Vlv2TbltDevicePkg/PlatformBdsLib: " Gary Lin
2016-07-29  3:25 ` [PATCH v2 06/19] Vlv2TbltDevicePkg/PlatformInitPei: Remove the unused variables Gary Lin
2016-07-29  3:25 ` [PATCH v2 07/19] Vlv2TbltDevicePkg/PlatformInitPei: Suppress the gcc error message Gary Lin
2016-07-29  3:25 ` [PATCH v2 08/19] Vlv2TbltDevicePkg/AcpiPlatform: Remove unused variables Gary Lin
2016-07-29  3:25 ` [PATCH v2 09/19] Vlv2TbltDevicePkg/AcpiPlatform: Amend the declaration of mGlobalNvsArea Gary Lin
2016-07-29  3:25 ` [PATCH v2 10/19] Vlv2TbltDevicePkg/PlatformGopPolicy: include UefiBootServicesTableLib.h Gary Lin
2016-07-29  3:25 ` [PATCH v2 11/19] Vlv2DeviceRefCodePkg/ValleyView2Soc: Remove the unused code Gary Lin
2016-07-29  3:25 ` [PATCH v2 12/19] Vlv2TbltDevicePkg/FvbRuntimeDxe: Remove unused variables Gary Lin
2016-07-29  3:25 ` [PATCH v2 13/19] Vlv2TbltDevicePkg/PlatformSetupDxe: Remove the " Gary Lin
2016-07-29  3:25 ` [PATCH v2 14/19] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Remove " Gary Lin
2016-07-29  3:25 ` [PATCH v2 15/19] Vlv2TbltDevicePkg/PlatformDxe: Remove the " Gary Lin
2016-07-29  3:25 ` [PATCH v2 16/19] Vlv2TbltDevicePkg/Wpce791: Remove the unused variable Gary Lin
2016-07-29  3:25 ` [PATCH v2 17/19] Vlv2TbltDevicePkg/SmBiosMiscDxe: Remove unused variables Gary Lin
2016-07-29  3:25 ` [PATCH v2 18/19] Vlv2TbltDevicePkg/PpmPolicy: Remove the usage of global variables Gary Lin
2016-07-29  3:25 ` [PATCH v2 19/19] Vlv2TbltDevicePkg/PpmPolicy: Remove the unused variable Gary Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160729032538.17730-1-glin@suse.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox