Re: [PATCH 1/2] EmbeddedPkg: make PrePiMemoryAllocationLib a SEC type library

[Leif Lindholm <leif.lindholm@linaro.org>]

On Wed, Aug 03, 2016 at 02:50:59PM +0200, Ard Biesheuvel wrote:
> On 3 August 2016 at 13:21, Laszlo Ersek <lersek@redhat.com> wrote:
> > On 08/03/16 12:00, Ard Biesheuvel wrote:
> >> On 3 August 2016 at 11:56, Laszlo Ersek <lersek@redhat.com> wrote:
> >>> On 08/03/16 10:21, Ard Biesheuvel wrote:
> >>>> This library is only used by the various PrePi implementations, all of
> >>>> which are of type SEC.
> >>>
> >>> You can actually enforce that client module type restriction, by setting
> >>>
> >>>     LIBRARY_CLASS                  = MemoryAllocationLib|SEC
> >>>
> >>> Can you try that, in addition to the MODULE_TYPE change?
> >>>
> >>> Just an idea, of course.
> >>>
> >>
> >> That is a valid point, but it is kind of orthogonal to the issue I am
> >> trying to solve.
> >>
> >> In patch #2, I override the CC flags for SEC and BASE type modules,
> >> but this static library gets build with the PEIM rules in effect, so I
> >> don't really mind if anyone uses this module elsewhere. I could
> >> perhaps simply change the type to BASE as well.
> >
> > Hm, after your explanation, I think your current patch is good.
> >
> > Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> Thanks.
> 
> @Leif: any objections? I'd like to merge this right away, my Jenkins
> job is broken atm due to this.

No objection. We can always change it to BASE in future if that would
appear to make sense.

(for the series)
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Regards,

Leif