From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 95BA41A1E00 for ; Wed, 3 Aug 2016 06:07:42 -0700 (PDT) Received: by mail-wm0-x22f.google.com with SMTP id q128so447647666wma.1 for ; Wed, 03 Aug 2016 06:07:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Knw5tk97jBNEMepyD/1zJw8h2sYuTnYGoW4JNJPvOlg=; b=b1ZeSfN73lcyMkSea1mcEwP8IZFT6TLlFBl2FQG/oNDWl38VOJMR+3zLDCtg+rxu0z 8nNR3YaVO8BIdTWEDTmjLY1/wTzASu2xP/V1RrUCjlJ42wi+2Wh2KMoT+RVbKo04WT6t NdjNt1vfeVODqyujDuT1zJ1nwawHLJ8xWTlHE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Knw5tk97jBNEMepyD/1zJw8h2sYuTnYGoW4JNJPvOlg=; b=dMoV0+L5nmVVvLu7KOjnbsL/piP8ph3u/2bi4MEkzIZMt8XrfsJPH90puVl/kk/lEj xCL+bS6KPzlGL+xbxsfPh1bbe0fhFe6bqOKsmnkB/qpWv5Q6umse/xPIk+eggwWjUx4A WsO4ww4rwgl5b+zBLOY5ijQ7dnOsVLJ2qUf+lqTey6AoBFIZEhjhNZWI3tehLghL/Lhr 7EoJS+z8OrOtweRlt/Zi0MsAgqcHv/XPXhQ5De7SdL4hN+P5/jzhyH+N1xMhQSYpSUb5 E7X7ToyPq1aw6zeW2ZMKGjOYCpoGNqbF6C5fSG5QAC35ZuikA3K3GZHI0bQFyTZdRonV 2/hA== X-Gm-Message-State: AEkoouunxS2QeWDJYp6WMfGh/UFrm5xH8KAKLukKvoGMPbSgSvY9x1MuIiFAXEiYLxJAKGD9 X-Received: by 10.28.57.131 with SMTP id g125mr63984751wma.31.1470229660825; Wed, 03 Aug 2016 06:07:40 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 207sm27085942wmb.7.2016.08.03.06.07.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Aug 2016 06:07:40 -0700 (PDT) Date: Wed, 3 Aug 2016 14:07:38 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: Laszlo Ersek , "edk2-devel@lists.01.org" Message-ID: <20160803130738.GX31760@bivouac.eciton.net> References: <1470212464-28071-1-git-send-email-ard.biesheuvel@linaro.org> <1470212464-28071-2-git-send-email-ard.biesheuvel@linaro.org> <7ab6eb2f-30d8-a3b1-071e-b407c4a9fd3b@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 1/2] EmbeddedPkg: make PrePiMemoryAllocationLib a SEC type library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2016 13:07:43 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 03, 2016 at 02:50:59PM +0200, Ard Biesheuvel wrote: > On 3 August 2016 at 13:21, Laszlo Ersek wrote: > > On 08/03/16 12:00, Ard Biesheuvel wrote: > >> On 3 August 2016 at 11:56, Laszlo Ersek wrote: > >>> On 08/03/16 10:21, Ard Biesheuvel wrote: > >>>> This library is only used by the various PrePi implementations, all of > >>>> which are of type SEC. > >>> > >>> You can actually enforce that client module type restriction, by setting > >>> > >>> LIBRARY_CLASS = MemoryAllocationLib|SEC > >>> > >>> Can you try that, in addition to the MODULE_TYPE change? > >>> > >>> Just an idea, of course. > >>> > >> > >> That is a valid point, but it is kind of orthogonal to the issue I am > >> trying to solve. > >> > >> In patch #2, I override the CC flags for SEC and BASE type modules, > >> but this static library gets build with the PEIM rules in effect, so I > >> don't really mind if anyone uses this module elsewhere. I could > >> perhaps simply change the type to BASE as well. > > > > Hm, after your explanation, I think your current patch is good. > > > > Reviewed-by: Laszlo Ersek > > Thanks. > > @Leif: any objections? I'd like to merge this right away, my Jenkins > job is broken atm due to this. No objection. We can always change it to BASE in future if that would appear to make sense. (for the series) Reviewed-by: Leif Lindholm Regards, Leif