From: Leif Lindholm <leif.lindholm@linaro.org>
To: Daniil Egranov <daniil.egranov@arm.com>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH] PcdBdsLinuxSupport default value
Date: Thu, 4 Aug 2016 14:51:05 +0100 [thread overview]
Message-ID: <20160804135105.GY31760@bivouac.eciton.net> (raw)
In-Reply-To: <1470265848-89949-1-git-send-email-daniil.egranov@arm.com>
On Wed, Aug 03, 2016 at 06:10:48PM -0500, Daniil Egranov wrote:
> The built-in Linux Loader is obsolete and not included in most builds.
> The patch sets the PcdBdsLinuxSupport default value to FALSE and prevents
> ArmBds from looking for built-in Linux Loader by default and ASSERTing
> when it cannot be found. Platforms which still using built-in loader have
> to set this PCD in their platform description file.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Daniil Egranov <daniil.egranov@arm.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed (with a tweak to the subject line), thanks!
> ---
> ArmPlatformPkg/ArmPlatformPkg.dec | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
> index 5864d98..d756fd2 100644
> --- a/ArmPlatformPkg/ArmPlatformPkg.dec
> +++ b/ArmPlatformPkg/ArmPlatformPkg.dec
> @@ -55,7 +55,7 @@
> gArmPlatformTokenSpaceGuid.PcdGopDisableOnExitBootServices|FALSE|BOOLEAN|0x0000003D
>
> # Enable Legacy Linux support in the BDS
> - gArmPlatformTokenSpaceGuid.PcdBdsLinuxSupport|TRUE|BOOLEAN|0x0000002E
> + gArmPlatformTokenSpaceGuid.PcdBdsLinuxSupport|FALSE|BOOLEAN|0x0000002E
>
> [PcdsFixedAtBuild.common]
> gArmPlatformTokenSpaceGuid.PcdCoreCount|1|UINT32|0x00000039
> --
> 2.7.4
>
prev parent reply other threads:[~2016-08-04 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 23:10 [PATCH] PcdBdsLinuxSupport default value Daniil Egranov
2016-08-04 13:51 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804135105.GY31760@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox