From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH 0/6] Move to ASM_FUNC() macro, and clean up some asm as well
Date: Thu, 11 Aug 2016 11:25:59 +0100 [thread overview]
Message-ID: <20160811102559.GW31760@bivouac.eciton.net> (raw)
In-Reply-To: <1470910101-20322-1-git-send-email-ard.biesheuvel@linaro.org>
On Thu, Aug 11, 2016 at 12:08:15PM +0200, Ard Biesheuvel wrote:
> This moves the asm files in OpenPlatformPkg to the new ASM_FUNC() macro,
> which annotates functions in a way that allows the linker to drop code
> that is not actually used anywhere. It is analogous to -ffunction-sections
> for GCC.
>
> Since there are some cargo culted asm patterns that are very clunky and
> inefficient, clean those up as well (i.e., LoadConstantToReg())
For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> Ard Biesheuvel (6):
> Platforms/BeagleBoard: remove unreferenced Sec.inf module
> Platforms/BeagleBoard/BeagleBoardLib: switch to ASM_FUNC() asm macro
> Platforms/Styx: remove unused AmdStyxSecLib
> Platforms/Styx: switch to ASM_FUNC() asm macro
> Platforms/Hisilicon/ArmPlatformLibPv660: switch to ASM_FUNC() asm
> macro
> Platforms/Marvell/Armada70x0Lib: switch to ASM_FUNC() asm macro
>
> Chips/Hisilicon/Library/ArmPlatformLibPv660/AArch64/Helper.S | 44 +--
> Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc | 1 -
> Platforms/AMD/Styx/Library/AmdStyxLib/AArch64/Helper.S | 58 ++--
> Platforms/AMD/Styx/Library/AmdStyxLib/AmdStyxLib.inf | 7 +-
> Platforms/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf | 1 +
> Platforms/AMD/Styx/Library/AmdStyxSecLib/AArch64/GicV3.S | 73 -----
> Platforms/AMD/Styx/Library/AmdStyxSecLib/AArch64/StyxBoot.S | 182 -------------
> Platforms/AMD/Styx/Library/AmdStyxSecLib/AmdStyxSecLib.inf | 50 ----
> Platforms/AMD/Styx/Library/AmdStyxSecLib/StyxSec.c | 96 -------
> Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc | 1 -
> Platforms/Marvell/Armada/Library/Armada70x0Lib/AArch64/ArmPlatformHelper.S | 32 +--
> Platforms/TexasInstruments/BeagleBoard/Library/BeagleBoardLib/BeagleBoardHelper.S | 16 +-
> Platforms/TexasInstruments/BeagleBoard/Sec/Arm/ModuleEntryPoint.S | 85 ------
> Platforms/TexasInstruments/BeagleBoard/Sec/Arm/ModuleEntryPoint.asm | 89 ------
> Platforms/TexasInstruments/BeagleBoard/Sec/Cache.c | 80 ------
> Platforms/TexasInstruments/BeagleBoard/Sec/Clock.c | 70 -----
> Platforms/TexasInstruments/BeagleBoard/Sec/LzmaDecompress.h | 103 -------
> Platforms/TexasInstruments/BeagleBoard/Sec/PadConfiguration.c | 282 --------------------
> Platforms/TexasInstruments/BeagleBoard/Sec/Sec.c | 186 -------------
> Platforms/TexasInstruments/BeagleBoard/Sec/Sec.inf | 74 -----
> 20 files changed, 42 insertions(+), 1488 deletions(-)
> delete mode 100644 Platforms/AMD/Styx/Library/AmdStyxSecLib/AArch64/GicV3.S
> delete mode 100644 Platforms/AMD/Styx/Library/AmdStyxSecLib/AArch64/StyxBoot.S
> delete mode 100644 Platforms/AMD/Styx/Library/AmdStyxSecLib/AmdStyxSecLib.inf
> delete mode 100644 Platforms/AMD/Styx/Library/AmdStyxSecLib/StyxSec.c
> delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/Arm/ModuleEntryPoint.S
> delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/Arm/ModuleEntryPoint.asm
> delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/Cache.c
> delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/Clock.c
> delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/LzmaDecompress.h
> delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/PadConfiguration.c
> delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/Sec.c
> delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/Sec.inf
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2016-08-11 10:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 10:08 [PATCH 0/6] Move to ASM_FUNC() macro, and clean up some asm as well Ard Biesheuvel
2016-08-11 10:08 ` [PATCH 1/6] Platforms/BeagleBoard: remove unreferenced Sec.inf module Ard Biesheuvel
2016-08-11 10:08 ` [PATCH 2/6] Platforms/BeagleBoard/BeagleBoardLib: switch to ASM_FUNC() asm macro Ard Biesheuvel
2016-08-11 10:08 ` [PATCH 3/6] Platforms/Styx: remove unused AmdStyxSecLib Ard Biesheuvel
2016-08-11 10:08 ` [PATCH 4/6] Platforms/Styx: switch to ASM_FUNC() asm macro Ard Biesheuvel
2016-08-11 10:08 ` [PATCH 5/6] Platforms/Hisilicon/ArmPlatformLibPv660: " Ard Biesheuvel
2016-08-11 10:08 ` [PATCH 6/6] Platforms/Marvell/Armada70x0Lib: " Ard Biesheuvel
2016-08-11 10:25 ` Leif Lindholm [this message]
2016-08-11 11:51 ` [PATCH 0/6] Move to ASM_FUNC() macro, and clean up some asm as well Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160811102559.GW31760@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox