From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22a.google.com (mail-wm0-x22a.google.com [IPv6:2a00:1450:400c:c09::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2D6401A1DF5 for ; Thu, 11 Aug 2016 03:26:03 -0700 (PDT) Received: by mail-wm0-x22a.google.com with SMTP id i5so6035055wmg.0 for ; Thu, 11 Aug 2016 03:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6F1zGRFOK15R5Qltdtj333wZO1H8yRVfGQ6sTVPmmtk=; b=DAbWm78aswMhNCZQDUmGLoYKA+/KJuxyOOoStkk8OtS3UWFg5ddYnpzIiH4T9mFbHY NvWtJyUwzE9UY5CqLSDJwOErMTvJqLx0pp5K01VABKzDvT5IGuPKQpReHbtOJwj0gyB9 yqxqw0wnS3kyrCbsl+X+lqI95BQYU0FPmwjsg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6F1zGRFOK15R5Qltdtj333wZO1H8yRVfGQ6sTVPmmtk=; b=ZAZ96x3ffms1T4HFyYoY53CwAafRDaIqBqEP40JfgAa4WXpmvnNPDbmxQrIr1KQ0mW 7NkW6MLE3C0pRfKw8Qv7Vw1R/4f9RAFAEVcbhN0rCg5ps36Wo4eyeJgCEeDRQg0aR5cu amBXchZ8H5cEzsbcbeE3JwpSzvDhodUoVwxLj/Onblp/esTIlg7h86WI7bWySBLA8740 oUQE0evIc4PzLZbqJHPvn3YOAplZkZk0h//F1jnqNOUNlJlukCXcjsWNhwOY9kE/4FA7 E918xXLG94H/V+AXsqWwVbBGqJv8CVR71LuLlWGXpVnUQUNzo9H4d4KiaXCW7oLfoPA7 8GuQ== X-Gm-Message-State: AEkooutB3vpzTMPEMU8ca6sLgTdkhNlvFypv629HLv8+S01dfCvR7xkINyuPyYu/D1fuHcyi X-Received: by 10.194.89.73 with SMTP id bm9mr8655686wjb.76.1470911161681; Thu, 11 Aug 2016 03:26:01 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p23sm2493638wme.8.2016.08.11.03.26.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Aug 2016 03:26:00 -0700 (PDT) Date: Thu, 11 Aug 2016 11:25:59 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20160811102559.GW31760@bivouac.eciton.net> References: <1470910101-20322-1-git-send-email-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <1470910101-20322-1-git-send-email-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 0/6] Move to ASM_FUNC() macro, and clean up some asm as well X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2016 10:26:03 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 11, 2016 at 12:08:15PM +0200, Ard Biesheuvel wrote: > This moves the asm files in OpenPlatformPkg to the new ASM_FUNC() macro, > which annotates functions in a way that allows the linker to drop code > that is not actually used anywhere. It is analogous to -ffunction-sections > for GCC. > > Since there are some cargo culted asm patterns that are very clunky and > inefficient, clean those up as well (i.e., LoadConstantToReg()) For the series: Reviewed-by: Leif Lindholm > Ard Biesheuvel (6): > Platforms/BeagleBoard: remove unreferenced Sec.inf module > Platforms/BeagleBoard/BeagleBoardLib: switch to ASM_FUNC() asm macro > Platforms/Styx: remove unused AmdStyxSecLib > Platforms/Styx: switch to ASM_FUNC() asm macro > Platforms/Hisilicon/ArmPlatformLibPv660: switch to ASM_FUNC() asm > macro > Platforms/Marvell/Armada70x0Lib: switch to ASM_FUNC() asm macro > > Chips/Hisilicon/Library/ArmPlatformLibPv660/AArch64/Helper.S | 44 +-- > Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc | 1 - > Platforms/AMD/Styx/Library/AmdStyxLib/AArch64/Helper.S | 58 ++-- > Platforms/AMD/Styx/Library/AmdStyxLib/AmdStyxLib.inf | 7 +- > Platforms/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf | 1 + > Platforms/AMD/Styx/Library/AmdStyxSecLib/AArch64/GicV3.S | 73 ----- > Platforms/AMD/Styx/Library/AmdStyxSecLib/AArch64/StyxBoot.S | 182 ------------- > Platforms/AMD/Styx/Library/AmdStyxSecLib/AmdStyxSecLib.inf | 50 ---- > Platforms/AMD/Styx/Library/AmdStyxSecLib/StyxSec.c | 96 ------- > Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc | 1 - > Platforms/Marvell/Armada/Library/Armada70x0Lib/AArch64/ArmPlatformHelper.S | 32 +-- > Platforms/TexasInstruments/BeagleBoard/Library/BeagleBoardLib/BeagleBoardHelper.S | 16 +- > Platforms/TexasInstruments/BeagleBoard/Sec/Arm/ModuleEntryPoint.S | 85 ------ > Platforms/TexasInstruments/BeagleBoard/Sec/Arm/ModuleEntryPoint.asm | 89 ------ > Platforms/TexasInstruments/BeagleBoard/Sec/Cache.c | 80 ------ > Platforms/TexasInstruments/BeagleBoard/Sec/Clock.c | 70 ----- > Platforms/TexasInstruments/BeagleBoard/Sec/LzmaDecompress.h | 103 ------- > Platforms/TexasInstruments/BeagleBoard/Sec/PadConfiguration.c | 282 -------------------- > Platforms/TexasInstruments/BeagleBoard/Sec/Sec.c | 186 ------------- > Platforms/TexasInstruments/BeagleBoard/Sec/Sec.inf | 74 ----- > 20 files changed, 42 insertions(+), 1488 deletions(-) > delete mode 100644 Platforms/AMD/Styx/Library/AmdStyxSecLib/AArch64/GicV3.S > delete mode 100644 Platforms/AMD/Styx/Library/AmdStyxSecLib/AArch64/StyxBoot.S > delete mode 100644 Platforms/AMD/Styx/Library/AmdStyxSecLib/AmdStyxSecLib.inf > delete mode 100644 Platforms/AMD/Styx/Library/AmdStyxSecLib/StyxSec.c > delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/Arm/ModuleEntryPoint.S > delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/Arm/ModuleEntryPoint.asm > delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/Cache.c > delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/Clock.c > delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/LzmaDecompress.h > delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/PadConfiguration.c > delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/Sec.c > delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/Sec.inf > > -- > 2.7.4 >