From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22a.google.com (mail-wm0-x22a.google.com [IPv6:2a00:1450:400c:c09::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 42ED11A1DED for ; Thu, 11 Aug 2016 05:18:37 -0700 (PDT) Received: by mail-wm0-x22a.google.com with SMTP id q128so26343533wma.1 for ; Thu, 11 Aug 2016 05:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6Miln2OAaOagkypfOifahAEyCoIHR30+ladws7oX4Uw=; b=dOt9d/ANElX4EK7iwDFaXP2HQVk+NdsRTVPt54Jd5PhkxRCjgyjs8HMUmCoH5GGVRA HxbmWcaG7y74257hxOS5A0Atp709hd2X7pmZeriIhVICQnEgGf9jZBbPdnqsi71sNtBb kgrphUnWSs/kc0zSa0jfdPhhnn0M/Raqbox+s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6Miln2OAaOagkypfOifahAEyCoIHR30+ladws7oX4Uw=; b=SjLIeoUDEFKAcTF34PcT0L+b4yF0cxm5TnR8lx9UKxYCPgTH+zP92fytVNWft03Api imJXtI4dJZLEspErgZvUTimu8pi9qPcj5bEsrcZS9N7N0PBsQVUfq4d11Dt/8eeUyUtj XymNJLYXlj0pQuXOp4ucjYLkaNh48U9OBWYUP30ZjDOD6ml2QvGG6W50kiADPEyDPLld /jUZHm/OY6NKqmGxmRRaYd3hUavMxNxF7bGQ+u3Ee4F/0VYVWCJLFt8+HX4YeOGcWZIQ Jwjsx1W4k7601YHk7LiIxjjoVNpQNpchabx29dkgUDYnodiKMFD7X9lA8h/KXpzMZp+W b5gg== X-Gm-Message-State: AEkoousoMyWRORuQAng+0CWD9Uc4XqwbEAjBgdWpo4TTFGvXIUXfxX4Cl9IshHiHzipzGpIm X-Received: by 10.194.87.101 with SMTP id w5mr11002137wjz.94.1470917915838; Thu, 11 Aug 2016 05:18:35 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d8sm2978816wmi.0.2016.08.11.05.18.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Aug 2016 05:18:35 -0700 (PDT) Date: Thu, 11 Aug 2016 13:18:33 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, liming.gao@intel.com, yonghong.zhu@intel.com Message-ID: <20160811121833.GB31760@bivouac.eciton.net> References: <1470914055-28034-1-git-send-email-ard.biesheuvel@linaro.org> <1470914055-28034-2-git-send-email-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <1470914055-28034-2-git-send-email-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 2/2] BaseTools ARM AARCH64: drop redundant compiler arguments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2016 12:18:37 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 11, 2016 at 01:14:15PM +0200, Ard Biesheuvel wrote: > The ARM and AARCH64 CC_FLAGS definitions include both GCC_ALL_CC_FLAGS > and GCC44_ALL_CC_FLAGS, resulting in many of the compiler arguments > being passed twice. Since the CLANG35 definitions do not refer to > GCC44_ALL_CC_FLAGS, drop the reference for GCCx as well. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > BaseTools/Conf/tools_def.template | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > index 2002c4c0598b..d6d3ed380668 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -4400,7 +4400,7 @@ DEFINE GCC46_X64_DLINK_FLAGS = DEF(GCC45_X64_DLINK_FLAGS) > DEFINE GCC46_X64_DLINK2_FLAGS = DEF(GCC45_X64_DLINK2_FLAGS) > DEFINE GCC46_ASM_FLAGS = DEF(GCC45_ASM_FLAGS) > DEFINE GCC46_ARM_ASM_FLAGS = $(ARCHASM_FLAGS) $(PLATFORM_FLAGS) DEF(GCC_ASM_FLAGS) -mlittle-endian > -DEFINE GCC46_ARM_CC_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) DEF(GCC44_ALL_CC_FLAGS) DEF(GCC_ARM_CC_FLAGS) -fstack-protector -mword-relocations -save-temps > +DEFINE GCC46_ARM_CC_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) DEF(GCC_ARM_CC_FLAGS) -fstack-protector -mword-relocations -save-temps > DEFINE GCC46_ARM_CC_XIPFLAGS = -D__ARM_FEATURE_UNALIGNED=0 > DEFINE GCC46_ARM_DLINK_FLAGS = DEF(GCC_ARM_DLINK_FLAGS) -Wl,--oformat=elf32-littlearm > DEFINE GCC46_ARM_DLINK2_FLAGS = DEF(GCC_DLINK2_FLAGS_COMMON) -Wl,--defsym=PECOFF_HEADER_SIZE=0x220 > @@ -4419,7 +4419,7 @@ DEFINE GCC47_ARM_ASM_FLAGS = DEF(GCC46_ARM_ASM_FLAGS) > DEFINE GCC47_AARCH64_ASM_FLAGS = $(ARCHASM_FLAGS) $(PLATFORM_FLAGS) DEF(GCC_ASM_FLAGS) -mlittle-endian > DEFINE GCC47_ARM_CC_FLAGS = DEF(GCC46_ARM_CC_FLAGS) > DEFINE GCC47_ARM_CC_XIPFLAGS = DEF(GCC_ARM_CC_XIPFLAGS) > -DEFINE GCC47_AARCH64_CC_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) DEF(GCC44_ALL_CC_FLAGS) -mcmodel=large DEF(GCC_AARCH64_CC_FLAGS) -save-temps > +DEFINE GCC47_AARCH64_CC_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -mcmodel=large DEF(GCC_AARCH64_CC_FLAGS) -save-temps > DEFINE GCC47_AARCH64_CC_XIPFLAGS = DEF(GCC_AARCH64_CC_XIPFLAGS) > DEFINE GCC47_ARM_DLINK_FLAGS = DEF(GCC46_ARM_DLINK_FLAGS) > DEFINE GCC47_ARM_DLINK2_FLAGS = DEF(GCC46_ARM_DLINK2_FLAGS) > -- > 2.7.4 >