From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22d.google.com (mail-wm0-x22d.google.com [IPv6:2a00:1450:400c:c09::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 640371A1DF5 for ; Wed, 17 Aug 2016 07:04:27 -0700 (PDT) Received: by mail-wm0-x22d.google.com with SMTP id o80so234810832wme.1 for ; Wed, 17 Aug 2016 07:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kibEw1ksS5GUXs5xhs5ULBE0AfObJimFWgdHKkvkSUU=; b=OX+biYUvUoVbisaI42dQjnT9yWqcToweTdKmRTonk7MZuZhMjRDNKf9oOPcYIm/jQs qsGiS9qebRQnllKuk5Tt0wephb816BpEzKgZx5vYGiP/vZEbSuii4EaaJlpnN9ViiRO8 2Kbcs2a4vPUjgZv+fIeBqRQO0P6OWSJ784K9c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kibEw1ksS5GUXs5xhs5ULBE0AfObJimFWgdHKkvkSUU=; b=PgeslAceKnUbENGvM7Jo88PLDEMUvPSzmutma3VOnDBmPdsfxRw81Zei6KyWRIgJZg HCMFekS3XXx70J3ZVgok6O4yMau4+S2pGNeVazzt/+NYldQ0r+qHxZ9m+xKUGa5D5IDK G8OH71iwaQEJfU8LNsU/bXSEReLZJazVmnXNTdrIoB1oiH9rBhCxd/kxhbuMZscbRkQa oVLDdW8qlrABElATz1fxVYBdq7DEjxGiYPNZ+BuF04+xzFrwkZlO92QYN+NuU7JfzfEH 02EYiBsDgS6KYTAQVKacQm4yhDQPvDDxSM9CgBAwd21ZumjbYInNLnjs2woTpz8SdFh9 4LkQ== X-Gm-Message-State: AEkoousIT2skEYQRCnf+J0a95jpftlhR79PBzQ1FSmgTBZoPzYtu3JN87sRPyeDbdPoN/5Hg X-Received: by 10.28.32.15 with SMTP id g15mr26341961wmg.25.1471442665851; Wed, 17 Aug 2016 07:04:25 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id ub8sm31809778wjc.39.2016.08.17.07.04.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Aug 2016 07:04:25 -0700 (PDT) Date: Wed, 17 Aug 2016 15:04:23 +0100 From: Leif Lindholm To: Laszlo Ersek Cc: Ard Biesheuvel , edk2-devel-01 , Feng Tian , Star Zeng Message-ID: <20160817140422.GG31760@bivouac.eciton.net> References: <1471441502-21873-1-git-send-email-leif.lindholm@linaro.org> <1471441502-21873-3-git-send-email-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 2/2] ArmVirtPkg: enable EBC interpreter for AArch64 QEMU X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2016 14:04:27 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 17, 2016 at 03:55:01PM +0200, Laszlo Ersek wrote: > On 08/17/16 15:47, Ard Biesheuvel wrote: > > On 17 August 2016 at 15:45, Leif Lindholm wrote: > >> Since we now have EBC support for AArch64, enable it by default > >> on the QEMU platform. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.0 > >> Signed-off-by: Leif Lindholm > >> --- > >> ArmVirtPkg/ArmVirtQemu.dsc | 1 + > >> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 5 +++++ > >> 2 files changed, 6 insertions(+) > >> > >> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > >> index 9f88786..fb851e7 100644 > >> --- a/ArmVirtPkg/ArmVirtQemu.dsc > >> +++ b/ArmVirtPkg/ArmVirtQemu.dsc > >> @@ -401,3 +401,4 @@ [Components.AARCH64] > >> > >> NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf > >> } > >> + MdeModulePkg/Universal/EbcDxe/EbcDxe.inf > > > > Please add it to ArmVirtPkg/ArmVirtQemuKernel.dsc as well: > > ArmVirtQemuFvMain.fdf.inc is shared between them. > > > > With that, > > > > Reviewed-by: Ard Biesheuvel > > Any reason for not adding it to the Xen platform as well? Mainly that I'm cluesless as to how to test it. More than happy for this one to be thrown away and replaced by something more useful :) > What kind of modules do we expect to come in EBC? Option ROMs perhaps? > In that case, Xen may indeed be irrelevant here (I have no clue about > adding oproms to emulated or assigned devices under Xen, so I can't make > an argument either way.) If we expect general stuff (for example, even > UEFI_APPLICATION modules) to arrive in EBC, then I think Xen would be a > justified addition. Current test cases include HelloWorld and apparently the FAT driver. Unless we start playing with PCI pass-through, I would expect EBC on the virt platforms would be used mostly for applications/protocols. Regards, Leif > Thanks > Laszlo > > >> diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > >> index ad7037f..0a5b899 100644 > >> --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > >> +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > >> @@ -146,6 +146,11 @@ [FV.FvMain] > >> # > >> INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf > >> INF OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf > >> + > >> + # > >> + # EBC support > >> + # > >> + INF MdeModulePkg/Universal/EbcDxe/EbcDxe.inf > >> !endif > >> > >> # > >> -- > >> 2.1.4 > >> >