public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Achin Gupta <achin.gupta@arm.com>
To: <edk2-devel@lists.01.org>
Subject: Incorrect invocation of SmiManage()?
Date: Fri, 19 Aug 2016 11:00:32 +0100	[thread overview]
Message-ID: <20160819100000.GA31031@e102648.cambridge.arm.com> (raw)

Hi,

The SMM specification (Vol4. PI v1.4) says in the description of the SmiManage()
function:

"
If NULL is passed in HandlerType, then only those registered handler functions
which passed NULL as their HandlerType will be called. If NULL is passed in
HandlerType, then Context should be NULL, CommBuffer should point to an instance
of EFI_SMM_ENTRY_CONTEXT and CommBufferSize should point to the size of that
structure. Type EFI_SMM_ENTRY_CONTEXT is defined in “Related Definitions” below.
"

However, in MdeModulePkg/Core/PiSmmCore/PiSmmCore.c, there is an invocation of
this function as follows for handling an asynchronous SMI source:

"
  //
  // Process Asynchronous SMI sources
  //
  SmiManage (NULL, NULL, NULL, NULL);
"

Is this invocation not in violation of the specification. I guess the root SMI
handler is accessing the EFI_SMM_ENTRY_CONTEXT information directly from the
SMST? I cannot see how this information could be made available to the root
handler otherwise.

Can anyone please confirm/clarify this?

Thanks,
Achin

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.



                 reply	other threads:[~2016-08-19 10:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160819100000.GA31031@e102648.cambridge.arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox