public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ruiyu Ni <ruiyu.ni@intel.com>
To: edk2-devel@lists.01.org
Subject: [PATCH 0/3] Revert "ShellPkg: Fix echo to support displaying special characters"
Date: Tue, 23 Aug 2016 10:56:06 +0800	[thread overview]
Message-ID: <20160823025609.468312-1-ruiyu.ni@intel.com> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 1446 bytes --]

This reverts commit 95fc5a877502a6e6324300eed0136243d359fa96.
The above commit causes several regression of "echo" command:
1. Double quotes are not being stripped from the final text. UEFI Shell 2.2 section 3.4.5 chops out the quotes.
2. Output redirection is not working as expected. Text is being redirected, but the ‘> …’ text should not be.
3. Inconsistent special character handling.  For example, comments with # seem to be parsed out correctly, but handing of ^ is incorrect.
In summary, ‘echo “You are ^#1” > t.txt’ results in the below content in t.txt:
 “You are ^#1” > t.txt

Ruiyu Ni (3):
  Revert "ShellPkg: Fix echo to support displaying special characters"
  Revert "ShellPkg: Add Shell[Get|Set]RawCmdLine to ShellCommandLib"
  Revert "ShellPkg: Move FindFirstCharacter/GetNextParameter to
    ShellCommandLib"

 ShellPkg/Application/Shell/Shell.c                 |  81 +++++---
 ShellPkg/Application/Shell/Shell.h                 |  18 ++
 .../Application/Shell/ShellParametersProtocol.c    | 160 +++++++++++++-
 .../Application/Shell/ShellParametersProtocol.h    |  29 +++
 ShellPkg/Include/Library/ShellCommandLib.h         |  68 ------
 .../UefiShellCommandLib/UefiShellCommandLib.c      | 230 ---------------------
 ShellPkg/Library/UefiShellLevel3CommandsLib/Echo.c | 141 +++++++------
 .../UefiShellLevel3CommandsLib.uni                 |   3 +-
 8 files changed, 339 insertions(+), 391 deletions(-)

-- 
2.9.0.windows.1



             reply	other threads:[~2016-08-23  2:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23  2:56 Ruiyu Ni [this message]
2016-08-23  2:56 ` [PATCH 1/3] Revert "ShellPkg: Fix echo to support displaying special characters" Ruiyu Ni
2016-08-23  2:56 ` [PATCH 2/3] Revert "ShellPkg: Add Shell[Get|Set]RawCmdLine to ShellCommandLib" Ruiyu Ni
2016-08-23  2:56 ` [PATCH 3/3] Revert "ShellPkg: Move FindFirstCharacter/GetNextParameter " Ruiyu Ni
2016-08-23 13:45   ` Shah, Tapan
2016-08-24 15:09   ` Shah, Tapan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160823025609.468312-1-ruiyu.ni@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox