From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 20B3D1A1E13 for ; Mon, 22 Aug 2016 19:56:13 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP; 22 Aug 2016 19:56:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,563,1464678000"; d="scan'208";a="1029809693" Received: from ray-dev.ccr.corp.intel.com ([10.239.9.25]) by fmsmga001.fm.intel.com with ESMTP; 22 Aug 2016 19:56:11 -0700 From: Ruiyu Ni To: edk2-devel@lists.01.org Date: Tue, 23 Aug 2016 10:56:06 +0800 Message-Id: <20160823025609.468312-1-ruiyu.ni@intel.com> X-Mailer: git-send-email 2.9.0.windows.1 MIME-Version: 1.0 Subject: [PATCH 0/3] Revert "ShellPkg: Fix echo to support displaying special characters" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2016 02:56:13 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 95fc5a877502a6e6324300eed0136243d359fa96. The above commit causes several regression of "echo" command: 1. Double quotes are not being stripped from the final text. UEFI Shell 2.2 section 3.4.5 chops out the quotes. 2. Output redirection is not working as expected. Text is being redirected, but the ‘> …’ text should not be. 3. Inconsistent special character handling. For example, comments with # seem to be parsed out correctly, but handing of ^ is incorrect. In summary, ‘echo “You are ^#1” > t.txt’ results in the below content in t.txt: “You are ^#1” > t.txt Ruiyu Ni (3): Revert "ShellPkg: Fix echo to support displaying special characters" Revert "ShellPkg: Add Shell[Get|Set]RawCmdLine to ShellCommandLib" Revert "ShellPkg: Move FindFirstCharacter/GetNextParameter to ShellCommandLib" ShellPkg/Application/Shell/Shell.c | 81 +++++--- ShellPkg/Application/Shell/Shell.h | 18 ++ .../Application/Shell/ShellParametersProtocol.c | 160 +++++++++++++- .../Application/Shell/ShellParametersProtocol.h | 29 +++ ShellPkg/Include/Library/ShellCommandLib.h | 68 ------ .../UefiShellCommandLib/UefiShellCommandLib.c | 230 --------------------- ShellPkg/Library/UefiShellLevel3CommandsLib/Echo.c | 141 +++++++------ .../UefiShellLevel3CommandsLib.uni | 3 +- 8 files changed, 339 insertions(+), 391 deletions(-) -- 2.9.0.windows.1