From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EC2C31A1E45 for ; Wed, 31 Aug 2016 05:48:49 -0700 (PDT) Received: by mail-wm0-x233.google.com with SMTP id c133so31046053wmd.1 for ; Wed, 31 Aug 2016 05:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DhUKl0xFnL76e5ufILGLocvpS98UJz15WAbQNmRatFQ=; b=izwmPgoeiPQNE7HdIV6pBt6Uxixw1+IMnUrW+iGc8EpD7FKtgo3iX9yvE3ljB5S+w9 8FrpQF1b9QIdshMuTqdUQZ5VQkD0ZE64TOfxBKV1h6fwLCsubY46nr69uHFarYjGpwRc 50DnKWeCt+jHS8MUduDhf9mnLjHmqIzxBoHk0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DhUKl0xFnL76e5ufILGLocvpS98UJz15WAbQNmRatFQ=; b=X3Ohe6+6jQo8ajAQlYeFRd9mcMkvO4a895cAsqnCLQ5m/KH+OM1LR7DX9ZgbM4w7Xq NZNraXH/AwqMvL9wkJYpHUZ6j3geKpxalXLqdKZkL6x5sGYZcwCAjjiEy2M7pX2INg6N ApORkgJJn5EgRzRp0QEqwGGpwgEgpY0YVRPURCpJTBQJQEFMKQIhmAyzF0fCoC37B7yC cUDT+TUkl3UpzV/2pkCI90Q+j9AlLedqsp8yOgZ/Cg0wiypk1m8aJbR+dsWsd0b6JbAu iTES1zW/I5yrOfCtvUY0qUOOz8BCMIAcgGydi4ghMAjAHN9YWjZ8eLH/3E45cI0vY1W1 nH+Q== X-Gm-Message-State: AE9vXwN5yNz2UAfAF0XUGk3A79dDwgyuqxFuXs9gsvzbchJXNM2H01uBh7ROoEXt266qjrkd X-Received: by 10.194.148.81 with SMTP id tq17mr9940229wjb.67.1472647727621; Wed, 31 Aug 2016 05:48:47 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id kq2sm44424787wjc.41.2016.08.31.05.48.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Aug 2016 05:48:46 -0700 (PDT) Date: Wed, 31 Aug 2016 13:48:45 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20160831124845.GU4715@bivouac.eciton.net> References: <1472634453-27246-1-git-send-email-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <1472634453-27246-1-git-send-email-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 0/3] ArmPkg: introduce IsZeroGuid() and IsZeroBuffer() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Aug 2016 12:48:50 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 31, 2016 at 10:07:30AM +0100, Ard Biesheuvel wrote: > The BaseMemoryLib API has recently been extended with IsZeroGuid() and > IsZeroBuffer(), so copy the generic implementations into the ArmPkg version > of this library. Maybe this is a good point at which to move these into MdePkg, in the hope that the ARM versions won't be overlooked in future API revisions? / Leif > Ard Biesheuvel (3): > ArmPkg: remove BaseMemoryLibVstm implementation of BaseMemoryLib > ArmPkg/BaseMemoryLibStm: implement new IsZeroGuid() API function > ArmPkg/BaseMemoryLibStm: implement new IsZeroBuffer() API function > > ArmPkg/ArmPkg.dsc | 2 - > ArmPkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf | 1 + > ArmPkg/Library/{BaseMemoryLibVstm/ZeroMemWrapper.c => BaseMemoryLibStm/IsZeroBufferWrapper.c} | 28 ++- > ArmPkg/Library/BaseMemoryLibStm/MemLibGeneric.c | 29 +++ > ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c | 29 +++ > ArmPkg/Library/BaseMemoryLibStm/MemLibInternals.h | 17 ++ > ArmPkg/Library/BaseMemoryLibVstm/Arm/CopyMem.S | 112 --------- > ArmPkg/Library/BaseMemoryLibVstm/Arm/CopyMem.asm | 114 --------- > ArmPkg/Library/BaseMemoryLibVstm/Arm/SetMem.S | 76 ------ > ArmPkg/Library/BaseMemoryLibVstm/Arm/SetMem.asm | 78 ------ > ArmPkg/Library/BaseMemoryLibVstm/BaseMemoryLibVstm.inf | 70 ------ > ArmPkg/Library/BaseMemoryLibVstm/CompareMemWrapper.c | 66 ----- > ArmPkg/Library/BaseMemoryLibVstm/CopyMem.c | 62 ----- > ArmPkg/Library/BaseMemoryLibVstm/CopyMemWrapper.c | 63 ----- > ArmPkg/Library/BaseMemoryLibVstm/MemLibGeneric.c | 264 -------------------- > ArmPkg/Library/BaseMemoryLibVstm/MemLibGuid.c | 132 ---------- > ArmPkg/Library/BaseMemoryLibVstm/MemLibInternals.h | 234 ----------------- > ArmPkg/Library/BaseMemoryLibVstm/ScanMem16Wrapper.c | 67 ----- > ArmPkg/Library/BaseMemoryLibVstm/ScanMem32Wrapper.c | 66 ----- > ArmPkg/Library/BaseMemoryLibVstm/ScanMem64Wrapper.c | 67 ----- > ArmPkg/Library/BaseMemoryLibVstm/ScanMem8Wrapper.c | 99 -------- > ArmPkg/Library/BaseMemoryLibVstm/SetMem.c | 53 ---- > ArmPkg/Library/BaseMemoryLibVstm/SetMem16Wrapper.c | 64 ----- > ArmPkg/Library/BaseMemoryLibVstm/SetMem32Wrapper.c | 64 ----- > ArmPkg/Library/BaseMemoryLibVstm/SetMem64Wrapper.c | 64 ----- > ArmPkg/Library/BaseMemoryLibVstm/SetMemWrapper.c | 91 ------- > 26 files changed, 91 insertions(+), 1921 deletions(-) > rename ArmPkg/Library/{BaseMemoryLibVstm/ZeroMemWrapper.c => BaseMemoryLibStm/IsZeroBufferWrapper.c} (53%) > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/Arm/CopyMem.S > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/Arm/CopyMem.asm > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/Arm/SetMem.S > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/Arm/SetMem.asm > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/BaseMemoryLibVstm.inf > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/CompareMemWrapper.c > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/CopyMem.c > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/CopyMemWrapper.c > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/MemLibGeneric.c > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/MemLibGuid.c > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/MemLibInternals.h > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/ScanMem16Wrapper.c > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/ScanMem32Wrapper.c > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/ScanMem64Wrapper.c > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/ScanMem8Wrapper.c > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/SetMem.c > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/SetMem16Wrapper.c > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/SetMem32Wrapper.c > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/SetMem64Wrapper.c > delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/SetMemWrapper.c > > -- > 2.7.4 >