From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3266F1A1E08 for ; Fri, 2 Sep 2016 06:01:33 -0700 (PDT) Received: by mail-wm0-x22c.google.com with SMTP id 1so30355397wmz.1 for ; Fri, 02 Sep 2016 06:01:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=80ohVuBPtYQsRdz1YaC9PtIdMoMWYj37yM7DKYpvfqw=; b=i3du3hojKspuw5hjgsChd9vOrkQuzBPYjTGDorm3gDdIQueY0E2ZrljKVwBMVaIHau +0y4eHWjjhBj3FHS4Hbx0geaGqJinmAULg6RInzzpliC+74h1Q0WILsTRz8O/JisHi0Y r0RTedcbFPDKH14hLw9XH4IACIGFhux6pBmfA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=80ohVuBPtYQsRdz1YaC9PtIdMoMWYj37yM7DKYpvfqw=; b=EsRKhjSLpY/c761UnX0K0h5qrS5aAq5RxfQG7sQurZTlp8Pf/HfaxRsqZ03PqETbC8 gYDYbDq0rc5A0ICN2GREAzMmSerxx9McAWoaF3d41I6a7ntdtieMHV+ChKeOVtBfOrSz FRmZbUP5ceEt5af/Sx/GoTiHb0DGYI/FzpxWPGvcqJsZSrygGq93oVVmJNt68z3KWCM3 vmAnhaqE0G/QbVtbErQFQ5VtTkQfNrnotRsFRrv4V8TdyZhgzu4IASxrM5bfX91+Ca1g Mx6mcYwq3pJ8fhh/9FQMWBshdYWhJX500v457xsNM0zkmFntgsU5g54MYPNlxTmtad/0 SFyg== X-Gm-Message-State: AE9vXwMIaC8IZSwpx8RH1Dh3rI8CMTYGbXpsyK+zQSSuG0UmjvLiVxepQbmfsNZ8/a28TUCg X-Received: by 10.194.97.129 with SMTP id ea1mr4181596wjb.107.1472821291357; Fri, 02 Sep 2016 06:01:31 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id va3sm10398728wjb.18.2016.09.02.06.01.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Sep 2016 06:01:30 -0700 (PDT) Date: Fri, 2 Sep 2016 14:01:28 +0100 From: Leif Lindholm To: Laszlo Ersek Cc: Ard Biesheuvel , edk2-devel@ml01.01.org Message-ID: <20160902130128.GY4715@bivouac.eciton.net> References: <1472634453-27246-1-git-send-email-ard.biesheuvel@linaro.org> <20160831124845.GU4715@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 0/3] ArmPkg: introduce IsZeroGuid() and IsZeroBuffer() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2016 13:01:33 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 02, 2016 at 01:33:21PM +0200, Laszlo Ersek wrote: > > Maybe this is a good point at which to move these into MdePkg, in the > > hope that the ARM versions won't be overlooked in future API > > revisions? > > I strongly suggest / request that your (good) suggestion be implemented > as a separate endeavor. Moving this stuff into MdePkg is definitely > justified, but it will almost certainly take a good chunk of time. > Meanwhile the ArmVirtQemu builds remain broken. > > I suggest to go ahead and commit patches #2 and #3 as well, and swiftly > at that. And, in order to keep ourselves honest about the longer term > goal, I propose to file a bug for the code movement in our Bugzilla > instance. (The affected packages should be MdePkg + ArmPkg.) Surely if we're doing a panic fix, that should be to revert 313831d-72388f9? If we're not doing that, let's do the thing that will reduce the likelihood of this breaking again. In the interest of speeding this up, I would propose to wait with Ard's latest set (which deserves and is likely to see some more discussion) and go ahead with: - Nuking BaseMemoryLibVstm - Moving BaseMemoryLibStm to MdePkg - Updating platforms in edk2 to reflect new location of BaseMemoryLibStm - Add the new functions to BaseMemoryLibStm This will interfere with nothing else under MdePkg, so could hopefully be merged today anyway. Would that be an acceptable compromise? Regards, Leif > For patches #2 and #3: > > Reviewed-by: Laszlo Ersek > > Can we please commit these patches today? > > Thanks, > Laszlo > > > > > / > > Leif > > > >> Ard Biesheuvel (3): > >> ArmPkg: remove BaseMemoryLibVstm implementation of BaseMemoryLib > >> ArmPkg/BaseMemoryLibStm: implement new IsZeroGuid() API function > >> ArmPkg/BaseMemoryLibStm: implement new IsZeroBuffer() API function > >> > >> ArmPkg/ArmPkg.dsc | 2 - > >> ArmPkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf | 1 + > >> ArmPkg/Library/{BaseMemoryLibVstm/ZeroMemWrapper.c => BaseMemoryLibStm/IsZeroBufferWrapper.c} | 28 ++- > >> ArmPkg/Library/BaseMemoryLibStm/MemLibGeneric.c | 29 +++ > >> ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c | 29 +++ > >> ArmPkg/Library/BaseMemoryLibStm/MemLibInternals.h | 17 ++ > >> ArmPkg/Library/BaseMemoryLibVstm/Arm/CopyMem.S | 112 --------- > >> ArmPkg/Library/BaseMemoryLibVstm/Arm/CopyMem.asm | 114 --------- > >> ArmPkg/Library/BaseMemoryLibVstm/Arm/SetMem.S | 76 ------ > >> ArmPkg/Library/BaseMemoryLibVstm/Arm/SetMem.asm | 78 ------ > >> ArmPkg/Library/BaseMemoryLibVstm/BaseMemoryLibVstm.inf | 70 ------ > >> ArmPkg/Library/BaseMemoryLibVstm/CompareMemWrapper.c | 66 ----- > >> ArmPkg/Library/BaseMemoryLibVstm/CopyMem.c | 62 ----- > >> ArmPkg/Library/BaseMemoryLibVstm/CopyMemWrapper.c | 63 ----- > >> ArmPkg/Library/BaseMemoryLibVstm/MemLibGeneric.c | 264 -------------------- > >> ArmPkg/Library/BaseMemoryLibVstm/MemLibGuid.c | 132 ---------- > >> ArmPkg/Library/BaseMemoryLibVstm/MemLibInternals.h | 234 ----------------- > >> ArmPkg/Library/BaseMemoryLibVstm/ScanMem16Wrapper.c | 67 ----- > >> ArmPkg/Library/BaseMemoryLibVstm/ScanMem32Wrapper.c | 66 ----- > >> ArmPkg/Library/BaseMemoryLibVstm/ScanMem64Wrapper.c | 67 ----- > >> ArmPkg/Library/BaseMemoryLibVstm/ScanMem8Wrapper.c | 99 -------- > >> ArmPkg/Library/BaseMemoryLibVstm/SetMem.c | 53 ---- > >> ArmPkg/Library/BaseMemoryLibVstm/SetMem16Wrapper.c | 64 ----- > >> ArmPkg/Library/BaseMemoryLibVstm/SetMem32Wrapper.c | 64 ----- > >> ArmPkg/Library/BaseMemoryLibVstm/SetMem64Wrapper.c | 64 ----- > >> ArmPkg/Library/BaseMemoryLibVstm/SetMemWrapper.c | 91 ------- > >> 26 files changed, 91 insertions(+), 1921 deletions(-) > >> rename ArmPkg/Library/{BaseMemoryLibVstm/ZeroMemWrapper.c => BaseMemoryLibStm/IsZeroBufferWrapper.c} (53%) > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/Arm/CopyMem.S > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/Arm/CopyMem.asm > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/Arm/SetMem.S > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/Arm/SetMem.asm > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/BaseMemoryLibVstm.inf > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/CompareMemWrapper.c > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/CopyMem.c > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/CopyMemWrapper.c > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/MemLibGeneric.c > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/MemLibGuid.c > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/MemLibInternals.h > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/ScanMem16Wrapper.c > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/ScanMem32Wrapper.c > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/ScanMem64Wrapper.c > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/ScanMem8Wrapper.c > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/SetMem.c > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/SetMem16Wrapper.c > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/SetMem32Wrapper.c > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/SetMem64Wrapper.c > >> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/SetMemWrapper.c > >> > >> -- > >> 2.7.4 > >> > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > > >