From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 55E7E1A1E06 for ; Fri, 2 Sep 2016 07:29:16 -0700 (PDT) Received: by mail-wm0-x22b.google.com with SMTP id 1so34576324wmz.1 for ; Fri, 02 Sep 2016 07:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=b3JKK3PK623okSF+w+Qulu8oRm6vFt6gcE5sCO/2aM4=; b=VVzw8ZQ/z/BCEzyrErAfYgXZobe9mdWob6e8EAQncaWSh6PQfg92JULtcxp4Q+Y9a/ tQWhmQLADfNDCl9s6nrgH6832grI8JLRRispoijH9xcQgQc89zsmSwE/XWFkBVesJiAe gppMYwerdyGRQCDFUU0/tk9GVPCc8ncu2vqrE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=b3JKK3PK623okSF+w+Qulu8oRm6vFt6gcE5sCO/2aM4=; b=EgdAYB33MXBdndRITG3BXtd4HBVZ8wDTqimdeVuHCBOLcMMVtrlZMWsHb2NRHANLys EoEYdqHxRU1an4KyfQwo0HqFwQ7fQhaGYCT7QvZAykZB2UX0rF83kIcy6sm6mlfPiZpo n3Y4pjG9LwZ5GBdHBtb8y30YLhjXQzOlsNuMjihQ5zrxqksIYjdo3uEe8BM75uqFHkYD wMwjs1OhLfCFOeAANZpsj20kq2fTOWVagz5otsJsRjYQ4ZSoiwe/7Lfkj6huCirxY6a2 Rq0OYcYck8H8KHfQJTrjI8Ft6ZGvWY/8GfcMfsg1I+r/tHYoU/IRTdInqeplGLHAHOGP DriQ== X-Gm-Message-State: AE9vXwNyxQxuEUMelHLnNrmSKnGLo7Zx8s3KPkHQaUDTKhhI+VxedGor6fGgBZWbFqBscmy3 X-Received: by 10.28.17.138 with SMTP id 132mr3408671wmr.81.1472826554935; Fri, 02 Sep 2016 07:29:14 -0700 (PDT) Received: from mohikan.mushroom.smurfnet.nu ([2a01:348:6:8735:e23f:49ff:fe6d:9d26]) by smtp.gmail.com with ESMTPSA id q65sm3841609wmd.24.2016.09.02.07.29.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Sep 2016 07:29:13 -0700 (PDT) From: Leif Lindholm To: edk2-devel@lists.01.org Cc: Laszlo Ersek , Michael D Kinney , Liming Gao , Ard Biesheuvel Date: Fri, 2 Sep 2016 15:29:09 +0100 Message-Id: <20160902142912.17297-1-leif.lindholm@linaro.org> X-Mailer: git-send-email 2.9.3 Subject: [PATCH 0/3] MdePkg/Misc: fix Arm BaseMemoryLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2016 14:29:16 -0000 The recent addition, and use, of new functions IsZeroGuid/IsZeroBuffer caused all ARM/AARCH64 platforms to stop building. The oversight was helped by the ARM implementation residing in ArmPkg rather than in MdePkg with all of the others. Move BaseMemoryLibStm across to MdePkg to reduce risk of similar accidents in future, and add the new functions. This set resolves the build issue without affecting any non-ARM platforms, in the interest of getting back to a working master branch. It would be very nice if it could be approved quickly. Ard Biesheuvel (2): MdePkg/BaseMemoryLibStm: implement new IsZeroGuid() API function MdePkg/BaseMemoryLibStm: implement new IsZeroBuffer() API function Leif Lindholm (1): MdePkg/Misc: Move ARM* BaseMemoryLibStm to MdePkg ArmPkg/ArmPkg.dsc | 1 - ArmVirtPkg/ArmVirt.dsc.inc | 2 +- BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +- .../Library/BaseMemoryLibStm/AArch64/CopyMem.c | 0 .../Library/BaseMemoryLibStm/AArch64/SetMem.c | 0 .../Library/BaseMemoryLibStm/Arm/CopyMem.S | 0 .../Library/BaseMemoryLibStm/Arm/CopyMem.asm | 0 .../Library/BaseMemoryLibStm/Arm/SetMem.S | 0 .../Library/BaseMemoryLibStm/Arm/SetMem.asm | 0 .../Library/BaseMemoryLibStm/BaseMemoryLibStm.inf | 1 + .../Library/BaseMemoryLibStm/CompareMemWrapper.c | 0 .../Library/BaseMemoryLibStm/CopyMem.c | 0 .../Library/BaseMemoryLibStm/CopyMemWrapper.c | 0 .../Library/BaseMemoryLibStm/IsZeroBufferWrapper.c | 54 ++++++++++++++++++++++ .../Library/BaseMemoryLibStm/MemLibGeneric.c | 29 ++++++++++++ .../Library/BaseMemoryLibStm/MemLibGuid.c | 29 ++++++++++++ .../Library/BaseMemoryLibStm/MemLibInternals.h | 17 +++++++ .../Library/BaseMemoryLibStm/ScanMem16Wrapper.c | 0 .../Library/BaseMemoryLibStm/ScanMem32Wrapper.c | 0 .../Library/BaseMemoryLibStm/ScanMem64Wrapper.c | 0 .../Library/BaseMemoryLibStm/ScanMem8Wrapper.c | 0 .../Library/BaseMemoryLibStm/SetMem.c | 0 .../Library/BaseMemoryLibStm/SetMem16Wrapper.c | 0 .../Library/BaseMemoryLibStm/SetMem32Wrapper.c | 0 .../Library/BaseMemoryLibStm/SetMem64Wrapper.c | 0 .../Library/BaseMemoryLibStm/SetMemWrapper.c | 0 .../Library/BaseMemoryLibStm/ZeroMemWrapper.c | 0 MdePkg/MdePkg.dsc | 1 + 28 files changed, 133 insertions(+), 3 deletions(-) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/AArch64/CopyMem.c (100%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/AArch64/SetMem.c (100%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.S (100%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.asm (100%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.S (100%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.asm (100%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf (94%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CompareMemWrapper.c (100%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CopyMem.c (100%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CopyMemWrapper.c (100%) create mode 100644 MdePkg/Library/BaseMemoryLibStm/IsZeroBufferWrapper.c rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibGeneric.c (88%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibGuid.c (81%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibInternals.h (90%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem16Wrapper.c (100%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem32Wrapper.c (100%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem64Wrapper.c (100%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem8Wrapper.c (100%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem.c (100%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem16Wrapper.c (100%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem32Wrapper.c (100%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem64Wrapper.c (100%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMemWrapper.c (100%) rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ZeroMemWrapper.c (100%) -- 2.9.3