public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: edk2-devel@lists.01.org
Cc: Laszlo Ersek <lersek@redhat.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH 3/3] MdePkg/BaseMemoryLibStm: implement new IsZeroBuffer() API function
Date: Fri,  2 Sep 2016 15:29:12 +0100	[thread overview]
Message-ID: <20160902142912.17297-4-leif.lindholm@linaro.org> (raw)
In-Reply-To: <20160902142912.17297-1-leif.lindholm@linaro.org>

From: Ard Biesheuvel <ard.biesheuvel@linaro.org>

BaseMemoryLib has recently been extended with an API function
IsZeroBuffer(), so copy the default implementation into BaseMemoryLibStm
as well.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
---
 .../Library/BaseMemoryLibStm/BaseMemoryLibStm.inf  |  1 +
 .../Library/BaseMemoryLibStm/IsZeroBufferWrapper.c | 54 ++++++++++++++++++++++
 MdePkg/Library/BaseMemoryLibStm/MemLibGeneric.c    | 29 ++++++++++++
 MdePkg/Library/BaseMemoryLibStm/MemLibInternals.h  | 17 +++++++
 4 files changed, 101 insertions(+)
 create mode 100644 MdePkg/Library/BaseMemoryLibStm/IsZeroBufferWrapper.c

diff --git a/MdePkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf b/MdePkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf
index eac6cef..30e2459 100644
--- a/MdePkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf
+++ b/MdePkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf
@@ -45,6 +45,7 @@ [Sources.Common]
   SetMem16Wrapper.c
   SetMemWrapper.c
   CopyMemWrapper.c
+  IsZeroBufferWrapper.c
   MemLibGeneric.c
   MemLibGuid.c
   MemLibInternals.h
diff --git a/MdePkg/Library/BaseMemoryLibStm/IsZeroBufferWrapper.c b/MdePkg/Library/BaseMemoryLibStm/IsZeroBufferWrapper.c
new file mode 100644
index 0000000..c42c1aa
--- /dev/null
+++ b/MdePkg/Library/BaseMemoryLibStm/IsZeroBufferWrapper.c
@@ -0,0 +1,54 @@
+/** @file
+  Implementation of IsZeroBuffer function.
+
+  The following BaseMemoryLib instances contain the same copy of this file:
+
+    BaseMemoryLib
+    BaseMemoryLibMmx
+    BaseMemoryLibSse2
+    BaseMemoryLibRepStr
+    BaseMemoryLibOptDxe
+    BaseMemoryLibOptPei
+    PeiMemoryLib
+    UefiMemoryLib
+
+  Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php
+
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+
+**/
+
+#include "MemLibInternals.h"
+
+/**
+  Checks if the contents of a buffer are all zeros.
+
+  This function checks whether the contents of a buffer are all zeros. If the
+  contents are all zeros, return TRUE. Otherwise, return FALSE.
+
+  If Length > 0 and Buffer is NULL, then ASSERT().
+  If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
+
+  @param  Buffer      The pointer to the buffer to be checked.
+  @param  Length      The size of the buffer (in bytes) to be checked.
+
+  @retval TRUE        Contents of the buffer are all zeros.
+  @retval FALSE       Contents of the buffer are not all zeros.
+
+**/
+BOOLEAN
+EFIAPI
+IsZeroBuffer (
+  IN CONST VOID  *Buffer,
+  IN UINTN       Length
+  )
+{
+  ASSERT (!(Buffer == NULL && Length > 0));
+  ASSERT ((Length - 1) <= (MAX_ADDRESS - (UINTN)Buffer));
+  return InternalMemIsZeroBuffer (Buffer, Length);
+}
diff --git a/MdePkg/Library/BaseMemoryLibStm/MemLibGeneric.c b/MdePkg/Library/BaseMemoryLibStm/MemLibGeneric.c
index 54c2701..43fbcb6 100644
--- a/MdePkg/Library/BaseMemoryLibStm/MemLibGeneric.c
+++ b/MdePkg/Library/BaseMemoryLibStm/MemLibGeneric.c
@@ -262,3 +262,32 @@ InternalMemScanMem64 (
   } while (--Length != 0);
   return NULL;
 }
+
+/**
+  Checks whether the contents of a buffer are all zeros.
+
+  @param  Buffer  The pointer to the buffer to be checked.
+  @param  Length  The size of the buffer (in bytes) to be checked.
+
+  @retval TRUE    Contents of the buffer are all zeros.
+  @retval FALSE   Contents of the buffer are not all zeros.
+
+**/
+BOOLEAN
+EFIAPI
+InternalMemIsZeroBuffer (
+  IN CONST VOID  *Buffer,
+  IN UINTN       Length
+  )
+{
+  CONST UINT8 *BufferData;
+  UINTN       Index;
+
+  BufferData = Buffer;
+  for (Index = 0; Index < Length; Index++) {
+    if (BufferData[Index] != 0) {
+      return FALSE;
+    }
+  }
+  return TRUE;
+}
diff --git a/MdePkg/Library/BaseMemoryLibStm/MemLibInternals.h b/MdePkg/Library/BaseMemoryLibStm/MemLibInternals.h
index 10c741f..f7b44f5 100644
--- a/MdePkg/Library/BaseMemoryLibStm/MemLibInternals.h
+++ b/MdePkg/Library/BaseMemoryLibStm/MemLibInternals.h
@@ -231,4 +231,21 @@ InternalMemScanMem64 (
   IN      UINT64                    Value
   );
 
+/**
+  Checks whether the contents of a buffer are all zeros.
+
+  @param  Buffer  The pointer to the buffer to be checked.
+  @param  Length  The size of the buffer (in bytes) to be checked.
+
+  @retval TRUE    Contents of the buffer are all zeros.
+  @retval FALSE   Contents of the buffer are not all zeros.
+
+**/
+BOOLEAN
+EFIAPI
+InternalMemIsZeroBuffer (
+  IN CONST VOID  *Buffer,
+  IN UINTN       Length
+  );
+
 #endif
-- 
2.9.3



  parent reply	other threads:[~2016-09-02 14:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02 14:29 [PATCH 0/3] MdePkg/Misc: fix Arm BaseMemoryLib Leif Lindholm
2016-09-02 14:29 ` [PATCH 1/3] MdePkg/Misc: Move ARM* BaseMemoryLibStm to MdePkg Leif Lindholm
2016-09-02 15:02   ` Ard Biesheuvel
2016-09-02 15:23     ` Leif Lindholm
2016-09-02 16:07       ` Ard Biesheuvel
2016-09-02 18:05         ` Leif Lindholm
2016-09-02 18:11           ` Ard Biesheuvel
2016-09-02 18:32             ` Leif Lindholm
2016-09-02 18:45               ` Ard Biesheuvel
2016-09-02 19:18                 ` Leif Lindholm
2016-09-02 19:24                   ` Laszlo Ersek
2016-09-02 14:29 ` [PATCH 2/3] MdePkg/BaseMemoryLibStm: implement new IsZeroGuid() API function Leif Lindholm
2016-09-02 14:29 ` Leif Lindholm [this message]
2016-09-02 14:48 ` [PATCH 0/3] MdePkg/Misc: fix Arm BaseMemoryLib Laszlo Ersek
2016-09-02 14:53   ` Laszlo Ersek
2016-09-02 16:02     ` Leif Lindholm
2016-09-02 15:49 ` Kinney, Michael D
2016-09-02 15:57   ` Leif Lindholm
2016-09-02 15:59     ` Andrew Fish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160902142912.17297-4-leif.lindholm@linaro.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox