From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AAE6A1A1E06 for ; Fri, 2 Sep 2016 07:40:55 -0700 (PDT) Received: by mail-wm0-x233.google.com with SMTP id w2so33129488wmd.0 for ; Fri, 02 Sep 2016 07:40:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lvRBqM+02M0iOQ3TokmwHsCepzozd2PRMJTvQa+L6as=; b=NUtloKtqWILBt4ofTBeKlWj2plKurrnLCyN2Qcoz5yGC0+Vpg2jCdrYyUwUCu/SMm4 z7iP0F278ie2Gw4pXuCBovrFGyrmJJK0bSUpFhV0jkEnNNrLrhIPjPegRZ1gyaMVlPkh RnMiRQzGzvLI6KtTnqqXa01lEX5VGYAO6fErQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lvRBqM+02M0iOQ3TokmwHsCepzozd2PRMJTvQa+L6as=; b=a3beqyjXoc/49f5iSeFDNsBWtRDRT7ku1SjTb5r1lfZUGDNNSVW70qgszoxOXqmvZm oVT4RVqP7+9vdfJQVwsOUmiMs7CUQhtjnDb3TbxBiHhf4Kytb7GA1YF47XiRedkT7qNM IbHCOR13aN/8Xh15H3nt+PWf1AK4qX0RwIG/58gX/JW67xtpfSy0HlaH9sacV3gSI+vk O3wMBHsMYA04zfe78vrK8FLLXI3MRIfPYCQgJtafTVKpTRATQDGGpn1ELF/sJzHSJsV4 9ZyQZ6VJ2+xVrQ6XCjhO0KaLS9m5UvqLlGcZV7qc60xZbCjqmWc7kFHQrGYkFC5FHmLl FHcw== X-Gm-Message-State: AE9vXwN/rdkg5zHdRdmOiVHL7dLbp28TH+Yhr1N0/hk0Hk834XJhnWBC3i5jdIiLXXbJzxHh X-Received: by 10.28.12.76 with SMTP id 73mr3477639wmm.118.1472827254126; Fri, 02 Sep 2016 07:40:54 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id ka5sm10104368wjb.7.2016.09.02.07.40.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Sep 2016 07:40:53 -0700 (PDT) Date: Fri, 2 Sep 2016 15:40:51 +0100 From: Leif Lindholm To: Laszlo Ersek Cc: Ard Biesheuvel , edk2-devel@ml01.01.org, "Wu, Hao A" , afish@apple.com, michael.d.kinney@intel.com Message-ID: <20160902144051.GA4715@bivouac.eciton.net> References: <1472634453-27246-1-git-send-email-ard.biesheuvel@linaro.org> <20160831124845.GU4715@bivouac.eciton.net> <20160902130128.GY4715@bivouac.eciton.net> <9addcb0f-84ac-b572-3507-85678ece2342@redhat.com> MIME-Version: 1.0 In-Reply-To: <9addcb0f-84ac-b572-3507-85678ece2342@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 0/3] ArmPkg: introduce IsZeroGuid() and IsZeroBuffer() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2016 14:40:56 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 02, 2016 at 04:18:11PM +0200, Laszlo Ersek wrote: > > If we're not doing that, let's do the thing that will reduce the > > likelihood of this breaking again. > > In the interest of speeding this up, I would propose to wait with > > Ard's latest set (which deserves and is likely to see some more > > discussion) and go ahead with: > > - Nuking BaseMemoryLibVstm > > - Moving BaseMemoryLibStm to MdePkg > > - Updating platforms in edk2 to reflect new location of > > BaseMemoryLibStm > > - Add the new functions to BaseMemoryLibStm > > > > This will interfere with nothing else under MdePkg, so could hopefully > > be merged today anyway. > > > > Would that be an acceptable compromise? > > I'd just like the tree to resume building. Doing anything at all under > MdePkg will require MdePkg reviewers to ACK the changes, which will > introduce delays. (Not because those reviewers are very slow, but > because MdePkg changes are always scrutinized, rightfully, with a fine > toothed comb.) So, I've sent out the series I proposed (Ard had already pushed the removal of BaseMemoryLibVstm). The series touches nothing other than moving the BaseMemoryLibStm directory under MdePkg, and adding the new functions to that directory. Hopefully Mike should be able to pick this up today. Otherwise I could always make my first attempt at invoking steward privilege and push myself (but I would want some R-b for that)... On that note - adding Andrew for opinions. Regards, Leif > I wouldn't mind reverting the initial series either, except that it'd > require reviews for MdePkg and SecurityPkg changes... Same problem. > > I'm quite sad that Hao missed grepping the tree for all INF files with > 'LIBRARY_CLASS *= *BaseMemoryLib', when posting the original stuff :( > > $ git grep -l 'LIBRARY_CLASS *= *BaseMemoryLib' -- '*inf' > > ArmPkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf <--------- > MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > MdePkg/Library/BaseMemoryLibMmx/BaseMemoryLibMmx.inf > MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf > MdePkg/Library/BaseMemoryLibOptPei/BaseMemoryLibOptPei.inf > MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf > MdePkg/Library/BaseMemoryLibSse2/BaseMemoryLibSse2.inf > MdePkg/Library/PeiMemoryLib/PeiMemoryLib.inf > MdePkg/Library/UefiMemoryLib/UefiMemoryLib.inf > > Sigh. > > Thanks > Laszlo > > > > > Regards, > > > > Leif > > > >> For patches #2 and #3: > >> > >> Reviewed-by: Laszlo Ersek > >> > >> Can we please commit these patches today? > >> > >> Thanks, > >> Laszlo > >> > >>> > >>> / > >>> Leif > >>> > >>>> Ard Biesheuvel (3): > >>>> ArmPkg: remove BaseMemoryLibVstm implementation of BaseMemoryLib > >>>> ArmPkg/BaseMemoryLibStm: implement new IsZeroGuid() API function > >>>> ArmPkg/BaseMemoryLibStm: implement new IsZeroBuffer() API function > >>>> > >>>> ArmPkg/ArmPkg.dsc | 2 - > >>>> ArmPkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf | 1 + > >>>> ArmPkg/Library/{BaseMemoryLibVstm/ZeroMemWrapper.c => BaseMemoryLibStm/IsZeroBufferWrapper.c} | 28 ++- > >>>> ArmPkg/Library/BaseMemoryLibStm/MemLibGeneric.c | 29 +++ > >>>> ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c | 29 +++ > >>>> ArmPkg/Library/BaseMemoryLibStm/MemLibInternals.h | 17 ++ > >>>> ArmPkg/Library/BaseMemoryLibVstm/Arm/CopyMem.S | 112 --------- > >>>> ArmPkg/Library/BaseMemoryLibVstm/Arm/CopyMem.asm | 114 --------- > >>>> ArmPkg/Library/BaseMemoryLibVstm/Arm/SetMem.S | 76 ------ > >>>> ArmPkg/Library/BaseMemoryLibVstm/Arm/SetMem.asm | 78 ------ > >>>> ArmPkg/Library/BaseMemoryLibVstm/BaseMemoryLibVstm.inf | 70 ------ > >>>> ArmPkg/Library/BaseMemoryLibVstm/CompareMemWrapper.c | 66 ----- > >>>> ArmPkg/Library/BaseMemoryLibVstm/CopyMem.c | 62 ----- > >>>> ArmPkg/Library/BaseMemoryLibVstm/CopyMemWrapper.c | 63 ----- > >>>> ArmPkg/Library/BaseMemoryLibVstm/MemLibGeneric.c | 264 -------------------- > >>>> ArmPkg/Library/BaseMemoryLibVstm/MemLibGuid.c | 132 ---------- > >>>> ArmPkg/Library/BaseMemoryLibVstm/MemLibInternals.h | 234 ----------------- > >>>> ArmPkg/Library/BaseMemoryLibVstm/ScanMem16Wrapper.c | 67 ----- > >>>> ArmPkg/Library/BaseMemoryLibVstm/ScanMem32Wrapper.c | 66 ----- > >>>> ArmPkg/Library/BaseMemoryLibVstm/ScanMem64Wrapper.c | 67 ----- > >>>> ArmPkg/Library/BaseMemoryLibVstm/ScanMem8Wrapper.c | 99 -------- > >>>> ArmPkg/Library/BaseMemoryLibVstm/SetMem.c | 53 ---- > >>>> ArmPkg/Library/BaseMemoryLibVstm/SetMem16Wrapper.c | 64 ----- > >>>> ArmPkg/Library/BaseMemoryLibVstm/SetMem32Wrapper.c | 64 ----- > >>>> ArmPkg/Library/BaseMemoryLibVstm/SetMem64Wrapper.c | 64 ----- > >>>> ArmPkg/Library/BaseMemoryLibVstm/SetMemWrapper.c | 91 ------- > >>>> 26 files changed, 91 insertions(+), 1921 deletions(-) > >>>> rename ArmPkg/Library/{BaseMemoryLibVstm/ZeroMemWrapper.c => BaseMemoryLibStm/IsZeroBufferWrapper.c} (53%) > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/Arm/CopyMem.S > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/Arm/CopyMem.asm > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/Arm/SetMem.S > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/Arm/SetMem.asm > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/BaseMemoryLibVstm.inf > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/CompareMemWrapper.c > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/CopyMem.c > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/CopyMemWrapper.c > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/MemLibGeneric.c > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/MemLibGuid.c > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/MemLibInternals.h > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/ScanMem16Wrapper.c > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/ScanMem32Wrapper.c > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/ScanMem64Wrapper.c > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/ScanMem8Wrapper.c > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/SetMem.c > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/SetMem16Wrapper.c > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/SetMem32Wrapper.c > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/SetMem64Wrapper.c > >>>> delete mode 100644 ArmPkg/Library/BaseMemoryLibVstm/SetMemWrapper.c > >>>> > >>>> -- > >>>> 2.7.4 > >>>> > >>> _______________________________________________ > >>> edk2-devel mailing list > >>> edk2-devel@lists.01.org > >>> https://lists.01.org/mailman/listinfo/edk2-devel > >>> > >> >