From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9BF131A1E06 for ; Fri, 2 Sep 2016 08:57:41 -0700 (PDT) Received: by mail-wm0-x234.google.com with SMTP id 1so38704063wmz.1 for ; Fri, 02 Sep 2016 08:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=woikDK8BZIIhT6rIOdx2tY5MOW0LKaMOWHrAe9d0+nc=; b=XMP3pL69gRatp/uOU65r94QueGZCjTgAx91hwG/uHCH0IPjsg0VVAR43fphBAgZfBV AV9z6ulPfPhHoiOcQr0M/jd1q1FLU/AyXmHbS/rS3FbAWmAOhIuplYYTgKC/Ye4Nyi+2 TQuFZXK8MgO265gU0B3gHSzk0pGnDXzQD+ZMk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=woikDK8BZIIhT6rIOdx2tY5MOW0LKaMOWHrAe9d0+nc=; b=k6dXujkfz+hARxCW+swNQuU0dzGVwYfz1N6OP6evQQvojFPcTPVUOGfxzDKvNeb3u1 T+WrucB2pew4tW9m5E5hXmEOLL56LbJRde2MD16lEZbtDmlrnGHnlj5arUR8Lr+jAQMV lcyBXQkelgcbhvxdUr6erPpzyAm61lzxj4k1XLqOqXUw+l08pFs2nWK17388QCmIMjkC hi5mULMWN6TQewZVNeBZmojZHXqTda+yAwSWZuInI4UTLnmxbELeohy4FobhPDqVFd9b pthtkJfqrSoNlSpGJllcwPoguSayVHBpdW+yhB6khm4wv8bzx7H/SQCpyVhU8bWq6MUH VHEg== X-Gm-Message-State: AE9vXwPuMDcam0KP+dz13UAKcIqf43eqrc8mVCFLtOneaVeQA0DwJdEyPby9C32Xh/W02bzY X-Received: by 10.194.2.10 with SMTP id 10mr2245327wjq.171.1472831859483; Fri, 02 Sep 2016 08:57:39 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e12sm4193884wmg.17.2016.09.02.08.57.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Sep 2016 08:57:38 -0700 (PDT) Date: Fri, 2 Sep 2016 16:57:36 +0100 From: Leif Lindholm To: "Kinney, Michael D" Cc: "edk2-devel@lists.01.org" , Laszlo Ersek , "Gao, Liming" , Ard Biesheuvel Message-ID: <20160902155736.GC4715@bivouac.eciton.net> References: <20160902142912.17297-1-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 0/3] MdePkg/Misc: fix Arm BaseMemoryLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2016 15:57:42 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 02, 2016 at 03:49:03PM +0000, Kinney, Michael D wrote: > Moving this library into MdePkg looks good to me along with the > addition of the 2 new BaseMemoryLib APIs. > > Minor issues in ArmPkg.dsc, ArmPkg.dsc.inc not updating the > Copyright to 2016. Ah, OK, I could fix that before pushing if you'd like? > Reviewed-by: Michael Kinney Many thanks. I'll wait to hear back from Ard before I push. Regards, Leif > Mike > > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Friday, September 2, 2016 7:29 AM > > To: edk2-devel@lists.01.org > > Cc: Laszlo Ersek ; Kinney, Michael D ; > > Gao, Liming ; Ard Biesheuvel > > Subject: [PATCH 0/3] MdePkg/Misc: fix Arm BaseMemoryLib > > > > The recent addition, and use, of new functions IsZeroGuid/IsZeroBuffer > > caused all ARM/AARCH64 platforms to stop building. The oversight was > > helped by the ARM implementation residing in ArmPkg rather than in > > MdePkg with all of the others. > > > > Move BaseMemoryLibStm across to MdePkg to reduce risk of similar > > accidents in future, and add the new functions. > > > > This set resolves the build issue without affecting any non-ARM > > platforms, in the interest of getting back to a working master > > branch. It would be very nice if it could be approved quickly. > > > > Ard Biesheuvel (2): > > MdePkg/BaseMemoryLibStm: implement new IsZeroGuid() API function > > MdePkg/BaseMemoryLibStm: implement new IsZeroBuffer() API function > > > > Leif Lindholm (1): > > MdePkg/Misc: Move ARM* BaseMemoryLibStm to MdePkg > > > > ArmPkg/ArmPkg.dsc | 1 - > > ArmVirtPkg/ArmVirt.dsc.inc | 2 +- > > BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +- > > .../Library/BaseMemoryLibStm/AArch64/CopyMem.c | 0 > > .../Library/BaseMemoryLibStm/AArch64/SetMem.c | 0 > > .../Library/BaseMemoryLibStm/Arm/CopyMem.S | 0 > > .../Library/BaseMemoryLibStm/Arm/CopyMem.asm | 0 > > .../Library/BaseMemoryLibStm/Arm/SetMem.S | 0 > > .../Library/BaseMemoryLibStm/Arm/SetMem.asm | 0 > > .../Library/BaseMemoryLibStm/BaseMemoryLibStm.inf | 1 + > > .../Library/BaseMemoryLibStm/CompareMemWrapper.c | 0 > > .../Library/BaseMemoryLibStm/CopyMem.c | 0 > > .../Library/BaseMemoryLibStm/CopyMemWrapper.c | 0 > > .../Library/BaseMemoryLibStm/IsZeroBufferWrapper.c | 54 ++++++++++++++++++++++ > > .../Library/BaseMemoryLibStm/MemLibGeneric.c | 29 ++++++++++++ > > .../Library/BaseMemoryLibStm/MemLibGuid.c | 29 ++++++++++++ > > .../Library/BaseMemoryLibStm/MemLibInternals.h | 17 +++++++ > > .../Library/BaseMemoryLibStm/ScanMem16Wrapper.c | 0 > > .../Library/BaseMemoryLibStm/ScanMem32Wrapper.c | 0 > > .../Library/BaseMemoryLibStm/ScanMem64Wrapper.c | 0 > > .../Library/BaseMemoryLibStm/ScanMem8Wrapper.c | 0 > > .../Library/BaseMemoryLibStm/SetMem.c | 0 > > .../Library/BaseMemoryLibStm/SetMem16Wrapper.c | 0 > > .../Library/BaseMemoryLibStm/SetMem32Wrapper.c | 0 > > .../Library/BaseMemoryLibStm/SetMem64Wrapper.c | 0 > > .../Library/BaseMemoryLibStm/SetMemWrapper.c | 0 > > .../Library/BaseMemoryLibStm/ZeroMemWrapper.c | 0 > > MdePkg/MdePkg.dsc | 1 + > > 28 files changed, 133 insertions(+), 3 deletions(-) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/AArch64/CopyMem.c (100%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/AArch64/SetMem.c (100%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.S (100%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.asm (100%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.S (100%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.asm (100%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf (94%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CompareMemWrapper.c (100%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CopyMem.c (100%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CopyMemWrapper.c (100%) > > create mode 100644 MdePkg/Library/BaseMemoryLibStm/IsZeroBufferWrapper.c > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibGeneric.c (88%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibGuid.c (81%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibInternals.h (90%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem16Wrapper.c (100%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem32Wrapper.c (100%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem64Wrapper.c (100%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem8Wrapper.c (100%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem.c (100%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem16Wrapper.c (100%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem32Wrapper.c (100%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem64Wrapper.c (100%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMemWrapper.c (100%) > > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ZeroMemWrapper.c (100%) > > > > -- > > 2.9.3 >