From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org, lersek@redhat.com
Subject: Re: [PATCH 0/5] ArmPkg ArmVirtPkg etc: consolidate ArmLib implementations
Date: Mon, 5 Sep 2016 12:21:55 +0100 [thread overview]
Message-ID: <20160905112155.GI4715@bivouac.eciton.net> (raw)
In-Reply-To: <1473073566-1504-1-git-send-email-ard.biesheuvel@linaro.org>
On Mon, Sep 05, 2016 at 12:06:01PM +0100, Ard Biesheuvel wrote:
> Now that the MMU manipulation routines have been moved out of ArmLib into
> ArmMmuLib, we are left with the following implementations of ArmLib which
> are all identical except for the fact that they target either ARM or AARCH64
> but not both.
>
> ArmPkg/Library/ArmLib/AArch64/AArch64Lib.inf
> ArmPkg/Library/ArmLib/AArch64/AArch64LibPei.inf
> ArmPkg/Library/ArmLib/AArch64/AArch64LibPrePi.inf
> ArmPkg/Library/ArmLib/AArch64/AArch64LibSec.inf
> ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf
> ArmPkg/Library/ArmLib/ArmV7/ArmV7LibPrePi.inf
> ArmPkg/Library/ArmLib/ArmV7/ArmV7LibSec.inf
>
> So implement a new version 'ArmBaseLib' which does target both ARM and AARCH64,
> and replace all ArmLib references with ArmBaseLib.
>
> NOTE: this requires changes for existing out of tree users of ArmLib
I like this one. However, given the invasiveness, I would quite like
to see a couple of Tested-by:s for out-of-tree platforms. With that:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> Ard Biesheuvel (5):
> ArmPkg/ArmLib: remove NullArmLib
> ArmPkg/ArmLib: introduce ArmBaseLib
> ArmVirtPkg: remove all ArmLib resolutions with ArmBaseLib
> BeagleBoardPkg EmbeddedPkg Omap35xxPkg: move to ArmBaseLib
> ArmPkg/ArmLib: remove all ArmLib flavors except ArmBaseLib
>
> ArmPkg/ArmPkg.dsc | 14 +--
> ArmPkg/Library/ArmLib/AArch64/AArch64LibPei.inf | 43 -------
> ArmPkg/Library/ArmLib/AArch64/AArch64LibPrePi.inf | 44 --------
> ArmPkg/Library/ArmLib/AArch64/AArch64LibSec.inf | 40 -------
> ArmPkg/Library/ArmLib/AArch64/AArch64PeiLibConstructor.c | 75 -------------
> ArmPkg/Library/ArmLib/{AArch64/AArch64Lib.inf => ArmBaseLib.inf} | 39 +++++--
> ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf | 52 ---------
> ArmPkg/Library/ArmLib/ArmV7/ArmV7LibPrePi.inf | 52 ---------
> ArmPkg/Library/ArmLib/ArmV7/ArmV7LibSec.inf | 44 --------
> ArmPkg/Library/ArmLib/Null/NullArmLib.c | 117 --------------------
> ArmPkg/Library/ArmLib/Null/NullArmLib.inf | 41 -------
> ArmVirtPkg/ArmVirtQemu.dsc | 9 +-
> ArmVirtPkg/ArmVirtQemuKernel.dsc | 6 +-
> ArmVirtPkg/ArmVirtXen.dsc | 12 +-
> BeagleBoardPkg/BeagleBoardPkg.dsc | 4 +-
> EmbeddedPkg/EmbeddedPkg.dsc | 7 +-
> Omap35xxPkg/Omap35xxPkg.dsc | 2 +-
> 17 files changed, 36 insertions(+), 565 deletions(-)
> delete mode 100644 ArmPkg/Library/ArmLib/AArch64/AArch64LibPei.inf
> delete mode 100644 ArmPkg/Library/ArmLib/AArch64/AArch64LibPrePi.inf
> delete mode 100644 ArmPkg/Library/ArmLib/AArch64/AArch64LibSec.inf
> delete mode 100644 ArmPkg/Library/ArmLib/AArch64/AArch64PeiLibConstructor.c
> rename ArmPkg/Library/ArmLib/{AArch64/AArch64Lib.inf => ArmBaseLib.inf} (50%)
> delete mode 100644 ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf
> delete mode 100644 ArmPkg/Library/ArmLib/ArmV7/ArmV7LibPrePi.inf
> delete mode 100644 ArmPkg/Library/ArmLib/ArmV7/ArmV7LibSec.inf
> delete mode 100644 ArmPkg/Library/ArmLib/Null/NullArmLib.c
> delete mode 100644 ArmPkg/Library/ArmLib/Null/NullArmLib.inf
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2016-09-05 11:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 11:06 [PATCH 0/5] ArmPkg ArmVirtPkg etc: consolidate ArmLib implementations Ard Biesheuvel
2016-09-05 11:06 ` [PATCH 1/5] ArmPkg/ArmLib: remove NullArmLib Ard Biesheuvel
2016-09-05 11:06 ` [PATCH 2/5] ArmPkg/ArmLib: introduce ArmBaseLib Ard Biesheuvel
2016-09-05 11:06 ` [PATCH 3/5] ArmVirtPkg: remove all ArmLib resolutions with ArmBaseLib Ard Biesheuvel
2016-09-08 8:19 ` Ard Biesheuvel
2016-09-08 8:49 ` Laszlo Ersek
2016-09-08 8:50 ` Ard Biesheuvel
2016-09-05 11:06 ` [PATCH 4/5] BeagleBoardPkg EmbeddedPkg Omap35xxPkg: move to ArmBaseLib Ard Biesheuvel
2016-09-05 11:06 ` [PATCH 5/5] ArmPkg/ArmLib: remove all ArmLib flavors except ArmBaseLib Ard Biesheuvel
2016-09-05 11:21 ` Leif Lindholm [this message]
2016-09-08 9:41 ` [PATCH 0/5] ArmPkg ArmVirtPkg etc: consolidate ArmLib implementations Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905112155.GI4715@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox