From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 074E31A1E29 for ; Mon, 5 Sep 2016 04:21:59 -0700 (PDT) Received: by mail-wm0-x22f.google.com with SMTP id b187so14904676wme.1 for ; Mon, 05 Sep 2016 04:21:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3ebp/1g1sdhJpIerLYZ1UxfOQXJ/2r1rq9rxcKOQTYE=; b=BYutcZ1jyjxzlohVjPPLgtowUvPCzXKZKlrIC4Gn8BJLeziGzgEKJ9zogGOKNmjB5r 3HrX39h13j0/G3acB31a65vdgUYLdXcGEZleWsNDP1WbI515fRvs4nAL8QyRYdQ0s56e Ypu+u0/miVku2/n2f8VzDsRpwx4EY9Ngn6DNc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3ebp/1g1sdhJpIerLYZ1UxfOQXJ/2r1rq9rxcKOQTYE=; b=JnmpjIttLP7p2z5qtbqTNLD0zMnSCK0My0a6qfWsutjZVstDTIpuk7zlLySeaKHk1e Dsd7ZXTeYQsdTl54ZIEBN6GmHT5ir88OK8xwDU0YgmKO+jEuJSzwTO9JWQnpevSPwwON vAybNkqSCs4PGaoX/NKhh2kdBfpaEyDykrtrmY/Fex1AG7Z3OT29OsWYx8FB+dkklCJ5 L2pgHsxvQYEEKcTSEShJCt8Is1aVZIS5I0lLtW04KUHbxiAkKZVjaS1vaR3PxvK0Sruz ZjtE4FVhshNw7FFR9cQFTsYxrubgjbnVboVDTfZYcjI1ygkGDZX3SKkxPvKSY5atur/P N2Uw== X-Gm-Message-State: AE9vXwOZU/7yIqhUz3FN6QZtL+NK+wpiNJTMCvovH8jpIrnYxqnlgsm7wNncQ+EzXzBEedDI X-Received: by 10.28.17.138 with SMTP id 132mr14221105wmr.81.1473074517614; Mon, 05 Sep 2016 04:21:57 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v2sm251651wmf.3.2016.09.05.04.21.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Sep 2016 04:21:56 -0700 (PDT) Date: Mon, 5 Sep 2016 12:21:55 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, lersek@redhat.com Message-ID: <20160905112155.GI4715@bivouac.eciton.net> References: <1473073566-1504-1-git-send-email-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <1473073566-1504-1-git-send-email-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 0/5] ArmPkg ArmVirtPkg etc: consolidate ArmLib implementations X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Sep 2016 11:21:59 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Sep 05, 2016 at 12:06:01PM +0100, Ard Biesheuvel wrote: > Now that the MMU manipulation routines have been moved out of ArmLib into > ArmMmuLib, we are left with the following implementations of ArmLib which > are all identical except for the fact that they target either ARM or AARCH64 > but not both. > > ArmPkg/Library/ArmLib/AArch64/AArch64Lib.inf > ArmPkg/Library/ArmLib/AArch64/AArch64LibPei.inf > ArmPkg/Library/ArmLib/AArch64/AArch64LibPrePi.inf > ArmPkg/Library/ArmLib/AArch64/AArch64LibSec.inf > ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf > ArmPkg/Library/ArmLib/ArmV7/ArmV7LibPrePi.inf > ArmPkg/Library/ArmLib/ArmV7/ArmV7LibSec.inf > > So implement a new version 'ArmBaseLib' which does target both ARM and AARCH64, > and replace all ArmLib references with ArmBaseLib. > > NOTE: this requires changes for existing out of tree users of ArmLib I like this one. However, given the invasiveness, I would quite like to see a couple of Tested-by:s for out-of-tree platforms. With that: Reviewed-by: Leif Lindholm > Ard Biesheuvel (5): > ArmPkg/ArmLib: remove NullArmLib > ArmPkg/ArmLib: introduce ArmBaseLib > ArmVirtPkg: remove all ArmLib resolutions with ArmBaseLib > BeagleBoardPkg EmbeddedPkg Omap35xxPkg: move to ArmBaseLib > ArmPkg/ArmLib: remove all ArmLib flavors except ArmBaseLib > > ArmPkg/ArmPkg.dsc | 14 +-- > ArmPkg/Library/ArmLib/AArch64/AArch64LibPei.inf | 43 ------- > ArmPkg/Library/ArmLib/AArch64/AArch64LibPrePi.inf | 44 -------- > ArmPkg/Library/ArmLib/AArch64/AArch64LibSec.inf | 40 ------- > ArmPkg/Library/ArmLib/AArch64/AArch64PeiLibConstructor.c | 75 ------------- > ArmPkg/Library/ArmLib/{AArch64/AArch64Lib.inf => ArmBaseLib.inf} | 39 +++++-- > ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf | 52 --------- > ArmPkg/Library/ArmLib/ArmV7/ArmV7LibPrePi.inf | 52 --------- > ArmPkg/Library/ArmLib/ArmV7/ArmV7LibSec.inf | 44 -------- > ArmPkg/Library/ArmLib/Null/NullArmLib.c | 117 -------------------- > ArmPkg/Library/ArmLib/Null/NullArmLib.inf | 41 ------- > ArmVirtPkg/ArmVirtQemu.dsc | 9 +- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 6 +- > ArmVirtPkg/ArmVirtXen.dsc | 12 +- > BeagleBoardPkg/BeagleBoardPkg.dsc | 4 +- > EmbeddedPkg/EmbeddedPkg.dsc | 7 +- > Omap35xxPkg/Omap35xxPkg.dsc | 2 +- > 17 files changed, 36 insertions(+), 565 deletions(-) > delete mode 100644 ArmPkg/Library/ArmLib/AArch64/AArch64LibPei.inf > delete mode 100644 ArmPkg/Library/ArmLib/AArch64/AArch64LibPrePi.inf > delete mode 100644 ArmPkg/Library/ArmLib/AArch64/AArch64LibSec.inf > delete mode 100644 ArmPkg/Library/ArmLib/AArch64/AArch64PeiLibConstructor.c > rename ArmPkg/Library/ArmLib/{AArch64/AArch64Lib.inf => ArmBaseLib.inf} (50%) > delete mode 100644 ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf > delete mode 100644 ArmPkg/Library/ArmLib/ArmV7/ArmV7LibPrePi.inf > delete mode 100644 ArmPkg/Library/ArmLib/ArmV7/ArmV7LibSec.inf > delete mode 100644 ArmPkg/Library/ArmLib/Null/NullArmLib.c > delete mode 100644 ArmPkg/Library/ArmLib/Null/NullArmLib.inf > > -- > 2.7.4 >