From: Laszlo Ersek <lersek@redhat.com>
To: edk2-devel@ml01.01.org
Cc: Jaben Carsey <jaben.carsey@intel.com>,
Ruiyu Ni <ruiyu.ni@intel.com>, Tapan Shah <tapandshah@hpe.com>
Subject: [PATCH 1/2] ShellPkg/UefiHandleParsingLib: fix IN/OUT notation in child ctrlr parsing
Date: Thu, 8 Sep 2016 18:14:13 +0200 [thread overview]
Message-ID: <20160908161414.3143-2-lersek@redhat.com> (raw)
In-Reply-To: <20160908161414.3143-1-lersek@redhat.com>
"MatchingHandleCount" is an output parameter of
ParseHandleDatabaseForChildControllers().
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Tapan Shah <tapandshah@hpe.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
ShellPkg/Include/Library/HandleParsingLib.h | 4 ++--
ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/ShellPkg/Include/Library/HandleParsingLib.h b/ShellPkg/Include/Library/HandleParsingLib.h
index 441f65fffe83..79dcc9cc5a55 100644
--- a/ShellPkg/Include/Library/HandleParsingLib.h
+++ b/ShellPkg/Include/Library/HandleParsingLib.h
@@ -303,24 +303,24 @@ ParseHandleDatabaseForChildDevices(
);
/**
Gets handles for any child controllers of the passed in controller.
@param[in] ControllerHandle The handle of the "parent controller".
- @param[in] MatchingHandleCount The pointer to the number of handles in
+ @param[out] MatchingHandleCount The pointer to the number of handles in
MatchingHandleBuffer on return.
@param[out] MatchingHandleBuffer The buffer containing handles on a successful
return.
@retval EFI_SUCCESS The operation was successful.
@sa ParseHandleDatabaseByRelationship
**/
EFI_STATUS
EFIAPI
ParseHandleDatabaseForChildControllers(
IN CONST EFI_HANDLE ControllerHandle,
- IN UINTN *MatchingHandleCount,
+ OUT UINTN *MatchingHandleCount,
OUT EFI_HANDLE **MatchingHandleBuffer OPTIONAL
);
/**
Function to retrieve the human-friendly index of a given handle. If the handle
diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
index 3fb55df8cc14..e11a3ccceab3 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
@@ -2720,25 +2720,25 @@ ParseHandleDatabaseByRelationship (
}
/**
Gets handles for any child controllers of the passed in controller.
@param[in] ControllerHandle The handle of the "parent controller"
- @param[in] MatchingHandleCount Pointer to the number of handles in
+ @param[out] MatchingHandleCount Pointer to the number of handles in
MatchingHandleBuffer on return.
@param[out] MatchingHandleBuffer Buffer containing handles on a successful
return.
@retval EFI_SUCCESS The operation was sucessful.
**/
EFI_STATUS
EFIAPI
ParseHandleDatabaseForChildControllers(
IN CONST EFI_HANDLE ControllerHandle,
- IN UINTN *MatchingHandleCount,
+ OUT UINTN *MatchingHandleCount,
OUT EFI_HANDLE **MatchingHandleBuffer OPTIONAL
)
{
EFI_STATUS Status;
UINTN HandleIndex;
UINTN DriverBindingHandleCount;
--
2.9.2
next prev parent reply other threads:[~2016-09-08 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 16:14 [PATCH 0/2] ShellPkg: fix assertion failure encountered with "devtree" and "dh -d -v" Laszlo Ersek
2016-09-08 16:14 ` Laszlo Ersek [this message]
2016-09-08 16:14 ` [PATCH 2/2] ShellPkg/UefiHandleParsingLib: fix retval for empty child controller array Laszlo Ersek
2016-09-08 16:37 ` [PATCH 0/2] ShellPkg: fix assertion failure encountered with "devtree" and "dh -d -v" Carsey, Jaben
2016-09-08 17:08 ` Shah, Tapan
2016-09-08 17:09 ` Shah, Tapan
2016-09-08 18:35 ` Laszlo Ersek
2016-09-08 18:46 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908161414.3143-2-lersek@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox