From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A20451A1E4F for ; Thu, 8 Sep 2016 09:14:23 -0700 (PDT) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2A23C6AEF; Thu, 8 Sep 2016 16:14:22 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-57.phx2.redhat.com [10.3.116.57]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u88GEIF4030512; Thu, 8 Sep 2016 12:14:20 -0400 From: Laszlo Ersek To: edk2-devel@ml01.01.org Cc: Jaben Carsey , Ruiyu Ni , Tapan Shah Date: Thu, 8 Sep 2016 18:14:13 +0200 Message-Id: <20160908161414.3143-2-lersek@redhat.com> In-Reply-To: <20160908161414.3143-1-lersek@redhat.com> References: <20160908161414.3143-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 08 Sep 2016 16:14:22 +0000 (UTC) Subject: [PATCH 1/2] ShellPkg/UefiHandleParsingLib: fix IN/OUT notation in child ctrlr parsing X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 16:14:24 -0000 "MatchingHandleCount" is an output parameter of ParseHandleDatabaseForChildControllers(). Cc: Jaben Carsey Cc: Ruiyu Ni Cc: Tapan Shah Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- ShellPkg/Include/Library/HandleParsingLib.h | 4 ++-- ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ShellPkg/Include/Library/HandleParsingLib.h b/ShellPkg/Include/Library/HandleParsingLib.h index 441f65fffe83..79dcc9cc5a55 100644 --- a/ShellPkg/Include/Library/HandleParsingLib.h +++ b/ShellPkg/Include/Library/HandleParsingLib.h @@ -303,24 +303,24 @@ ParseHandleDatabaseForChildDevices( ); /** Gets handles for any child controllers of the passed in controller. @param[in] ControllerHandle The handle of the "parent controller". - @param[in] MatchingHandleCount The pointer to the number of handles in + @param[out] MatchingHandleCount The pointer to the number of handles in MatchingHandleBuffer on return. @param[out] MatchingHandleBuffer The buffer containing handles on a successful return. @retval EFI_SUCCESS The operation was successful. @sa ParseHandleDatabaseByRelationship **/ EFI_STATUS EFIAPI ParseHandleDatabaseForChildControllers( IN CONST EFI_HANDLE ControllerHandle, - IN UINTN *MatchingHandleCount, + OUT UINTN *MatchingHandleCount, OUT EFI_HANDLE **MatchingHandleBuffer OPTIONAL ); /** Function to retrieve the human-friendly index of a given handle. If the handle diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c index 3fb55df8cc14..e11a3ccceab3 100644 --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c @@ -2720,25 +2720,25 @@ ParseHandleDatabaseByRelationship ( } /** Gets handles for any child controllers of the passed in controller. @param[in] ControllerHandle The handle of the "parent controller" - @param[in] MatchingHandleCount Pointer to the number of handles in + @param[out] MatchingHandleCount Pointer to the number of handles in MatchingHandleBuffer on return. @param[out] MatchingHandleBuffer Buffer containing handles on a successful return. @retval EFI_SUCCESS The operation was sucessful. **/ EFI_STATUS EFIAPI ParseHandleDatabaseForChildControllers( IN CONST EFI_HANDLE ControllerHandle, - IN UINTN *MatchingHandleCount, + OUT UINTN *MatchingHandleCount, OUT EFI_HANDLE **MatchingHandleBuffer OPTIONAL ) { EFI_STATUS Status; UINTN HandleIndex; UINTN DriverBindingHandleCount; -- 2.9.2