From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH] MdePkg/BaseLib AARCH64: terminate stack frame list on stack switch
Date: Fri, 9 Sep 2016 13:10:19 +0100 [thread overview]
Message-ID: <20160909121019.GO16080@bivouac.eciton.net> (raw)
In-Reply-To: <CAKv+Gu_xJk=8hrpP405+Q3iR5Rjj34xjhCmzS2ENt6jJSOosSQ@mail.gmail.com>
On Fri, Sep 09, 2016 at 01:03:59PM +0100, Ard Biesheuvel wrote:
> On 9 September 2016 at 12:18, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > On Fri, Sep 09, 2016 at 08:21:26AM +0100, Ard Biesheuvel wrote:
> >> When switching to the DXE phase stack, set the frame pointer to zero so
> >> that code walking the stack frame will not try to access stack frames\
> >
> > Trailing '\'.
> >
> >> belonging to the old stack.
> >
> > Do you mean that code will check for zero and stop processing, or that
> > it will be accessing rubbish instead of parsing a valid-looking frame?
>
> I don't understand this question. If it is zero, it will stop
> processing. If it is not zero, it will proceed, and potentially
> traverse stack frames in memory that is now owned by someone else.
Which was exactly what I was asking :)
So no need to change (but drop the '\').
/
Leif
prev parent reply other threads:[~2016-09-09 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 7:21 [PATCH] MdePkg/BaseLib AARCH64: terminate stack frame list on stack switch Ard Biesheuvel
2016-09-09 11:18 ` Leif Lindholm
2016-09-09 12:03 ` Ard Biesheuvel
2016-09-09 12:10 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909121019.GO16080@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox