public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: edk2-devel-01 <edk2-devel@ml01.01.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>,
	Thomas Huth <thuth@redhat.com>
Subject: [PATCH 0/3] OvmfPkg: cosmetic fixes
Date: Sat, 10 Sep 2016 01:28:37 +0200	[thread overview]
Message-ID: <20160909232840.2353-1-lersek@redhat.com> (raw)

Patch #3 was submitted by Thomas originally, and it was good, but it
showed me that "OvmfPkg/Library/NvVarsFileLib/FsAccess.c" had LF line
terminators actually. So I ran the following command, and went through
the output:

  file $(find OvmfPkg/ -type f) | sort -t : -k 2b

The command found the following types:

  #1  ASCII text, with CRLF line terminators
  #2  C source, ASCII text
  #3  C source, ASCII text, with CRLF line terminators
  #4  C source, UTF-8 Unicode text, with CRLF line terminators
  #5  POSIX shell script, ASCII text executable
  #6  Python script, ASCII text executable, with CRLF line terminators
  #7  a /usr/bin/env bash script, ASCII text executable

>From these, types #2 and #4 are problematic, so I added two patches in
front of Thomas's to eliminate those file types (by converting the
files).

(I also ran the command on ArmVirtPkg, it was fine.)

Public branch: <https://github.com/lersek/edk2/commits/cosmetic_fixes>.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Thomas Huth <thuth@redhat.com>

Thanks
Laszlo

Laszlo Ersek (2):
  OvmfPkg/IndustryStandard: make "Xen/grant_table.h" pure ASCII
  OvmfPkg: convert C files with LF line terminators to CRLF

Thomas Huth (1):
  OvmfPkg: Fix typing errors

 OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c              |    2 +-
 OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c           |    4 +-
 OvmfPkg/Include/IndustryStandard/Xen/grant_table.h   |    2 +-
 OvmfPkg/Library/NvVarsFileLib/FsAccess.c             | 1034 ++++++++++----------
 OvmfPkg/Library/NvVarsFileLib/NvVarsFileLib.c        |  166 ++--
 OvmfPkg/Library/NvVarsFileLib/NvVarsFileLib.h        |  122 +--
 OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c |    8 +-
 OvmfPkg/PlatformPei/MemDetect.c                      |    2 +-
 OvmfPkg/QemuVideoDxe/VbeShim.c                       |    2 +-
 OvmfPkg/SmbiosPlatformDxe/X86Xen.c                   |  196 ++--
 OvmfPkg/VirtioRngDxe/VirtioRng.h                     |   92 +-
 OvmfPkg/XenBusDxe/EventChannel.c                     |    2 +-
 OvmfPkg/XenBusDxe/XenStore.c                         |    2 +-
 OvmfPkg/XenPvBlkDxe/BlockIo.c                        |    2 +-
 14 files changed, 818 insertions(+), 818 deletions(-)

-- 
2.9.2



             reply	other threads:[~2016-09-09 23:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09 23:28 Laszlo Ersek [this message]
2016-09-09 23:28 ` [PATCH 1/3] OvmfPkg/IndustryStandard: make "Xen/grant_table.h" pure ASCII Laszlo Ersek
2016-09-12  6:43   ` Thomas Huth
2016-09-09 23:28 ` [PATCH 2/3] OvmfPkg: convert C files with LF line terminators to CRLF Laszlo Ersek
2016-09-12  6:49   ` Thomas Huth
2016-09-12 11:23     ` Laszlo Ersek
2016-09-09 23:28 ` [PATCH 3/3] OvmfPkg: Fix typing errors Laszlo Ersek
2016-09-10  0:17 ` [PATCH 0/3] OvmfPkg: cosmetic fixes Jordan Justen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160909232840.2353-1-lersek@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox